From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B256C433E1 for ; Fri, 3 Jul 2020 06:39:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6085E208C7 for ; Fri, 3 Jul 2020 06:39:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726379AbgGCGjF (ORCPT ); Fri, 3 Jul 2020 02:39:05 -0400 Received: from smtp.al2klimov.de ([78.46.175.9]:60148 "EHLO smtp.al2klimov.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726053AbgGCGjE (ORCPT ); Fri, 3 Jul 2020 02:39:04 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by smtp.al2klimov.de (Postfix) with ESMTPA id CEA5DBC146; Fri, 3 Jul 2020 06:38:53 +0000 (UTC) Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: BPF (Safe dynamic programs and tools) To: Alexei Starovoitov Cc: Jonathan Corbet , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , Andrii Nakryiko , John Fastabend , KP Singh , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Alexey Kuznetsov , Hideaki YOSHIFUJI , Thomas Gleixner , Ingo Molnar , Borislav Petkov , X86 ML , "H. Peter Anvin" , Steven Rostedt , Shuah Khan , Stanislav Fomichev , Quentin Monnet , Andrey Ignatov , "open list:DOCUMENTATION" , Network Development , bpf , LKML , "open list:KERNEL SELFTEST FRAMEWORK" , Clang-Built-Linux ML References: <20200702200516.13324-1-grandmaster@al2klimov.de> From: "Alexander A. Klimov" Message-ID: Date: Fri, 3 Jul 2020 08:38:52 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spamd-Bar: + Authentication-Results: smtp.al2klimov.de; auth=pass smtp.auth=aklimov@al2klimov.de smtp.mailfrom=grandmaster@al2klimov.de Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 03.07.20 um 00:08 schrieb Alexei Starovoitov: > On Thu, Jul 2, 2020 at 1:05 PM Alexander A. Klimov > wrote: >> >> Rationale: >> Reduces attack surface on kernel devs opening the links for MITM >> as HTTPS traffic is much harder to manipulate. >> >> Deterministic algorithm: >> For each file: >> If not .svg: >> For each line: >> If doesn't contain `\bxmlns\b`: >> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: >> If both the HTTP and HTTPS versions >> return 200 OK and serve the same content: >> Replace HTTP with HTTPS. >> >> Signed-off-by: Alexander A. Klimov >> --- >> Continuing my work started at 93431e0607e5. >> >> If there are any URLs to be removed completely or at least not HTTPSified: >> Just clearly say so and I'll *undo my change*. >> See also https://lkml.org/lkml/2020/6/27/64 >> >> If there are any valid, but yet not changed URLs: >> See https://lkml.org/lkml/2020/6/26/837 >> >> Documentation/bpf/bpf_devel_QA.rst | 4 ++-- >> Documentation/bpf/index.rst | 2 +- >> Documentation/networking/af_xdp.rst | 2 +- >> Documentation/networking/filter.rst | 2 +- >> arch/x86/net/bpf_jit_comp.c | 2 +- >> include/linux/bpf.h | 2 +- >> include/linux/bpf_verifier.h | 2 +- >> include/uapi/linux/bpf.h | 2 +- >> kernel/bpf/arraymap.c | 2 +- >> kernel/bpf/core.c | 2 +- >> kernel/bpf/disasm.c | 2 +- >> kernel/bpf/disasm.h | 2 +- >> kernel/bpf/hashtab.c | 2 +- >> kernel/bpf/helpers.c | 2 +- >> kernel/bpf/syscall.c | 2 +- >> kernel/bpf/verifier.c | 2 +- >> kernel/trace/bpf_trace.c | 2 +- >> lib/test_bpf.c | 2 +- >> net/core/filter.c | 2 +- >> samples/bpf/lathist_kern.c | 2 +- >> samples/bpf/lathist_user.c | 2 +- >> samples/bpf/sockex3_kern.c | 2 +- >> samples/bpf/tracex1_kern.c | 2 +- >> samples/bpf/tracex2_kern.c | 2 +- >> samples/bpf/tracex3_kern.c | 2 +- >> samples/bpf/tracex3_user.c | 2 +- >> samples/bpf/tracex4_kern.c | 2 +- >> samples/bpf/tracex4_user.c | 2 +- >> samples/bpf/tracex5_kern.c | 2 +- >> tools/include/uapi/linux/bpf.h | 2 +- >> tools/lib/bpf/bpf.c | 2 +- >> tools/lib/bpf/bpf.h | 2 +- >> tools/testing/selftests/bpf/test_maps.c | 2 +- >> tools/testing/selftests/bpf/test_verifier.c | 2 +- >> 34 files changed, 35 insertions(+), 35 deletions(-) > > Nacked-by: Alexei Starovoitov > > Pls don't touch anything bpf related with such changes. https://lore.kernel.org/linux-doc/20200526060544.25127-1-grandmaster@al2klimov.de/ – merged. https://lore.kernel.org/linux-doc/20200608181649.74883-1-grandmaster@al2klimov.de/ – applied. https://lore.kernel.org/linux-doc/20200620075402.22347-1-grandmaster@al2klimov.de/ – applied. https://lore.kernel.org/linux-doc/20200621133512.46311-1-grandmaster@al2klimov.de/ – applied. https://lore.kernel.org/linux-doc/20200621133552.46371-1-grandmaster@al2klimov.de/ – applied. https://lore.kernel.org/linux-doc/20200621133630.46435-1-grandmaster@al2klimov.de/ – applied. https://lore.kernel.org/linux-doc/20200627103050.71712-1-grandmaster@al2klimov.de/ – applied. https://lore.kernel.org/linux-doc/20200627103125.71828-1-grandmaster@al2klimov.de/ – reviewed. https://lore.kernel.org/linux-doc/20200627103151.71942-1-grandmaster@al2klimov.de/ – reviewed. This one – no, pls not. Why exactly not? Are these URLs not being opened at all (What they're doing there then?) or have all who open them the HTTPS everywhere browser addon installed? >