From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BE941DD543 for ; Thu, 5 Dec 2024 16:41:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733416907; cv=none; b=ZClIF0is94h6Owk/hVjJC9pHms5AA6W3/1oegOy35iAyYf6ylCu0LC4xgkEpB2gvTr9yvXslN4EmCkIXt9iAG18oqlisKrJIWLOCwJJORgkO4xJskWbU1U7MhDrQ6FNB7u7bWPIcXYmv4RTt0JJ5zrxUtcyl52ElTzcc8+BqZmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733416907; c=relaxed/simple; bh=8tCfC6DI8nuiZrU/l+7ThDzR1R+6npDRvcbfa4SjJvk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K+EpJtZozvOLsgfYo8FMClTGPF4W9YNC/85bARTRgNZs1VI8WOsx17U1cHwH7faedLFyMcL06IiPYIF8SvR8QCgppHC2izYqjIdo3QgwflJKdpdj21r2v/RGS/gEdHP7W2pA5EDJ6pJ7EDWZpiQ5Oy6Cix20SvUi9KEx1pOECWU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cUF+4QTf; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cUF+4QTf" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4B59wlGF031112 for ; Thu, 5 Dec 2024 16:41:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +VFuxyop2PNnaSHls4qUW96mpevEXDauAAvPu4uj094=; b=cUF+4QTfTryaaSAQ Igi16o5VeA5W+NR+D66HhfrmKAHoDfXB7pnCJMkAiGzLgfQc5uWiqCeh/13+Tcib whg/bnX5Bj554PEuDDwReSB1S44DeQhznfdWNYrWTFEDhh1LeBBzdM1su6q3Qsi3 KocdHlzvYZMIcugnMvPqyuCjIuaPp+EK6Pxgzi2dSWX1red8w/GGNIvKf9bibc42 slkVoc0Bn76/qLuDS4LsJ43a6N7vL8o0mg/j/V13LqO6t/WWx73HNTNK36jDpHb8 fItg0CEgIDKoaWUkGC6qx5L2BTNIkt3j2LadeLxNg4IW+BKepBcOiLhawXmfukBY r5K+lw== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 43ba1413jq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 05 Dec 2024 16:41:44 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7b67127ab77so6996985a.3 for ; Thu, 05 Dec 2024 08:41:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733416904; x=1734021704; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+VFuxyop2PNnaSHls4qUW96mpevEXDauAAvPu4uj094=; b=o6GmeQXcwN6rSurw7/nL/yRtetwDLK2+QI99etuwUhaEHMNWBDGtrtAK4GI35nlFQC ejH+MeTJWtsFcWcYgxd8RhgM3hFghEbx93rd72GgIYv5BG7qbRNFcl+tUQt6hlkj0n7Y 6+vCq1urH62Ks7tP34uURjg6KSvC9BDiUgCHPLu+R6wC256UWxi0bVp+vuit+ldbs0lg wMqHB1d0gtN0bx8z/Zte7O4//NtgxTLfZ2F9OTXyiBaQmjIy2Yti3SnJtIzogzpe7u+X zY2oyHLPQWHXVNZwjTGJOqteWKHGrsdiKxWlY9FwbC2u79Jsz3ZCR5Hi2/beOzfsDM9n aOcA== X-Forwarded-Encrypted: i=1; AJvYcCUraej2PasLNOr6A2iG75WqiW9unuTPWcjVxyVB+Ad8+pEPk16jDCL9oxKHm+1Q46/2RilYonEBt2gHx+M=@vger.kernel.org X-Gm-Message-State: AOJu0YywkV+X+UpSw2oE2fCTTfqRwJ57Q7Rq5vWUlnbgMfLDLCaa4x48 KfvmgxUfvgOFHOb3rycQGliOzzl3Xjpz7ei0WJqCDkoaTrHQHKUF3exJXWVyeVs/DW/EcDd3dhB +Im1LMQM3co3f4wwE333YhW5v68HzY6pbijrZJ+UO5/m1iQwspVIUGAAcuDBD/fElX1FmgFg= X-Gm-Gg: ASbGnctl2G4iXkOVxwwe/iCdUD0Z1l6z4ibzg0DBbVjaYa+nx9Lqdckpwvd//ajzOwn JIpfiv+lbyp+0IRV1Neus8eQ8xNwNOH6FlJGTI09rYyD9ESjE/9zjQbCSUeWQCxiSCa+1XFVc3F Pn1/jb/Yrha174+n6rhnFUyYXTlTmzeJ+Zr64uoejIbl066EDKD40XuN7OS1gAoWo0SKPjK0aNx KktskIl3/E5vgfMzxGIcgI47FHBf1T6oVNr03nu44BksJU+YGqi2Gh9xtSplHFo+PrH8Xcr8qaS zOFC0ipviQK3h+Bk701k4pHVmzHl5Hw= X-Received: by 2002:a05:620a:40c1:b0:7b3:2107:2eef with SMTP id af79cd13be357-7b6a61fc9e3mr649623785a.16.1733416903966; Thu, 05 Dec 2024 08:41:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IHDAYsrnvectLyVPPs3uQAzrZhInb/RiKYTZnAB1ahxYrWqzq0rvF35LDg9VeTAi8PUk++rCw== X-Received: by 2002:a05:620a:40c1:b0:7b3:2107:2eef with SMTP id af79cd13be357-7b6a61fc9e3mr649622885a.16.1733416903640; Thu, 05 Dec 2024 08:41:43 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d149a25cc5sm998819a12.7.2024.12.05.08.41.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Dec 2024 08:41:43 -0800 (PST) Message-ID: Date: Thu, 5 Dec 2024 17:41:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 03/12] arm64: dts: qcom: sdm845-starqltechn: fix usb regulator mistake To: Dzmitry Sankouski Cc: cros-qcom-dts-watchers@chromium.org, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241008-starqltechn_integration_upstream-v6-0-5445365d3052@gmail.com> <20241008-starqltechn_integration_upstream-v6-3-5445365d3052@gmail.com> <33e14868-e6ee-45ca-b36c-c553e0dcfbef@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: zB63dk4b7pkKttFBOfPi3xXE4zvbO9DO X-Proofpoint-ORIG-GUID: zB63dk4b7pkKttFBOfPi3xXE4zvbO9DO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 bulkscore=0 phishscore=0 clxscore=1015 mlxscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 suspectscore=0 mlxlogscore=983 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412050121 On 2.12.2024 9:10 PM, Dzmitry Sankouski wrote: > пн, 2 дек. 2024 г. в 18:09, Konrad Dybcio : >> >> On 2.12.2024 2:41 PM, Dzmitry Sankouski wrote: >>> сб, 26 окт. 2024 г. в 13:41, Konrad Dybcio : >>>> >>>> On 8.10.2024 6:51 PM, Dzmitry Sankouski wrote: >>>>> Usb regulator was wrongly pointed to vreg_l1a_0p875. >>>>> However, on starqltechn it's powered from vreg_l5a_0p8. >>>>> >>>>> Fixes: d711b22eee55 ("arm64: dts: qcom: starqltechn: add initial device tree for starqltechn") >>>>> Signed-off-by: Dzmitry Sankouski >>>>> >>>>> --- >>>> >>>> I really really doubt that the supplies for on-SoC PHYs were altered, >>>> given these regulators are assigned based on their specific characteristics >>>> >>> >>> From rooted android system from klabit87 on starqltechn: >>> >>> ``` >>> starqltechn:/ # cat /proc/cpuinfo | grep Hardware >>> Hardware : Qualcomm Technologies, Inc SDM845 >>> starqltechn:/ # uname -a >>> Linux localhost 4.9.186-klabitV6.5 #1 SMP PREEMPT Thu Dec 10 19:42:53 >>> CST 2020 aarch64 >>> starqltechn:/ # cat >>> /sys/kernel/debug/regulator/soc:rpmh-regulator-ldoa1-pm8998_l1/consumers >>> Device-Supply EN Min_uV Max_uV load_uA >>> ae90000.qcom,dp_display-vdda-0p9 N 880000 880000 0 >>> 1d87000.ufsphy_mem-vdda-phy Y 880000 880000 62900 >>> ae96400.qcom,mdss_dsi_phy0-vdda-0p9 N 0 0 0 >>> ae94400.qcom,mdss_dsi_phy0-vdda-0p9 Y 880000 880000 36000 >>> 1c00000.qcom,pcie-vreg-0.9 Y 880000 880000 24000 >>> pm8998_l1 N 0 0 0 >>> starqltechn:/ # cat >>> /sys/kernel/debug/regulator/soc:rpmh-regulator-ldoa5-pm8998_l5/consumers >>> Device-Supply EN Min_uV Max_uV load_uA >>> ae90000.qcom,dp_display-vdda-usb1-ss-core N 0 0 0 >>> 88e2000.qusb-vdd Y 800000 800000 0 >>> 88e8000.ssphy-vdd Y 800000 800000 0 >>> pm8998_l5 N 0 0 0 >>> ``` >>> >>> I also downloaded kernel source from Samsung, to check its dts, >>> and it also powers qusb@88e2000 and ssphy@88e8000 from 'pm8998_l5' regulator. >> >> Interesting.. could you try to forcefully shut down L5A (I doubt you'll >> be able to do so with L1A given it powers so much digital logic), or >> set its regulator-min&max-microvolt to a way-too-low voltage (vmin >> seems to be 312000)? >> >> You should then be able to tell fairly easily, depending on whether usb2 >> still works after a replug >> > > Usb doesn't worked in such experiment: > Here's the log: > ``` > [ 3.541733] ldo5: Setting 312000-312000uV > ...... > [ 3.808224] dwc3 a600000.usb: Adding to iommu group 5 > [ 3.823116] qcom-qmp-combo-phy 88e8000.phy: phy initialization timed-out > [ 3.824323] phy phy-88e8000.phy.0: phy init failed --> -110 > [ 3.825916] dwc3 a600000.usb: error -ETIMEDOUT: failed to initialize core > [ 3.827208] dwc3 a600000.usb: probe with driver dwc3 failed with error -110 > [ 3.828548] probe of a600000.usb returned 110 after 20399 usecs Wow, I'm really surprised That said, thank you for confirming Konrad