From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5437E1F4171 for ; Tue, 5 Aug 2025 16:32:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754411525; cv=none; b=BwMoQHYSg93IVGeBQ9j5DHJhNz0xAV64LSCQ0aHU4oWFA3R3rHVWDV2BHTuJVzD9UG0whEh9AS/yD2/CJ88/rHL638RkbWTUeARaoZ+Nr7EazLZEWD0W5hy5LcKvQAkdI50fk9CL9FcisEa7QTOr2kZRvdxh5luPv51S/AaNQj0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754411525; c=relaxed/simple; bh=BtAiTgvkkjlBfBvo6XtHgXIfvNar7zG5HMSPnNCDLis=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RUBMSNGlD6zWPJaUKM1XS+wu5TzuWoqFyMTNZ7BOQrF2ZGIBvlR71ehl39kei0tc+0SCbbkkzKJ8MaLQ9UKpn4EbtBVGwIYw9lk1q3wYU2vBREvTL86d4xlLn3MO8N4t99NUQmMMQakR6qkB6WxsCpGYbRonLUMiYi8qh8koWpw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=olh5lgbJ; arc=none smtp.client-ip=209.85.210.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="olh5lgbJ" Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-742f798bb20so942987a34.1 for ; Tue, 05 Aug 2025 09:32:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1754411522; x=1755016322; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uur0nAlqBULqZvR/jwBKMPpy4vyoMv3vayFy80V0+TM=; b=olh5lgbJz3G8eGxz3o1+JTfTxq8xc6A7F/ypesiL0QnKyk8KGlHZvIyF5mPt2BxtBb 36b0C299hrljswibQaZ/8l244n7/XLt4uAA1OjHGrg08J3YWM7wanPwq0i//l2FxW1hU R+TYVrkjDCN65gny2zW76xDKuyTAI2+vDkxGFrCp8NDsAofGwECNnxofrCJLgBikzIAX oZFyorRgzmWBdzgtEEXF2RZiuV9ONMEh+mMltZObCgg5PqH8QJx7R98hGGOWKaJlcugb M4jHJOGCuvdjoBanNPDew715cUcntDzU6wkeTV1Gti0H3hPduRwo/PdQIuNSCul9I9cA PGuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754411522; x=1755016322; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uur0nAlqBULqZvR/jwBKMPpy4vyoMv3vayFy80V0+TM=; b=q0Hfm+Bv7rBv3cH2Le4JNOSKCsbFSRuyP21s0A56A41P8QA/JgTHFHSxeqZG34cdnt 7MVHDtbxNvmeqsFwe00F/2OWioAMUGvkMLECSLRubJg0/rVYcRgCqsa6Fy0Hp9F3weJl 1+qC15qzGQmC+A3cAVEsFRh6XPkOGgEdasunVFkSZQhuKwJjz6sPrZDzbB1S4UGEt1T8 EHiDF+idObYmZkvcGiFW/pLP9HrboKnOfOoNMqqUiZkK7PlhbMMGoUZss/OATQgx/IOC o+Rzlry9+mg52GQw3EX/Gq9ALL/xL35cl5Dqg8ybzHpwDiEU2ddf25kw7JNNDF5nkAmt cS6w== X-Forwarded-Encrypted: i=1; AJvYcCUbQk9x6vVojn+rLrMU5YY0l/c2YKtTkf9s/ZsFwRV05Oj1Njm0suehXTbcwg8rMfxxvvXRbFq5Pblqp6g=@vger.kernel.org X-Gm-Message-State: AOJu0Ywt4ULS5d1PPdj30KH3AmEe+O4//xU/IjksKZ0wPwRXDBAIfjxj jvyoZo7XNWbrFffDZrnGcXO9JBYrAS7kvhAdFI+YIwrJLxsMp11HXj4A6Mf3FEvFmo/KFnbjHw3 sPeWL X-Gm-Gg: ASbGncu2mbV0oMeC0+h53XToBwpl88S7XTU/JgI8uUAa4u+HPSr12Aa8HKOJEKJ4WkE MNdJNBeXJJmt/SPAzHvZrjz1ACTpscNuP4WbgF5cXUgET/VLyEtNK1KhQeP0B1ya3rAntEcHtuh 3sqKgbfULqTOjHqaEhd/Yvg0POmI88sNmEf0jnRP6IAg1PCyljGn+0IXE71ZKfOYOHjmW6X9G3T sP03llH0VluzUpOdnBsGASTpeWtfKmaiBy07oNlEDBP46nYic7wdfIMytRkTmurmrEoYHAb6zKQ ASsRZ1fuZS+F6ut8w91ZDgZXFRwc5p/Vb4bYh5fTg4Z+2cLrbxkWedoDNzi7ovmbXHouTKnMIm0 2uwHHDn7iOFE/9LOHFcm8nh/PB86HnU5uqxKp9wttITg/7kZZtjTApXSgbNH+piqFyOsfKrvKNL w= X-Google-Smtp-Source: AGHT+IEnvk2d31UKd+tMc+mbVq2Ah+wE3Sz5iHZ3ZBziMqKMBF0tm8r034C7Lrlr2Q0zurnS1hQADw== X-Received: by 2002:a05:6830:280b:b0:741:21b8:b24d with SMTP id 46e09a7af769-7419d0e6299mr9460158a34.5.1754411522370; Tue, 05 Aug 2025 09:32:02 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:1d00:cc63:6a65:89f9:fe4a? ([2600:8803:e7e4:1d00:cc63:6a65:89f9:fe4a]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-74186a0f8c1sm2849781a34.0.2025.08.05.09.32.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Aug 2025 09:32:01 -0700 (PDT) Message-ID: Date: Tue, 5 Aug 2025 11:32:01 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] iio: magnetometer: add support for Infineon TLV493D 3D Magentic sensor To: Dixit Parmar , Jonathan Cameron Cc: =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org References: <20250802-tlv493d-sensor-v6_16-rc5-v2-0-e867df86ad93@gmail.com> <20250802-tlv493d-sensor-v6_16-rc5-v2-1-e867df86ad93@gmail.com> <20250802124333.67f64863@jic23-huawei> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/3/25 10:18 PM, Dixit Parmar wrote: >>> +static const struct iio_buffer_setup_ops tlv493d_setup_ops = { NULL }; >> >> No need specify that NULL. Due to some odd quirks of compiler specific >> handling and C spec evolution (none of which apply to the kernel because >> we carefully choose build options) that is actually less likely to do what >> you want than = { }; >> > Originally it was { } in V1. Got review comment that it must have NULL > if no ops is being passed, so I added (May be I would have asked and > understand their point). Nevertheless will remove NULL. We don't need tlv493d_setup_ops at all. The NULL comes later where tlv493d_setup_ops was used: ret = devm_iio_triggered_buffer_setup(dev, indio_dev, iio_pollfunc_store_time, tlv493d_trigger_handler, NULL);