From: "Sven Peter" <sven@svenpeter.dev>
To: "Hector Martin" <marcan@marcan.st>
Cc: "Alyssa Rosenzweig" <alyssa@rosenzweig.io>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: apple: apple-pmgr-pwrstate: Do not build as a module
Date: Wed, 15 Dec 2021 12:34:31 +0100 [thread overview]
Message-ID: <b082f563-833c-4813-948c-eb498fe84817@www.fastmail.com> (raw)
In-Reply-To: <20211215112935.238561-1-marcan@marcan.st>
On Wed, Dec 15, 2021, at 12:29, Hector Martin wrote:
> This doesn't make any sense as a module since it is a critical device,
> and it turns out of_phandle_iterator_args was not exported so the module
> version doesn't build anyway.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>
I think it'd be nice to add Reported-by: kernel test robot <lkp@intel.com>
here since their service found it and maybe also a Fixes: tag.
Reviewed-by: Sven Peter <sven@svenpeter.dev>
Sven
prev parent reply other threads:[~2021-12-15 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 11:29 Hector Martin
2021-12-15 11:34 ` Sven Peter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b082f563-833c-4813-948c-eb498fe84817@www.fastmail.com \
--to=sven@svenpeter.dev \
--cc=alyssa@rosenzweig.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®