From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christoph Hellwig <hch@lst.de>,
"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"dhowells@redhat.com" <dhowells@redhat.com>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Amir Goldstein <amir73il@gmail.com>
Subject: Re: [PATCH v2] fs: rename S_KERNEL_FILE
Date: Fri, 28 Jan 2022 09:01:00 +0000 [thread overview]
Message-ID: <b0870835-58a6-39bb-2640-4595217999f0@nvidia.com> (raw)
In-Reply-To: <20220128074731.1623738-1-hch@lst.de>
On 1/27/22 11:47 PM, Christoph Hellwig wrote:
> S_KERNEL_FILE is grossly misnamed. We have plenty of files hold open by
> the kernel kernel using filp_open. This flag OTOH signals the inode as
> being a special snowflake that cachefiles holds onto that can't be
> unlinked because of ..., erm, pixie dust. So clearly mark it as such.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Amir Goldstein <amir73il@gmail.com>
> ---
>
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
next prev parent reply other threads:[~2022-01-28 9:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 7:47 Christoph Hellwig
2022-01-28 9:01 ` Chaitanya Kulkarni [this message]
2022-01-28 10:12 ` David Howells
2022-01-28 11:09 ` Amir Goldstein
2022-01-28 11:35 ` David Howells
2022-01-28 13:17 ` Al Viro
2022-01-28 15:24 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0870835-58a6-39bb-2640-4595217999f0@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=amir73il@gmail.com \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®