From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F0B7F43C059 for ; Fri, 15 May 2026 09:34:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778837687; cv=none; b=GYCEg1DdqneYohOUiggOB2mWy19LTNQNprLD/1S0awzxwcefGNdST2GVq3YeJRn9mCzpFoHFCjB6l0rL53/kn9qyJaqzeMCohFFx3Lmscly436fKYfwkembAnebTDwzK5vE4Oth/STdYkEtC7byHiNRWVxccr1SzKu1luZZQ6EI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778837687; c=relaxed/simple; bh=d5TDtYzI9w9Jk0kTA7y3095OiTVtLkpBULbGj2ZeDdE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OBheGxwbqaE4s0bIqOIR+IVf2Z+rOK3uBc/fqdEtpwmfYZwTEQ/sDH596VEP/aGn8taoVruM64OPzlKQyrrlYFT6VAEiWv/WFhkL7Rq0OX3sK7piHE+3XiR3pDA0TQq9DNLWAT7alIvW1aPCI7pm0jdiUErIQ235uoZ7EADfh+0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=fzdnzxJw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OpsBnUIq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="fzdnzxJw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OpsBnUIq" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64F5AADP3512994 for ; Fri, 15 May 2026 09:34:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Idy9O1/Dyo4K+bVwNzgOYiQX/lyoKUQI77/LaO7XvG0=; b=fzdnzxJwza6LS0PC ZCpxdKKi5FfX7dT8VTVbwdcSuvCZ6dGssi/sLzl6rKr/SRxfd6oBSHqhbJYTWRcR rUiiPaH5B2+Pau8VJt7JTKfdK5MURxb17N04y0eMGuUinR0xXfZ921k7VKFkiLKd 3gQHNhJJvHVh2kypO4aKcLG94OvH14aBUQHxuLchoDXvpIdVgy58AtXC1ftGH5aC TCkJIEm0uWGQpIKGabG+3J4R3hF6Y6O9rnQYvby6hdFk1x0TgwnSF6M1bwr2JE0a MP5dmwi0B+61qC20vgGl0vUn/r8bt52SfIXV0+61RN9MH+LXH0j7TwQ11hu9oJ9A v5Hafw== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5m1vamvf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 09:34:44 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-63132c52758so458142137.2 for ; Fri, 15 May 2026 02:34:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778837684; x=1779442484; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Idy9O1/Dyo4K+bVwNzgOYiQX/lyoKUQI77/LaO7XvG0=; b=OpsBnUIqNW2jJ6Vz4KCZmop12qF9RoH+RNh37GnrN9cN3ptK+/xI9KRUVKasQH7Veq vODpkR0Eh2gPOzz8vNZgiiEfXVrJkD5+Hq/7Z6MKB4s/GE9QsVLK32bw6CbVA+49Lsb+ K+CPH8ebsCcVpNuTzn2pA3N98IxDKFj/B5s6sNIoydzKL1v0Nu/VdDLos3URIV046CRT /ALygIUGCWsGlScNhbG0830nfCZ6Kd2m8mP781r2yQJWZO3rcFvbSA07JO8UlXZEptGZ CvU3Wom4EEXFNM5K4OYVVWQQW8psLDfS6Pgq6skoRTJ+fJQAQc0MG/kCqWSmw51Onk0u rTGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778837684; x=1779442484; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Idy9O1/Dyo4K+bVwNzgOYiQX/lyoKUQI77/LaO7XvG0=; b=EoNo+BiWa/gZ3tMSL5VFgERAR491XJkpov96Rz6g4tIdLHoz8r5Wv9bWo0dS7HyWTp 6+oWLLcrgpFWwDr3mswCpHweqqd0WhSqJIyWxb7gdf3BgBoZNDFVIBwhf6aV2dD8n7+Y ywqgJADSudH4VHFnJ7qNKBhlyr104U0qgxj3R0R+rAx9Q1KAjKmer3S4J2C6uWa/Vvt5 olLeR2ElrkZVzvYjRb2Hn8MQK58+VaWkszl2knE3ah9pMwZoTAo2kVLzrxWHoG98p2Jf J9x17IsdrxoeHN6FBcXcO+SMs1I9N1St3JtYTEQKi0KfyPNVzUdniQNDgshmrLllohyi USQQ== X-Forwarded-Encrypted: i=1; AFNElJ/jv49v099PEkxkBp5lkog7dYeIg7GB0APzBTJeSgDK1X7qWpWahTb8da8Rsn/IemTwuTTeBkRidFqqqGQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyINokn7zwCTW5sG4qTQK4/aE0nIa7pHfoSgm86XQoUB4k23yjH pGKB4+0mbuU7DNY2Gi1CGfWlwzOPbqNT1Nr6B5kXy359zvC3+CadGYieEmZSrP+gDKYDvfaXBFG oth2KmqJIR280/rz7pffPJB2MzYGTy4WhxyefnuO9au2ftkZBbve6lMhRZydhVASJ/4Y= X-Gm-Gg: Acq92OF65skJeITLxkfeF2npLEgt1eYPQaGM8+RBetvR1qwA4n6rlpq010oaVuk26yJ Tu3+cAjXSenuZY87O/VNjpxe58fY9GX+p4eLv9gAYgfu9LSSncH7ThgvmAOniBBN4yAg3eQpX2L kbpwf2Z/gDQyKGcE/ucoyEgrn8skcYvC/1WiRX8gII4VB//q7IZxlFwandGhlPBOEMFZDQPEKEA X1uPN1nhj438WNTgk7x+QbunAfVySqh2MHN59TzQBrYKORunuDYj4r8VZR9YG87Sd4yHQPvs6lk iZjxDKOjTiASJ4x+G8+8ARIzeVNeoB8QIVkL3P35hw0roqadjefzfeZw3eje55zZu/ZV7oTdKU1 vU3YRJhWE+UtrOU5zZZCELRm//p2h/RuxsEAhQm7M1K8iIfGMM72p/8sYtALsGbsiJHFINksZky lHtFE= X-Received: by 2002:a05:6102:5e5:b0:631:25ab:8bbe with SMTP id ada2fe7eead31-63a3f69868bmr387251137.5.1778837684147; Fri, 15 May 2026 02:34:44 -0700 (PDT) X-Received: by 2002:a05:6102:5e5:b0:631:25ab:8bbe with SMTP id ada2fe7eead31-63a3f69868bmr387242137.5.1778837683686; Fri, 15 May 2026 02:34:43 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bd4f4dea94bsm195294766b.33.2026.05.15.02.34.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 02:34:42 -0700 (PDT) Message-ID: Date: Fri, 15 May 2026 11:34:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] thunderbolt: Require nhi->ops be valid To: Mika Westerberg , Konrad Dybcio Cc: Andreas Noever , Mika Westerberg , Yehezkel Bernat , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, usb4-upstream@oss.qualcomm.com, Raghavendra Thoorpu References: <20260513-topic-usb4_nonpcie_prepwork-v3-0-b87b5e408ac7@oss.qualcomm.com> <20260513-topic-usb4_nonpcie_prepwork-v3-3-b87b5e408ac7@oss.qualcomm.com> <20260515063058.GH84797@black.igk.intel.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260515063058.GH84797@black.igk.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDA5NSBTYWx0ZWRfX9o/yb4qmb6hz bMQHclQ9BiIoBqMstzY5ess5ZeHn85XZvHDlHgImTwVW+sLlDs7w6hEdYMAotQ8swR2mUW5XOr+ KqIuQPT/wpTfPxML+5V4lkEeb91XE0jjVqKax7u1XG3k0P/UAQwpA3PDshWJLoqlhOF7vJPBlKx FSMQ7AyP+sleEpl29jkN84wqaw5k1Vw3HN+wYhrrzElqSXZjsLGTTNsXLAY1PHtoZekudC9PaLI nhMF53UriXz3alFxhPMJ4S9VdC3n+xgOWSC0vK0puyHaNqwmczOHiCLDaNTBMOTl0xq5ztV1OpL fOaQpl74ZVCcZp6I8BFxqmp7XQtyT2MgduEns9bkfQfQskKAuYYlUkJ8x/XK4a+a2SbEaBVyIOY TiEyZouEVivYR0soq/xsVPN7VA3yAK0nWbWb6H0SWi4bt4lxSUz+9+yUsLf+Bpmwt9PAuKVUCdw P+4L2YHZev8B9MQpgMA== X-Proofpoint-GUID: nW4jfWYRt5S69LoatQQgSkohb1lD2oVI X-Proofpoint-ORIG-GUID: nW4jfWYRt5S69LoatQQgSkohb1lD2oVI X-Authority-Analysis: v=2.4 cv=BvqtB4X5 c=1 sm=1 tr=0 ts=6a06e8b4 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=uV_RWfb6zAIlQyuJedoA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 phishscore=0 clxscore=1015 priorityscore=1501 spamscore=0 malwarescore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150095 On 5/15/26 8:30 AM, Mika Westerberg wrote: > On Wed, May 13, 2026 at 06:23:34PM +0200, Konrad Dybcio wrote: >> From: Konrad Dybcio >> >> Because of how fundamental ops->init_interrupts() is, it no longer >> makes sense to consider cases where nhi->ops is NULL. >> >> Drop some boilerplate around it and add a single sanity-check in >> nhi_probe() instead. >> >> Signed-off-by: Konrad Dybcio >> --- >> drivers/thunderbolt/nhi.c | 32 ++++++++++++++++++-------------- >> drivers/thunderbolt/switch.c | 6 +++--- >> 2 files changed, 21 insertions(+), 17 deletions(-) >> >> diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c >> index 740c10ee852b..2a8d1b3716c0 100644 >> --- a/drivers/thunderbolt/nhi.c >> +++ b/drivers/thunderbolt/nhi.c >> @@ -559,7 +559,7 @@ static struct tb_ring *tb_ring_alloc(struct tb_nhi *nhi, u32 hop, int size, >> if (!ring->descriptors) >> goto err_free_ring; >> >> - if (nhi->ops && nhi->ops->request_ring_irq) { >> + if (nhi->ops->request_ring_irq) { > > I wonder if it makes this more readable if we wrap these like: > > if (nhi_request_ring_irq(nhi)) { The UFS subsystem does that, and it results in a ton of boilerplate, i.e. for each op you need to define something like a: static inline T nhi_foo_bar(struct tb_nhi *nhi, ...) { if (nhi->ops->foo_bar) return nhi->ops->foo_bar(...); return 0; } I can do that, but I don't see real value here Konrad