From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751630AbeAELlG (ORCPT <rfc822;ralf@linux-mips.org> + 1 other);
        Fri, 5 Jan 2018 06:41:06 -0500
Received: from mail-wm0-f67.google.com ([74.125.82.67]:44835 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751357AbeAELlD (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 5 Jan 2018 06:41:03 -0500
X-Google-Smtp-Source: ACJfBoulv7l5Rz1annPVH7UFdHj482HkQYHxaBkSXDrcVDKr1VZvKJ4SRT0Zgb5UmWveM4YYazspbg==
Subject: Re: [PATCH] make RUNTIME_TESTS a menuconfig to ease disabling it all
To: Vincent Legoll <vincent.legoll@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>,
        Byungchul Park <byungchul.park@lge.com>,
        Peter Zijlstra <peterz@infradead.org>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Randy Dunlap <rdunlap@infradead.org>,
        "Luis R. Rodriguez" <mcgrof@kernel.org>,
        Nicholas Piggin <npiggin@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org
References: <20171209162742.7363-1-vincent.legoll@gmail.com>
From: Daniel Thompson <daniel.thompson@linaro.org>
Message-ID: <b08c2c97-1245-4ec5-a3ae-738b0755832e@linaro.org>
Date: Fri, 5 Jan 2018 11:40:57 +0000
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20171209162742.7363-1-vincent.legoll@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>



On 09/12/17 16:27, Vincent Legoll wrote:
> No need to get into the submenu to disable all related
> config entries.
> 
> This makes it easier to disable all RUNTIME_TESTS config options
> without entering the submenu. It will also enable one to see that
> en/dis-abled state from the outside menu.
> 
> This is only intended to change menuconfig UI, not change
> the config dependencies.

Wouldn't you need a "default y" applied to the menuconfig to achieve this?

With this patch applied defconfigs that enable LKDTM by default will no 
longer do so (default_defconfig from arch/s390 is an example although 
there are others).


Daniel.


> 
> Signed-off-by: Vincent Legoll <vincent.legoll@gmail.com>
> ---
>   lib/Kconfig.debug | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 947d3e2ed5c2..9436714254b7 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1660,7 +1660,10 @@ config DMA_API_DEBUG
>   
>   	  If unsure, say N.
>   
> -menu "Runtime Testing"
> +menuconfig RUNTIME_TESTING_MENU
> +	bool "Runtime Testing"
> +
> +if RUNTIME_TESTING_MENU
>   
>   config LKDTM
>   	tristate "Linux Kernel Dump Test Tool Module"
> @@ -1948,7 +1951,7 @@ config TEST_DEBUG_VIRTUAL
>   
>   	  If unsure, say N.
>   
> -endmenu # runtime tests
> +endif # RUNTIME_TESTING_MENU
>   
>   config MEMTEST
>   	bool "Memtest"
>