From: Matthias Brugger <matthias.bgg@gmail.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 5/9] usb: xhci-mtk: remove dummy wakeup debounce clocks
Date: Fri, 13 Oct 2017 15:49:42 +0200 [thread overview]
Message-ID: <b090b7b5-5c2f-0fa3-34bd-80bace198718@gmail.com> (raw)
In-Reply-To: <ff9ee49a872084b4fc8c7fbabddc820058acb9b7.1507882470.git.chunfeng.yun@mediatek.com>
On 10/13/2017 10:26 AM, Chunfeng Yun wrote:
> The wakeup debounce clocks for each ports in fact are not
> needed, so remove them.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> drivers/usb/host/xhci-mtk.c | 33 ---------------------------------
> drivers/usb/host/xhci-mtk.h | 2 --
> 2 files changed, 35 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> index 97ba51e..d60463c 100644
> --- a/drivers/usb/host/xhci-mtk.c
> +++ b/drivers/usb/host/xhci-mtk.c
> @@ -237,25 +237,8 @@ static int xhci_mtk_clks_enable(struct xhci_hcd_mtk *mtk)
> goto sys_clk_err;
> }
>
> - if (mtk->wakeup_src) {
> - ret = clk_prepare_enable(mtk->wk_deb_p0);
> - if (ret) {
> - dev_err(mtk->dev, "failed to enable wk_deb_p0\n");
> - goto usb_p0_err;
> - }
> -
> - ret = clk_prepare_enable(mtk->wk_deb_p1);
> - if (ret) {
> - dev_err(mtk->dev, "failed to enable wk_deb_p1\n");
> - goto usb_p1_err;
> - }
> - }
> return 0;
>
> -usb_p1_err:
> - clk_disable_unprepare(mtk->wk_deb_p0);
> -usb_p0_err:
> - clk_disable_unprepare(mtk->sys_clk);
> sys_clk_err:
> clk_disable_unprepare(mtk->ref_clk);
> ref_clk_err:
> @@ -264,10 +247,6 @@ static int xhci_mtk_clks_enable(struct xhci_hcd_mtk *mtk)
>
> static void xhci_mtk_clks_disable(struct xhci_hcd_mtk *mtk)
> {
> - if (mtk->wakeup_src) {
> - clk_disable_unprepare(mtk->wk_deb_p1);
> - clk_disable_unprepare(mtk->wk_deb_p0);
> - }
> clk_disable_unprepare(mtk->sys_clk);
> clk_disable_unprepare(mtk->ref_clk);
> }
> @@ -371,18 +350,6 @@ static int usb_wakeup_of_property_parse(struct xhci_hcd_mtk *mtk,
> if (!mtk->wakeup_src)
> return 0;
>
> - mtk->wk_deb_p0 = devm_clk_get(dev, "wakeup_deb_p0");
> - if (IS_ERR(mtk->wk_deb_p0)) {
> - dev_err(dev, "fail to get wakeup_deb_p0\n");
> - return PTR_ERR(mtk->wk_deb_p0);
> - }
> -
> - mtk->wk_deb_p1 = devm_clk_get(dev, "wakeup_deb_p1");
> - if (IS_ERR(mtk->wk_deb_p1)) {
> - dev_err(dev, "fail to get wakeup_deb_p1\n");
> - return PTR_ERR(mtk->wk_deb_p1);
> - }
> -
> mtk->pericfg = syscon_regmap_lookup_by_phandle(dn,
> "mediatek,syscon-wakeup");
> if (IS_ERR(mtk->pericfg)) {
> diff --git a/drivers/usb/host/xhci-mtk.h b/drivers/usb/host/xhci-mtk.h
> index db55a12..67783a7 100644
> --- a/drivers/usb/host/xhci-mtk.h
> +++ b/drivers/usb/host/xhci-mtk.h
> @@ -126,8 +126,6 @@ struct xhci_hcd_mtk {
> struct regulator *vbus;
> struct clk *sys_clk; /* sys and mac clock */
> struct clk *ref_clk;
> - struct clk *wk_deb_p0; /* port0's wakeup debounce clock */
> - struct clk *wk_deb_p1;
> struct regmap *pericfg;
> struct phy **phys;
> int num_phys;
>
next prev parent reply other threads:[~2017-10-13 13:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-13 8:26 [PATCH v2 1/9] usb: xhci-mtk: use dma_set_mask_and_coherent() in probe function Chunfeng Yun
2017-10-13 8:26 ` [PATCH v2 2/9] usb: xhci-mtk: use ports count from xhci in xhci_mtk_sch_init() Chunfeng Yun
2017-10-13 8:26 ` [PATCH v2 3/9] usb: xhci-mtk: check clock stability of U3_MAC Chunfeng Yun
2017-10-13 8:26 ` [PATCH v2 4/9] usb: xhci-mtk: support option to disable usb3 ports Chunfeng Yun
2017-10-13 8:26 ` [PATCH v2 5/9] usb: xhci-mtk: remove dummy wakeup debounce clocks Chunfeng Yun
2017-10-13 13:49 ` Matthias Brugger [this message]
2017-10-13 8:26 ` [PATCH v2 6/9] usb: xhci-mtk: add optional mcu and dma bus clocks Chunfeng Yun
2017-10-13 13:55 ` Matthias Brugger
2017-10-13 8:26 ` [PATCH v2 7/9] usb: host: modify description for MTK xHCI config Chunfeng Yun
2017-10-13 10:32 ` Mathias Nyman
2017-10-16 3:25 ` Chunfeng Yun
2017-10-17 10:20 ` Greg Kroah-Hartman
2017-10-17 10:42 ` Mathias Nyman
2017-10-22 3:31 ` Chunfeng Yun
2017-10-13 8:26 ` [PATCH v2 8/9] dt-bindings: usb: mtk-xhci: add a optional property to disable u3ports Chunfeng Yun
2017-10-13 8:26 ` [PATCH v2 9/9] dt-bindings: usb: mtk-xhci: remove dummy clocks and add optional ones Chunfeng Yun
2017-10-13 13:56 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b090b7b5-5c2f-0fa3-34bd-80bace198718@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome