Re: Possible "struct pid" leak from tty_io.c

["Catalin Marinas" <catalin.marinas@gmail.com>]

On 09/03/07, Eric W. Biederman <ebiederm@xmission.com> wrote:
> "Catalin Marinas" <catalin.marinas@gmail.com> writes:
>
> > On 08/03/07, Eric W. Biederman <ebiederm@xmission.com> wrote:
> >> "Catalin Marinas" <catalin.marinas@gmail.com> writes:
> >
> > I think it's only the pid_chain and rcu member that could be placed in
> > a list and kmemleak scans the memory for these two offsets as well.
> > I'll check those lists anyway but I doubt it's a more fundamental
> > problem with how kmemleak handles struct pid as I should've probably
> > got more reports.
>
> Right.  I was pointing out the possibilities but because we do
> some tricky things.  Mostly I was wondering about the hlist for
> the list of tasks.  Now if a task is on that list we should have
> a struct pid_link pointing at our struct pid, so it shouldn't fool
> kmemleak but I'm still a little curious if all of those hlist_heads are
> NULL pointers.

Yes, all the 3 hlist_head tasks are NULL pointers on the reported object.

-- 
Catalin