From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754724AbdEMMyg (ORCPT ); Sat, 13 May 2017 08:54:36 -0400 Received: from mout.web.de ([212.227.15.14]:61696 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043AbdEMMye (ORCPT ); Sat, 13 May 2017 08:54:34 -0400 To: linux-mmc@vger.kernel.org, Bojan Prtvar , Linus Walleij , Paul Burton , Shawn Lin , Ulf Hansson , Uri Yanai , Tomas Winkler Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] mmc: core: Delete an error message for a failed memory allocation in three functions Message-ID: Date: Sat, 13 May 2017 14:54:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:gCCa+TpweHZ0KJhzZNnksLGWHfQ+KmyBZMtULv+kaTudGurZB3t WQ+gq4y3Bn6JERttMzM/ZFqguamBbYo32grq4nmHnB0VA1C54To1GleMMYcDAwoULxVqYse nLNgSVjQFnZedoAbmISIB9Hn0irpLQRivQpYzkeLHC+w2CANIXYPc60qlB++tJYzXiy8Rmu KNPRLY0dK12utp0WTn0pQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:i+DC6rAm0Vc=:PJGnxnRCSuF8W35cpSOzXC uxmkkPD6JiZyOt5U8P27/jrS+1QEFYz8tC+3AgfT8a0WuzYKRiy07+2ZscrchX1NlA/BNiFWa x3QyAyHLQEo9JeqYoXQAq0Fqw9N7llG5c/Ez0B77T6Axb9Pj2Q31C8jpg64ui7PajxEJc5hn9 w4YKxt5c3O7Q3HndK7mSranAj1wGCEnctQIUE9APck6N3G/pzBODKy5SCrcfryQgVsNPSXhnn 6KXlbb9vko0VGS5DXKpxDaSLc7zJ51UIt4XKwBTY6xCyVMIbKl426c4VipVn0ayRif1TuF83J zUDkDgq32JUHkCEkmBV2NV+G90ja84bUV4RKb8/deZWUc6Kl1kshyxCbr6Twf6fLWt3WBDaH1 J1Y/CtV9CNobY/8RKzHIr4GdY+UqPlVSKvPXuNGQ2HfS4TTrh1a5Wda/yT51vT+nQ8DYTFzs6 7jmmHOFKQSA7+yMakb/Dx65cWVNL+8kYx2a9amSZOxkzm5E77g1SFRYVu3XbXJi5PioLDPmDn 4A7KhQwedC4HyTbKpJyOV+JBCtE4izLR2gZGXZ3s20D+WdUgydoYOfuHTq+eFWTJAHM4/vRcU qoCgX27pxp8rHyYsPFTfw8P/xXIq4/SL63I9cgclX8qIorAiSeeGIi8E/nA3WeDoCWG4tDS12 /xbNJKiZbraMzLHgBIDmkfdj404k47wY5rOcaOSNbIoj1aZdOSxiUGSyPJguFV0jLVGGd/dPd WOyD3NROFqxHGAE9s8456afKEodQpI5ShG3XoNI5ii3Py04qrMnOBRcaty3n9KeIRKj/llQjt PCUaJo5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 13 May 2017 14:40:08 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/mmc/core/sd.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c index d109634fbfce..1d7542daecbe 100644 --- a/drivers/mmc/core/sd.c +++ b/drivers/mmc/core/sd.c @@ -294,12 +294,8 @@ static int mmc_read_switch(struct mmc_card *card) err = -EIO; status = kmalloc(64, GFP_KERNEL); - if (!status) { - pr_err("%s: could not allocate a buffer for " - "switch capabilities.\n", - mmc_hostname(card->host)); + if (!status) return -ENOMEM; - } /* * Find out the card's support bits with a mode 0 operation. @@ -359,11 +355,8 @@ int mmc_sd_switch_hs(struct mmc_card *card) return 0; status = kmalloc(64, GFP_KERNEL); - if (!status) { - pr_err("%s: could not allocate a buffer for " - "switch capabilities.\n", mmc_hostname(card->host)); + if (!status) return -ENOMEM; - } err = mmc_sd_switch(card, 1, 0, 1, status); if (err) @@ -596,11 +589,8 @@ static int mmc_sd_init_uhs_card(struct mmc_card *card) return 0; status = kmalloc(64, GFP_KERNEL); - if (!status) { - pr_err("%s: could not allocate a buffer for " - "switch capabilities.\n", mmc_hostname(card->host)); + if (!status) return -ENOMEM; - } /* Set 4-bit bus width */ if ((card->host->caps & MMC_CAP_4_BIT_DATA) && -- 2.12.3