From: Edward Cree <ecree@solarflare.com>
To: Nadav Amit <namit@vmware.com>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [RFC PATCH v2 0/4] dynamic indirect call promotion
Date: Fri, 15 Feb 2019 17:21:17 +0000 [thread overview]
Message-ID: <b099e061-32fc-4111-7836-b7cdcee88455@solarflare.com> (raw)
In-Reply-To: <CDCF8F6E-1792-45B5-8850-88E3307D1FBD@vmware.com>
On 05/02/19 08:50, Nadav Amit wrote:
>> In cases where RCU cannot be used (e.g. because some callees need to RCU
>> synchronise), it might be possible to add a variant that uses
>> synchronize_rcu_tasks() when updating, but this series does not attempt this.
> I wonder why.
Mainly because I have yet to convince myself that it's the Right Thing.
Note also the following (from kernel/rcu/update.c):
/* * This is a very specialized primitive, intended only for a few uses in
* tracing and other situations requiring manipulation of function
* preambles and profiling hooks. The synchronize_rcu_tasks() function
* is not (yet) intended for heavy use from multiple CPUs. */
> This seems like an easy solution, and according to Josh, Steven
> Rostedt and the documentation appears to be valid.
Will it hurt performance, though, if we end up (say) having rcu-tasks-
based synchronisation for updates on every indirect call in the kernel?
(As would result from a plugin-based opt-out approach.)
> As I stated before, I think that the best solution is to use a GCC plugin,
> [...] Such a solution will not enable the calling code to be
> written in C and would require a plugin for each architecture.
I'm afraid I don't see why. If we use the static_calls infrastructure,
but then do a source-level transformation in the compiler plugin to turn
indirect calls into dynamic_calls, it should be possible to create an
opt-out system without any arch-specific code in the plugin (the arch-
specific stuff being all in the static_calls code).
Any reason that can't be done? (Note: I don't know much about GCC
internals, maybe there's something obvious that stops a plugin doing
things like that.)
> Feel free to try my code and give me feedback. I did not get a feedback on my
> last version. Is there a fundamental problem with my plugin? Did you try it
> and got bad results, or perhaps it did not build?
I didn't test your patches yet, because I was busy trying to get mine
working and ready to post (and also with unrelated work). But now that
that's done, next time I have cycles spare for indirect call stuff I
guess testing (and reviewing) your approach will be next on my list.
> Why do you prefer an approach
> which requires annotation of the callers, instead of something that is much
> more transparent?
I'm concerned about the overhead (in both time and memory) of running
learning on every indirect call site (including ones that aren't in a
hot-path, and ones which have such a wide variety of callees that
promotion really doesn't help) throughout the whole kernel. Also, an
annotating programmer knows the locking/rcu context and can thus tell
whether a given dynamic_call should use synchronise_rcu_tasks(),
synchronise_rcu(), or perhaps something else (if e.g. the call always
happens under a mutex, then the updater work could take that mutex).
The real answer, though, is that I don't so much prefer this approach,
as think that both should be tried "publicly" and evaluated by more
developers than just us three. There's a reason this series is
marked RFC ;-)
-Ed
next prev parent reply other threads:[~2019-02-15 17:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 0:05 Edward Cree
2019-02-02 0:07 ` [RFC PATCH v2 1/4] static_call: add indirect call promotion (dynamic_call) infrastructure Edward Cree
2019-02-02 0:07 ` [RFC PATCH v2 2/4] net: core: use a dynamic_call for pt_prev->func() in RX path Edward Cree
2019-02-02 0:07 ` [RFC PATCH v2 3/4] net: core: use a dynamic_call for dst_input Edward Cree
2019-02-02 0:08 ` [RFC PATCH v2 4/4] net: core: use a dynamic_call for pt_prev->list_func() in list RX path Edward Cree
2019-02-05 8:50 ` [RFC PATCH v2 0/4] dynamic indirect call promotion Nadav Amit
2019-02-15 17:21 ` Edward Cree [this message]
2019-02-18 16:22 ` Nadav Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b099e061-32fc-4111-7836-b7cdcee88455@solarflare.com \
--to=ecree@solarflare.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namit@vmware.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®