From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 991B84ADD9B for ; Tue, 14 Jul 2026 16:22:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784046176; cv=none; b=d+7i0q/vBOSmRAGsxuoHag3UEngoT5T0T+PGJCl3MwcwNQLneCkgqK+h/GgDdgt7tzI/zaoDOQXboSbruqOZU88zG/HDlXPDSOHZf6rkVXWyMpjs+hBMyJVn8skXQyY/po322GgvoaC9Cl9oA3mHyqNgYjvYkLSREH/3M6LE+AM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784046176; c=relaxed/simple; bh=orJEvHBeXvNZ7hZR15f/uGaIEoW0Eezb+ckb2meJw3k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ED8E6vLRqtisTo7xFfuceaVKlsc6JlHw4n6wHfF07xIiv4qhurTo7e9vE94Z4cK9p0AVFyAzKht4INwU0Cdpd5YHLrhyCKwzAaQXIQrjnuNbgqAAGOnJBzFfEOYzJUZaHlZhLdTs5dHwu/xWubsEIs1YUyPcAJFyElAbAnba8cE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Jus4AScL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=RvMfUGrI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Jus4AScL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="RvMfUGrI" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66EG6f701055358 for ; Tue, 14 Jul 2026 16:22:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= A4og9nh2/RMYqtFHRu4SpcNmhnMb8Uyr2PR8ftMNBpY=; b=Jus4AScL6EhMELjV YPz07fe3KE9LbkVmXYfP6DQpWJsRHWUV84rqLzMiYemEF2cXVI89YgpJUQeGagsz UrZNPiXUR0CKkwM0hIpn42kx4aTFHBPeJ2njIq0P/p0OPPyDdfTI1hHiIIr1Vq/Z 0jDc4DkaHr4tE4Ot1A66UoBHLdHjasklhRrrAgHCjIipdcQ0BkWLJPSwduQzDevY MGk44+hYikzjtBclcYNemvXMu1GeAo8WdbODgmXZmcXhS0oK28GyPFKHm5ou8cGV 06bQrxPKAHsFBIi9LFy+5DZ4nCYA6MVDcoiEr6WiH7SFQGnnS+HEVRnQSDKtryS8 Q/ADwA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fdeu4jn6j-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 14 Jul 2026 16:22:54 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-51e4ba1cfabso3539011cf.1 for ; Tue, 14 Jul 2026 09:22:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784046173; x=1784650973; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=A4og9nh2/RMYqtFHRu4SpcNmhnMb8Uyr2PR8ftMNBpY=; b=RvMfUGrIAQOynfgQ3gbq3XnMoBCtLm+gJ7OSPy9w9bEQARxT4bOUUnHoJOIPQymD9h EKfyH+hbV27twwY9OaNlBfZRQmUA/2Lm4oHwt0nkNenMKTILCTwfwFob3r6QymfR9U+X uk9kRA1VLCwc9wxLytPakqlcFL6nmNUIrPFBI8Dkti4s5GJE+mE0mXRcvhF/OiIbg/xF HeKsDzxNt4ZQ/Fxk3gnWJPOK3PT/kKnJbhDn7CzCAIeEvDadu2cbTDpS+IzGENdHN1e1 XX1+7tUZRpshpLGz3acaDojxo/xD3IUUdV2Nr5wJJgF57pUxmoQdDISibkwjkK3gVt4a OAxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784046173; x=1784650973; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A4og9nh2/RMYqtFHRu4SpcNmhnMb8Uyr2PR8ftMNBpY=; b=sCPhg1LX+Ht4fT4Ut/YCF7+0PTwvn018d4El1SkQ9/pHaBk2evN39qhkrbURhKxzNi ED8B/1pvLIfF+gI50d7l8u6hpE+iTRCBtTzJtwYxSYOmGMhx1WnnXtlfZfT5NkajA1AG U3eZdogDyhtbcMZM4Ni0y3pyHLsZ1cDMrwmhHEm58Nk9zFih08A+r4P3IcxCcm1QRjGh camOQpVdRQcYDLgT5F9gVdrQgQWgN24d8CcAkSuxrExTw7QgfCANZ0NjUWLxjyCVXlUq tHxG/SLTLJEV4xtSzXmdQ1MIlYQ/UjrteIECqvfxb2ozZz4L2JHR8IckujALS/fhjfBy FssQ== X-Forwarded-Encrypted: i=1; AHgh+RrhtCKISXwVImSprfLOeGkkyEhzCBjljVXKujPlV1kWJ7BRqI9QkFLl3KhF9qGl/jgGKN/opG2g1nQRgPY=@vger.kernel.org X-Gm-Message-State: AOJu0YwpWpcbi6Ij/exz423BiIrUJbn+pFSLniulDxV5eS9AN5fwnmuV g57SvvJMuKqdRLus6Nc0x4XpWVPapzwe3nsgWIYW8NrOQYV6djR4zj4bUEmkZqXV21g8LaUfQtN UrKxMC+JDmZ+Aj4C3NgdnFKo3eYsVY3J71qn2vS2VSlJmLuGyLVcuYKEL9Vp2pm21erk= X-Gm-Gg: AfdE7cm0C8RpyrWEAoN7OqjtX8ogD1kz66fp4pxoQerqNbjwqoL4Gks7cDVaD/+WW4N h2HoGvqGEPXa76+Bwx4ElB0AI3+3EoKb+uCGSlM7YiF2WeNsdR11k6WA/iSaCfVUXc8x9ezanaO y6lZSut2fDKTpIlyfm6+8MU9R79OKsS0h4UwhSHVHgp5rGoAF6tfHRdkNmX3TXiMk1PfBzdlkfT 1mWggw8SRM85j7ccRXm4Q356g2jmN4/Cg/GINSJB+uYIVyfsZ52BAAmyXNvcxNfuquoJlQi3idI g3Vz4Z9sj7uSQj3+Wa0NVtWA9VTGg8hmYXHlC0UlaqIDWhfYlTlXqeZTRW2rB81AphFs8LeTcVF K08407vZk49wpPVrnbHPAmF2qkFAKp+lt4ydPag== X-Received: by 2002:a05:622a:4d97:b0:516:d781:589a with SMTP id d75a77b69052e-51cbf0c467fmr136395801cf.22.1784046173467; Tue, 14 Jul 2026 09:22:53 -0700 (PDT) X-Received: by 2002:a05:622a:4d97:b0:516:d781:589a with SMTP id d75a77b69052e-51cbf0c467fmr136395341cf.22.1784046172973; Tue, 14 Jul 2026 09:22:52 -0700 (PDT) Received: from [192.168.68.109] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-4950a32b9f3sm98136555e9.13.2026.07.14.09.22.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jul 2026 09:22:52 -0700 (PDT) Message-ID: Date: Tue, 14 Jul 2026 17:22:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH] ASoC: qcom: q6apm-lpass-dais: start the graph at prepare To: Jorijn van der Graaf , Srinivas Kandagatla , Mark Brown , Mohammad Rafi Shaik Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Val Packett , Luca Weiss , Dmitry Baryshkov , Jianfeng Liu , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260705033830.305907-1-jorijnvdgraaf@catcrafts.net> <20260708215539.150590-1-jorijnvdgraaf@catcrafts.net> <137a9c85-67ab-434b-880b-d9d4efa5bccf@kernel.org> <20260710143214.142017-1-jorijnvdgraaf@catcrafts.net> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20260710143214.142017-1-jorijnvdgraaf@catcrafts.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: cBS97k_ILpKg0bT2jBTlO0uGJTnYEs6o X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE0MDE2OSBTYWx0ZWRfX3UXrEjl9seV0 1jKCsRRkVlhAc/78G01vDqmmUa6nozja2X79pxPVMZB1bMzb5BEkuWA/12xInrbY6j0EgupETBq orZ0FduASintIkw+sPbowE6r5kfK4WNi4TIGpCyZHKNbbhN1tR9ES63xBEKLMnTzqRLgfr4W9kc uMTmvu72izWVLVwVNMNpjlnvaKeF7pZs8JZn45BpZ0HXOHy+7DKRzM/pTN0dbG+kA/NmMMMQmNk LHgOQVHRQOJtQu+PpwlhGZYGIG5/Om2HWZEE2fyjsLzb0bc7aOST4FQUCdCh0jVPb7/T9h4hTR6 N5yFIunLKp/lRgdTJ/naOwJWauekCVtLt2fuuiXxIbM15gYb5dVviN2CHpC+/s2ys2Uvuu7wKb3 Z5YVwgQFrJJD5DIQ4PAA6ufNxiwhHvJyxH1w1yQkmiRxZijwgWzKMJ/vNL9eu4RLwhqbarYFYFT yPuls30n/gUJt2iTOpw== X-Proofpoint-GUID: cBS97k_ILpKg0bT2jBTlO0uGJTnYEs6o X-Authority-Analysis: v=2.4 cv=cN3QdFeN c=1 sm=1 tr=0 ts=6a56625e cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=dKMprGr_ybx22OnWk7YA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE0MDE2OSBTYWx0ZWRfX8Irl6BIdZnQX 5/ESjt7JFoR84H3F8goSLuoUDiuaOdP8wOpZH7Ryo3juxT5PfV5I4/U9u3bFGhRqxp5P+TBMvhd ehJAObe7Js4snfKISYztXhWEXcNdE2o= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-14_04,2026-07-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 malwarescore=0 suspectscore=0 phishscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607140169 On 7/10/26 3:32 PM, Jorijn van der Graaf wrote: > On Wed, Jul 08, 2026 at 11:13:18PM +0100, Srinivas Kandagatla wrote: >> I guess you are referring to the IBIT clk that dsp provides, not the mclk. >> >> Could you not enable this from the machine driver? > > Yes - SEN_MI2S_IBIT, provided by the DSP, not the mclk. And enabling > it from the machine driver is what I tested with the series you > point at below: > > On Wed, Jul 08, 2026 at 11:18:50PM +0100, Srinivas Kandagatla wrote: >>> So for v2 I would keep the two behaviours apart per interface type: >> This is not going to scale, please try to enable the required clocks >> from machine driver. Pl take a look at this series >> >> https://lore.kernel.org/linux-sound/20260706132009.1496321-1-mohammad.rafi.shaik@oss.qualcomm.com/ > > I tested that series (v3) before sending my previous mail - > the report was buried in a long mail though, so here is the setup > and result again in a bit more detail. I carried the series onto > the tree my board runs, described SEN_MI2S_IBIT as the "bclk" of a > dai@147 subnode per the new binding, and set mi2s_bclk_enable in > the board data, so the machine driver votes the clock at hw_params. > The vote itself succeeds - the DSP acks it and clk_summary shows > the clock prepared and enabled at 1536000 during the stream - but > the amplifiers' synchronous power-up check at prepare still reports > "no clocks", and with the graph started at prepare the same codec > powers up with no bit-clock vote at all. So on this board the bit > clock only reaches the codec once the graph is started; the PRM > vote alone does not drive it. > > The question that decides where the fix belongs: is the DSP expected > to drive IBIT on the pads from the PRM clock request alone, with the > endpoint's graph not (yet) started? > IBIT clocks should start clocking once we vote for it using prm. Do you see any errors while enabling this clock? This week, I will try to pull some wires out and check that on my hardware too. --srini > - If yes, milos firmware behaves differently here and I am happy to > debug - any pointer on what to check would help. > - If no, the machine-driver clock route cannot cover a codec that > needs the bit clock during the DAPM power-up sequence, on any > AudioReach platform, and some form of start-before-power-up is > still needed for such links.