From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70A8F1D90DF for ; Mon, 29 Dec 2025 00:56:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766969802; cv=none; b=TUv/fWFOnQeri26N+NWMvjv89d1NzDubj9zFpn0ZeJ7WckJ7ljP8YF8kOxXJUeP/jQjzKF6Kv7upmG5Dqs5uJcOdpi4p4303XyyetdRBBWpadyEKJlD9/xWmHuTcWwVsHA1Khs7Q8WaPBIY+tlT/a/oYllxHJFoYrfXxS+nArBo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766969802; c=relaxed/simple; bh=v9oOvjyAlBRUlSFD3Ik/hUyGuidHyTn+MG0ZyLe29Xs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NnriSEt3+CE5D//nNaZpgR+ndyaNBRof1AtOTMF+bTekMhEnZ4MRgf/aLqa7qOvbdPOTuXNyA/u/DJFZzHJkO0lWwWjY6PEykvr5+DLB0n+Pc/7lee7PD3mFtRGUqL//+GWEl6/apCSrEwoZwgszaGLCEYwS+6M+qcE946O4ioo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b=Q0Znj9Xy; arc=none smtp.client-ip=209.85.222.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20230601.gappssmtp.com header.i=@riscstar-com.20230601.gappssmtp.com header.b="Q0Znj9Xy" Received: by mail-qk1-f182.google.com with SMTP id af79cd13be357-8ba0d6c68a8so972591485a.1 for ; Sun, 28 Dec 2025 16:56:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20230601.gappssmtp.com; s=20230601; t=1766969799; x=1767574599; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=p5YcKwFkMbcJ8/aWNC56rcK6ZT2Jj+wm+CfNyGhVwCA=; b=Q0Znj9XyJ3ZBju/LXpDKZ14ZG1ef6vsb0lIqx2jQKMLAU0IuOiP61wvwryBsyewZHp fWH/D9PrlsDA72toxP0ibQmgOd3PnN4BNgrR+l0V95a6FxAr7vY0MgveZXj74Nt0aUZ7 XlmYwXs9j7NwVBsdWCk7xjGFBITcoJke00bn8Gy0gJHyGPfoEj67JuvSUdeqCTUcJy73 w4SgLoIKlQUcvEZu+z0svZk8BV334z0z+tdaAGLSk5EajWwhiBqSQU2F54gbexXDPo0V ki6tX+wQP4Tp+Y1IOq+8FcNrbzhp4TsdIvJaw1P18RddhL5AN/C2vXOjuPgkhSRH6u2H G4yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766969799; x=1767574599; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p5YcKwFkMbcJ8/aWNC56rcK6ZT2Jj+wm+CfNyGhVwCA=; b=NJsum4NjHk8dlh8IZwXQqcMNxrzUec36Yl47wBKuJNAeGfxEfPwXtjZUM0IRPFTq5F G7D1wioBbmEMOPYDDf+X+QiYyibM8RvU85XdZZDgnEDOp7TuvFq3k7lPsvMbLX9gYRpZ Z/QKxW34Xz5eR573JMpk4dNWTvQMqRUoBtlqaj6A5RT6Fw5S0z4yLdXqjFixisQYozqh G3hJnOhwf28kfnM1cG1H1YTZbeNYxRJlpn4U5hcJ9QR27Rscz8xSyvXMcxY/OFSGNrW3 aSS/aIz7vAYCxFL3t4gzNqbAeYdX9tyYF4la8ehee6/ta6ivsmlIjKq/w/3RpvQkEkoQ n6GQ== X-Forwarded-Encrypted: i=1; AJvYcCVAJFlkCgCgZ3Aw1nUGvx2vbDnxKtz1MP1NQGBQTbjzzIv797MNkTVeBceBtBwRUil1y3Uat8cWnySM+NM=@vger.kernel.org X-Gm-Message-State: AOJu0Yyo2yYsz/O6ghcbFy2Hex/DF+ZMN+t3+5CvGhno/clXSWN21ygW lR1qYIJKRpD157ro4YTkwfDXXm8D5uNx2TJwROlvdW8TtjLL16dNGKsawpNvTPRUjaU= X-Gm-Gg: AY/fxX7tqH3wfkgA0/eqk9ZSNSjBlqhJoRgGx4DyKANQSrqMN/aAc3nPHWTb+Am90yK lSZ3z7T1tGozf/SDrdFyG64prH5FRiZ3Cw+cYFo5wHsPVh2ryowdlCUrNTCKb5r7tdwpm27gpbz bGkRJDUfHNA+XQ8cWBPAp7KYhJDvJK0aMT6NQRGf635mXaP9QzhJozjZ5hP/BiqQmhMrQJ6TxrV F/rvpHV5TA945BYdu8+Luu/TTJgbdadqMddnukOFkuucHUJf2BcYnQwhkWaMxR53K2YFLeAcd5q 7Ox2djnLfYaNFt31e++9C+mw+VIvDzi+xNGlHxVAwRRQZ7R9jpX8DIsc92WBkksB+TjWmNE6jID 16+EBnXgk0n8vFgLfZ4TvM9ZjfMS3EZXUDkjPViCZlGKW1jccVEr6W/3DYpAW2tASQNhc/DAfNr E42Tbyl2mgLi5iDVf9YV6doi75XjHYHighXOo07JYo+ffviR7qNVo= X-Google-Smtp-Source: AGHT+IEX3O6y7wxbcIj6mJ9uEHV/yCicWvg4d6PHddWSgifd55NeGPWTFcT2cuAr4CpJraSKfFGlGA== X-Received: by 2002:a05:620a:4489:b0:8b2:f1f3:900e with SMTP id af79cd13be357-8c08fac0b38mr4258385485a.62.1766969799303; Sun, 28 Dec 2025 16:56:39 -0800 (PST) Received: from [172.22.22.28] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8c0973f08fcsm2275235285a.40.2025.12.28.16.56.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Dec 2025 16:56:38 -0800 (PST) Message-ID: Date: Sun, 28 Dec 2025 18:56:38 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/3] i2c: spacemit: drop warning when clock-frequency property is absent To: Troy Mitchell , Andi Shyti , Yixun Lan Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev References: <20251226-k1-i2c-ilcr-v5-0-b5807b7dd0e6@linux.spacemit.com> <20251226-k1-i2c-ilcr-v5-3-b5807b7dd0e6@linux.spacemit.com> Content-Language: en-US From: Alex Elder In-Reply-To: <20251226-k1-i2c-ilcr-v5-3-b5807b7dd0e6@linux.spacemit.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/26/25 2:32 AM, Troy Mitchell wrote: > The clock-frequency property is optional according to the DT binding. > Do not emit a warning when the property is missing and fall back to the > default frequency instead. > > Fixes: 5ea558473fa31 ("i2c: spacemit: add support for SpacemiT K1 SoC") > Suggested-by: Alex Elder > Signed-off-by: Troy Mitchell Any error reading the "clock-frequency" property will simply leave i2c->clock_freq alone. This is good. But the lines that follow this issue a warning if i2c->clock_freq is 0. If it's optional, you should simply use a default value, and although you could state that rate with dev_info(), you should not warn about it. -Alex > --- > drivers/i2c/busses/i2c-k1.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c > index f0c35e23f4f2e139da0d09f314f3eb0e0462a382..c829618a66a214a12b46d63bf06ba7947b9dbbb8 100644 > --- a/drivers/i2c/busses/i2c-k1.c > +++ b/drivers/i2c/busses/i2c-k1.c > @@ -651,9 +651,7 @@ static int spacemit_i2c_probe(struct platform_device *pdev) > if (!i2c) > return -ENOMEM; > > - ret = of_property_read_u32(of_node, "clock-frequency", &i2c->clock_freq); > - if (ret && ret != -EINVAL) > - dev_warn(dev, "failed to read clock-frequency property: %d\n", ret); > + of_property_read_u32(of_node, "clock-frequency", &i2c->clock_freq); > > /* For now, this driver doesn't support high-speed. */ > if (i2c->clock_freq > SPACEMIT_I2C_MAX_STANDARD_MODE_FREQ && >