From: Juergen Gross <jgross@suse.com>
To: Lai Jiangshan <jiangshanlai+lkml@gmail.com>,
"Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Andi Kleen <ak@linux.intel.com>,
Dave Hansen <dave.hansen@intel.com>,
Peter Zijlstra <peterz@infradead.org>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Deep Shah <sdeep@vmware.com>,
"VMware, Inc." <pv-drivers@vmware.com>
Subject: Re: [PATCH] x86/paravirt: Fix build PARAVIRT_XXL=y without XEN_PV
Date: Mon, 22 Nov 2021 13:55:26 +0100 [thread overview]
Message-ID: <b09f3263-61a4-4b3e-948e-068e5806ffa1@suse.com> (raw)
In-Reply-To: <CAJhGHyA0TB-OE0guLFzbyOTcOjLZ8EDJRXasHoWy7OvopK0xkg@mail.gmail.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 811 bytes --]
On 20.11.21 02:23, Lai Jiangshan wrote:
> On Fri, Nov 19, 2021 at 6:20 PM Kirill A. Shutemov <kirill@shutemov.name> wrote:
>
>>> It is part of what CONFIG_PARAVIRT_XXL was designed for to enable
>>> pv-aware INTERRUPT_RETURN.
>>
>> That's very vague statement.
>>
>> Could you elaborate on what is wrong with proposed fix?
>>
>
> Although CONFIG_PARAVIRT_XXL is enabled only when XEN, but they are
> separated configs. There is no wrong with the patch, but it is not
> justified to narrow the scope of INTERRUPT_RETURN.
xen_iret is defined only with CONFIG_XEN_PV, so using that in
INTERRUPT_RETURN only in case CONFIG_XEN_PV is defined is absolutely
the right thing to do.
In case another user of INTERRUPT_RETURN would come up, it would
need to be changed again anyway.
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
prev parent reply other threads:[~2021-11-22 12:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-17 18:14 Kirill A. Shutemov
2021-11-17 18:35 ` Peter Zijlstra
2021-11-17 18:42 ` Kirill A. Shutemov
2021-11-17 18:46 ` Sathyanarayanan Kuppuswamy
2021-11-17 18:48 ` Borislav Petkov
2021-11-17 19:11 ` Dave Hansen
2021-11-17 19:13 ` Sathyanarayanan Kuppuswamy
2021-11-17 19:57 ` Dave Hansen
2021-11-17 20:54 ` Sathyanarayanan Kuppuswamy
2021-11-17 21:09 ` Borislav Petkov
2021-11-17 23:04 ` Sathyanarayanan Kuppuswamy
2021-11-17 23:23 ` Peter Zijlstra
2021-11-17 23:57 ` Sathyanarayanan Kuppuswamy
2021-11-17 23:33 ` Dave Hansen
2021-11-18 1:26 ` Sathyanarayanan Kuppuswamy
2021-11-18 9:13 ` Borislav Petkov
2021-11-17 19:02 ` Peter Zijlstra
2021-11-18 6:23 ` Juergen Gross
2021-11-19 10:21 ` Kirill A. Shutemov
2021-11-19 7:51 ` Lai Jiangshan
2021-11-19 10:20 ` Kirill A. Shutemov
2021-11-19 10:27 ` Juergen Gross
2021-11-20 1:23 ` Lai Jiangshan
2021-11-22 12:55 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b09f3263-61a4-4b3e-948e-068e5806ffa1@suse.com \
--to=jgross@suse.com \
--cc=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=jiangshanlai+lkml@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pv-drivers@vmware.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=sdeep@vmware.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®