From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7051532C8B for ; Thu, 24 Sep 2026 09:32:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790242360; cv=none; b=ptcausjoMSWrcbm2sMC3lcRpGgLqXfAqnzKTt6E2E3n7e8HCC/pz3Q4dG6QmTquwdD4c3V6ma+lhWTBkZdrPQlqgp00fsBSVDLBC0evMyht1BTjmaBu5ebuS1GaMf6DFBxvMgmsZECZCKO5JowJlBPySCQOHGNRNJiRuQDe3/+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790242360; c=relaxed/simple; bh=rwxv8tLdSgWEik0hiYWE6kOHX12q7aE4xGYPQuj35g8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=L8CAU/gTUtIUQ9nex7WwrrX/ORQDdl9LYMPDwXyvm0xaFFi/b3/WwGig/EsmLpQHARC7fvAeK4mS33Wg6l+zZ9fUA61FY9ZIVrgsoHM9pnKFnEbbdYx+iZzkqjNmfFZ1qwwdEK/lw9Xwe7OXgCKjF2y3KQ7nSb91qRj5pNTiGxg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dfjCoWHC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VHyqEEzZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dfjCoWHC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VHyqEEzZ" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68O9PnEn1080193 for ; Thu, 24 Sep 2026 09:32:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= D044GLB66qpCbxwLa31iTBfwL9c0q5C1qDPuwruympk=; b=dfjCoWHCxVPZ8bcS vtMjfKASYygu+TGxtrUydJ3JY/FmhufyuSHXI5rbSYJrE7Gr6fAs1mFVsKAgrzlN 6ADJNfQ+T9Lsnau9TDj1O4cBZclAa9KWURGyjWWj+2SfXGDZRTh21nRtZhu6HxA2 tJrMcw+Aw9EtmSZagqArXZyJ1zmBIZ+w+k7KPIy4sF98Ta/rmZyXYuIWWyPWCfEl h8TpPK/Ez9fggx7BLPRjOFva8UHNwoPC1g1+5OXkD2A9j42xjzygodqS672FiZuY lp9MqlYtA8mtFws9pyVWvPvA/u1wvUVY8GjL4nsoW6Boid2kR2dIMIrWX5YVr1QU AcfiEw== Received: from mail-dy1-f197.google.com (mail-dy1-f197.google.com [74.125.82.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gvfmwmbhm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 24 Sep 2026 09:32:37 +0000 (GMT) Received: by mail-dy1-f197.google.com with SMTP id 5a478bee46e88-33713e5e6daso2480243eec.0 for ; Thu, 24 Sep 2026 02:32:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790242356; x=1790847156; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=D044GLB66qpCbxwLa31iTBfwL9c0q5C1qDPuwruympk=; b=VHyqEEzZvPOe/q7pvji36Oe+83aFyA6rh1x5C4fOU7vIW7E/gg30PsD6M2aONcHVhL gmdVyb0VC8DDJOHaCpEBvpAQzg7iTT51FjHj9j89+Uh5MUPXX/bQ3g9nDRGKctwoGchm uFDS9IPD4gCEq+sFaY/3h0I0DlJeV4NkfJyPwzuViPgmhmYfGAHMlbWxLAVOqlZ8TszA ZRvJMDqCrnfl5nN/bXluL6iEQW+EvUi9XtGwjRvyAHRED2MNfx4lUUMmh4O8hvCwScZ6 K7VnfrGHQHjZfhj7CPHMrVEqGwNBAbd+kob6GYz0hjlUAmXWWYBXdgsq1yqyZ2S8rFf0 WpwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790242356; x=1790847156; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=D044GLB66qpCbxwLa31iTBfwL9c0q5C1qDPuwruympk=; b=Lx/W51deIXALWMIeVQoCXmFtZz1J0zglHPNjRnPuN66MI7m3tzNSnwv4CjB6DUHqaL Yyxan6+K14sS65ENJmHvojqJ9bD0co1fKcda/qFvPDL7//UcVQccQTDPY1CvBQ6vNuEZ W6A5RjwJ7oULyJ3yCHCwX4HoeBIFUe6czxxCNyEJf0wzygiCGXAZe2lG0nMTGCrHnN9b 6mx6X6Jaig/XDjjOxUK8f67bQQBstpVKhxheYc1GgzGOlsSs09CUl4Ra/Mbfk32cBdFt I0+Hbaq+6f+089Cn0IVtiRc9aS9YhAnJyuT3OaoPu/kmrkqIYHTTOhDKn85iw1On6Hic M1Zg== X-Forwarded-Encrypted: i=1; AKwUvByqQdF+uuSq/QlbkJKSOqU+MpIsKaMlKnJoINy+BeviYsrRLKnFbzqX5e9bA0COWnuRH9tvb9z7T+tN5II=@vger.kernel.org X-Gm-Message-State: AFuF++mJsKYka4xdu6YoACyGVh8nmH0iVDHp2KtVS04xBC1dcFKsdGSi gK9Ws+rXtZZRGUwKtjsLLaQuXIbWGv22Au6vkWQeEy3mfz6rKND1vmSkicobrUT2d0I1Dn64QhD XxsRqVuH4jT0C2Nd2iriVoAbFrl9wKpaTu80/X4aSGzfN6l5fcDiuafic/Yv3DQjSO5A= X-Gm-Gg: AYBFou0tFyyRBSfCGD5Vp/faieAT4d1InNo7ye5d23oJe/aPzSP9saKB+0NBkDebcKg xJyhxKQ/GtD8gb1bQcJaY+87Io2mkNAotAjgy1gdOcNt1UVBJGhu3oxnbe/VbBk4MH5I13o9C2l ONoRXJkMl6ml6d0cLe127ssUbkGzaPFWClFDzIftXEcD35WC7pk+IVgWXRwspe63Rr0HnyzGP7x oz31BkJVgCengzDAmlHz4lHxCvcIJOPZZXZI/ENLnQmkLHxa3kW1P2ODdH/F/Nh7YTYG+9nb1Gn OZaKb1ahTAkbfuNmr3etiL+xSio9XYKeHptDqBrOVDSndI40JUwNfmub2vOMyCkRAPTaPtheG37 q0ePmXY9jZUqN8DbU1cGjNIy1ajX0 X-Received: by 2002:a05:7301:5511:b0:33c:e63:f2fc with SMTP id 5a478bee46e88-34000449db5mr1625524eec.23.1790242355947; Thu, 24 Sep 2026 02:32:35 -0700 (PDT) X-Received: by 2002:a05:7301:5511:b0:33c:e63:f2fc with SMTP id 5a478bee46e88-34000449db5mr1625502eec.23.1790242355277; Thu, 24 Sep 2026 02:32:35 -0700 (PDT) Received: from [10.217.216.70] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-33e939fdabcsm13400388eec.3.2026.09.24.02.32.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Sep 2026 02:32:34 -0700 (PDT) Message-ID: Date: Thu, 24 Sep 2026 15:02:18 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] clk: qcom: smd-rpm: Skip proxy votes on clocks for QCM2290 To: Konrad Dybcio , Bjorn Andersson , Stephen Boyd , Brian Masney , Jerome Brunet , Rob Herring , Georgi Djakov Cc: Ajit Pandey , Taniya Das , Jagadeesh Kona , Stephen Boyd , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260910-clk-smd-rpm-skip-proxy-v1-1-1cb5694a99d9@oss.qualcomm.com> Content-Language: en-US From: Imran Shaik In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI0MDAzOSBTYWx0ZWRfX9r2zeVF+J0i5 FPU85qnqWXsEGDSZjjljgQUkY+GkqIyEF0vgkF7GisLSjGLyMMKSmFWmfnv2X+iZvciTifwINz8 6N3WDgXSTB00mbiLj5V0mZdosGRObzpFDHDDeL364B++xQ8rW4hcK+wQvZtcVsgJVYF8xCfgSog CnuYyV64t0QDcc6weKAVCG7/XXVu8XqxSbEDiE259teYQ3vynBCJxqN+Fyic7lNzBeRlvTVe6oy i9z1Hm4qBF5nZ6ZgdyDDnD9HnsgHoKnP85f8qCUuVQi5B8BceYnf+feIebq1wN3jsfwxWjV5PaW DCw/xsm2QLUu9+LXp13S0OhDLi4l0yejKDUMIn0psgeMM2azV5JNGQcQs23diMQte3BNy2wy6br jh6sdg260jCflq/bqDqQAizuGPhb7LsnGioNNXrX27ubCNkNeqHF/83Ze723fCl3dce2SWLeVpF SVczE9oWyDjbeE8XMPA== X-Authority-Analysis: v=2.4 cv=WK/qzXsR c=1 sm=1 tr=0 ts=6ab4ee35 cx=c_pps a=Uww141gWH0fZj/3QKPojxA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=mssyiQsI3MLSchi5Q0YA:9 a=QEXdDO2ut3YA:10 a=PxkB5W3o20Ba91AHUih5:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI0MDAzOSBTYWx0ZWRfXyBMuQzV7FEca ilIaTZo6wQqR9xu9kARJxFLg76WmpZWmi4mjJMZ1M2MSjBlBlCHWdAWCD6IJQcYmEkiQ1TF4oMH 7tj/0nFzikHzpvvq7riLDu3MzMHqZ38= X-Proofpoint-ORIG-GUID: xn11GBKGEgJUTNUZhwfQRF4_XHVGM5am X-Proofpoint-GUID: xn11GBKGEgJUTNUZhwfQRF4_XHVGM5am X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-24_02,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 bulkscore=0 suspectscore=0 adultscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609240039 On 21-09-2026 02:23 pm, Konrad Dybcio wrote: > On 9/16/26 1:05 PM, Imran Shaik wrote: >> >> >> On 11-09-2026 02:36 pm, Konrad Dybcio wrote: >>> On 9/10/26 3:44 PM, Imran Shaik wrote: >>>> clk_smd_rpm_handoff() votes both active and sleep RPM resource states for >>>> every clock, keeping them non-zero until a consumer takes over. If there >>>> is no consumer, those clocks will remain active in the idle scenario as >>>> well, and the sleep vote is never cleared, blocking XO shutdown. >>>> >>>> Introduce the skip_clks_handoff flag to handle this on QCM2290 clocks, >>>> keeping other targets unaffected. >>>> >>>> Fixes: 00f64b58874e ("clk: qcom: Add support for SMD-RPM Clocks") >>>> Signed-off-by: Imran Shaik >>>> --- >>> >>> Are you booting with clk_ignore_unused? >>> >> >> No Konrad, clk_ignore_unused is not present. >> >> Irrespective of clk_ignore_unused, the proxy votes are placed to RPM >> during handoff. If no consumer takes over, those votes remain active, >> keeping the resource ON in idle and preventing XO shutdown. > > I re-read this and yeah you're right > > Is the handoff functionality necessary at all for non-icc clocks? Actually, if any consumers surviving on these proxy votes on other targets as of today, removing the handoff logic could impact boot-up as well. Hence, introduced the skip_clk_handoff flag to maintain backward compatibility on other targets. Thanks, Imran > I'm suspecting that this was just a port of the ancient msm-3.10 > logic where the (modified) clock framework had a handoff mechanism > similar to today's sync_state, except the toning-down of these > clocks was never added > > Konrad