From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C94EC47080 for ; Tue, 1 Jun 2021 06:16:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 466146124B for ; Tue, 1 Jun 2021 06:16:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232894AbhFAGSY (ORCPT ); Tue, 1 Jun 2021 02:18:24 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3484 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbhFAGSX (ORCPT ); Tue, 1 Jun 2021 02:18:23 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FvMLF3YnPzYqWr; Tue, 1 Jun 2021 14:13:57 +0800 (CST) Received: from dggpemm500012.china.huawei.com (7.185.36.89) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 1 Jun 2021 14:16:41 +0800 Received: from [10.174.176.189] (10.174.176.189) by dggpemm500012.china.huawei.com (7.185.36.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 1 Jun 2021 14:16:40 +0800 From: Qiheng Lin Subject: Re: [PATCH -next] x86/kprobes: functions should not be declared extern To: Borislav Petkov CC: , , , , References: <20210531031009.21737-1-linqiheng@huawei.com> Message-ID: Date: Tue, 1 Jun 2021 14:16:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.189] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500012.china.huawei.com (7.185.36.89) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2021/5/31 18:39, Borislav Petkov 写道: >> Subject: Re: [PATCH -next] x86/kprobes: functions should not be declared extern > > The condensed patch description in the subject line should start with a > uppercase letter and should be written in imperative tone. > > Also, the subject is wrong. Hint: "declaration" vs "definition". > > On Mon, May 31, 2021 at 11:10:09AM +0800, Qiheng Lin wrote: >> The function declaration in kprobes.h is already marked extern, thus its >> definition should not have the keyword. >> >> This quiets the following sparse warning: >> function 'arch_unoptimize_kprobes' with external linkage has definition > > This sounds like you're fixing something just because some tool > complains and not because there's a real problem you're fixing. > > Please rewrite your commit messages to state what the problem is and > why you're fixing that problem. The tool output can be used to say > something along the lines of "this problem was caught by this tool" but > not as "see, tool X complains and creates a warning and I must fix that > warning immediately." Thank you for the review. I will send the v2.