From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C45A8C4167B for ; Sun, 10 Dec 2023 08:42:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231642AbjLJImW (ORCPT ); Sun, 10 Dec 2023 03:42:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjLJImU (ORCPT ); Sun, 10 Dec 2023 03:42:20 -0500 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1D4CF1; Sun, 10 Dec 2023 00:42:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1702197744; bh=eVqRha9S4eH+hUMl2/N8MqL1Jl7s7jOhXFhWXN+Pd/8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=gIjN6GglyVLxfCebB2ngOFN8TJsye6gJPvPTpKfKSBf2ps1iVnPjyPCHfJUklJneX LVvk7/riklO2DBq51YULf4g41rxD32RLrc5Z17UY1kRqavsIKSxA4YTtENZgKOvtSH L5ZyDmpJVzvq5urmBTRyS1955ekjPh9+o3vVswqx4lzHSxhBRNKd7kp+o+XeoRKQyo fXatyrKjJS8oTuQvprdHFFhbOvQldUIyQcPrElWPmTtRDUypQhH5paElT4YIjcNvL/ s/y6gEDGJBp6dHsHmKIF3U+dgFJLQsxdOSXL4ba66ETsR/sU0+wxQvvkaHTiJJV+WF Fxfbc03Q7tPbg== Received: from [100.115.223.179] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: cristicc) by madrid.collaboradmins.com (Postfix) with ESMTPSA id B6D25378003D; Sun, 10 Dec 2023 08:42:22 +0000 (UTC) Message-ID: Date: Sun, 10 Dec 2023 10:42:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/11] ASoC: SOF: amd: Optimize quirk for Valve Galileo To: Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Pierre-Louis Bossart , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Daniel Baluta , Kai Vehmanen , Alper Nebi Yasak , Syed Saba Kareem , Kuninori Morimoto , Marian Postevca , Vijendar Mukunda , V sujith kumar Reddy , Mastan Katragadda , Ajit Kumar Pandey Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org, kernel@collabora.com References: <20231209205351.880797-1-cristian.ciocaltea@collabora.com> <20231209205351.880797-7-cristian.ciocaltea@collabora.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/10/23 05:33, Venkata Prasad Potturu wrote: > > On 12/10/23 02:23, Cristian Ciocaltea wrote: >> Valve's Steam Deck OLED is uniquely identified by vendor and product >> name (Galileo) DMI fields. >> >> Simplify the quirk by removing the unnecessary match on product family. >> >> Additionally, fix the related comment as it points to the old product >> variant. >> >> Signed-off-by: Cristian Ciocaltea >> --- >>   sound/soc/sof/amd/acp.c | 3 +-- >>   1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/sound/soc/sof/amd/acp.c b/sound/soc/sof/amd/acp.c >> index c6f637f29847..1e9840ae8938 100644 >> --- a/sound/soc/sof/amd/acp.c >> +++ b/sound/soc/sof/amd/acp.c >> @@ -28,11 +28,10 @@ MODULE_PARM_DESC(enable_fw_debug, "Enable Firmware >> debug"); >>     const struct dmi_system_id acp_sof_quirk_table[] = { >>       { >> -        /* Valve Jupiter device */ >> +        /* Steam Deck OLED device */ > If any changes in SOF drivers, first need to create a PR in SOF github. This is just an optimization for the driver, no need to change anything on the firmware side. The product family remains as is, but it's not really required to match the board, i.e. the previous board was "Jupiter", the next one will have a different product name. >>           .matches = { >>               DMI_MATCH(DMI_SYS_VENDOR, "Valve"), >>               DMI_MATCH(DMI_PRODUCT_NAME, "Galileo"), >> -            DMI_MATCH(DMI_PRODUCT_FAMILY, "Sephiroth"), >>           }, >>           .driver_data = (void *)SECURED_FIRMWARE, >>       },