From: Shahar Havivi <shaharh@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Remove unused variables
Date: Wed, 27 Jan 2010 10:49:11 +0200 [thread overview]
Message-ID: <b0ae6fcc1001270049m6e2e7b1dre9971e57e282b48a@mail.gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1001262342240.30977@pobox.suse.cz>
Remove unused fields in drivers/char/vt.c
variables orig_buf and orig_count are assigned but never used.
Signed-off-by: Shahar Havivi <shaharh@gmail.com>
---
drivers/char/vt.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/char/vt.c b/drivers/char/vt.c
index 50faa1f..94f530a 100644
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
@@ -2119,8 +2119,6 @@ static int do_con_write(struct tty_struct *tty,
const unsigned char *buf, int co
uint8_t inverse;
uint8_t width;
u16 himask, charmask;
- const unsigned char *orig_buf = NULL;
- int orig_count;
if (in_interrupt())
return count;
@@ -2142,8 +2140,6 @@ static int do_con_write(struct tty_struct *tty,
const unsigned char *buf, int co
release_console_sem();
return 0;
}
- orig_buf = buf;
- orig_count = count;
himask = vc->vc_hi_font_mask;
charmask = himask ? 0x1ff : 0xff;
--
1.6.3.3
On Wed, Jan 27, 2010 at 12:43 AM, Jiri Kosina <jkosina@suse.cz> wrote:
> On Wed, 20 Jan 2010, Shahar Havivi wrote:
>
>> Remove unused fields in drivers/char/vt.c
>> variables orig_buf and orig_count are assigned but never used.
>> Shahar Havivi
>
> Could you please resend with your Signed-off-by line, as described in
> Documentation/SubmittingPatches, so that I could apply the patch?
>
>> ---
>> drivers/char/vt.c | 4 ----
>> 1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/char/vt.c b/drivers/char/vt.c
>> index 50faa1f..94f530a 100644
>> --- a/drivers/char/vt.c
>> +++ b/drivers/char/vt.c
>> @@ -2119,8 +2119,6 @@ static int do_con_write(struct tty_struct *tty,
>> const unsigned char *buf, int co
>> uint8_t inverse;
>> uint8_t width;
>> u16 himask, charmask;
>> - const unsigned char *orig_buf = NULL;
>> - int orig_count;
>>
>> if (in_interrupt())
>> return count;
>> @@ -2142,8 +2140,6 @@ static int do_con_write(struct tty_struct *tty,
>> const unsigned char *buf, int co
>> release_console_sem();
>> return 0;
>> }
>> - orig_buf = buf;
>> - orig_count = count;
>>
>> himask = vc->vc_hi_font_mask;
>> charmask = himask ? 0x1ff : 0xff;
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs, Novell Inc.
>
next prev parent reply other threads:[~2010-01-27 8:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 11:59 Shahar Havivi
2010-01-26 22:43 ` Jiri Kosina
2010-01-27 8:49 ` Shahar Havivi [this message]
2010-01-27 9:15 ` Jiri Kosina
2020-09-04 0:34 Anant Thazhemadam
2020-09-04 0:59 ` Anant Thazhemadam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0ae6fcc1001270049m6e2e7b1dre9971e57e282b48a@mail.gmail.com \
--to=shaharh@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®