From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@linaro.org>,
Kunwu Chan <chentao@kylinos.cn>,
xen-devel@lists.xenproject.org, kernel-janitors@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
"kernel test robot" <lkp@intel.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Ingo Molnar" <mingo@redhat.com>, "Jürgen Groß" <jgross@suse.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
x86@kernel.org, "Jonathan Corbet" <corbet@lwn.net>
Subject: Re: [v2] x86/xen: Add some null pointer checking to smp.c
Date: Mon, 22 Jan 2024 11:06:57 +0100 [thread overview]
Message-ID: <b0b1ba48-1d48-4163-afc5-ac92121ee14c@web.de> (raw)
In-Reply-To: <dfb6de51-3ebc-41fc-a750-cf5ca2ac05aa@moroto.mountain>
>>> How do you think about to use another label like “e_nomem”?
>> I'll add a new label to simply the code.
>
> I'm not a Xen maintainer so I can't really comment on their style choices.
Linux contributors can discuss various implementation details.
> However, as one of the kernel-janitors list people, I would
> say that not everyone agrees with Markus's style preferences.
Can a corresponding document be improved accordingly?
Centralized exiting of functions
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.8-rc1#n526
Do you find a related information source helpful?
https://wiki.sei.cmu.edu/confluence/display/c/MEM12-C.+Consider+using+a+goto+chain+when+leaving+a+function+on+error+when+using+and+releasing+resources
Regards,
Markus
prev parent reply other threads:[~2024-01-22 10:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 9:00 [PATCH v2] " Kunwu Chan
2024-01-17 10:40 ` Markus Elfring
[not found] ` <1705655941162581.825.seg@mailgw>
2024-01-19 9:22 ` Kunwu Chan
2024-01-22 8:30 ` Dan Carpenter
2024-01-22 8:41 ` Kunwu Chan
2024-01-22 10:06 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0b1ba48-1d48-4163-afc5-ac92121ee14c@web.de \
--to=markus.elfring@web.de \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=chentao@kylinos.cn \
--cc=corbet@lwn.net \
--cc=dan.carpenter@linaro.org \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®