From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12FA2C433EF for ; Thu, 10 Feb 2022 16:40:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244539AbiBJQkq (ORCPT ); Thu, 10 Feb 2022 11:40:46 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:51718 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244522AbiBJQkn (ORCPT ); Thu, 10 Feb 2022 11:40:43 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id EB6EFC51 for ; Thu, 10 Feb 2022 08:40:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644511243; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lKM3MG407sDe7fSxFjGv90FiembQtgV4jikyh1VEkmM=; b=cXzus7t+kppOjLV8Zi4t02AQg/dW/Jv9ID7OwHeRsMcZXXErY7+6foTx4wbp9oIaDGO8nI cvxxM9PxAt6aLQQEe2rFg5hE4aoHJg8+hm1Fh+HO9XqhhZ6GFPaAmCFaz20P+X/Qagi+g1 RLxm0sARfUArM2sxwjelVS1kZGY0ces= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-187-rOqjzm6INaWiTZTl4OE8YQ-1; Thu, 10 Feb 2022 11:40:41 -0500 X-MC-Unique: rOqjzm6INaWiTZTl4OE8YQ-1 Received: by mail-ej1-f71.google.com with SMTP id q3-20020a17090676c300b006a9453c33b0so2968110ejn.13 for ; Thu, 10 Feb 2022 08:40:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=lKM3MG407sDe7fSxFjGv90FiembQtgV4jikyh1VEkmM=; b=DJFCSPRZdymdD2/p6GWG31DVo6PtfZ2i3Cd2QnOxtn5KVYAh188KO08NW5tc4ctbBl +LPxgEkF4TSIN09t5bnW/5PDoZa+/lg5N9lesDfZ7qz00fYIIsM4+WqyfvKEtYb3EhOK sFcHgsB/GZLF6rDi1fR3NepvsYn423YA3JrOfV2TEYLgT3SHjFEe0hv57nlz00L6X2YU ouvfCwvehC9a4fcV9QixYgZq5wDeYDykELGnivoU5gjtyCBTd3THReWrfseCiuXMdq1T OyiVRvSBUZ8HUMFccZc/w+8gT7Olht+o9dpBLJmolQx88S4MzdAXGMO+VuruhBnMloMc SsCQ== X-Gm-Message-State: AOAM530ZuLgrJKx6l3gy1SQ3D1FLL7Q/kGA/N3P9ds0HEiQ5VyuZCQ8p R2VmppKv7IPUX/hO5WuaOIyU08EczyXms9nvCBCAFXiZi7Lciqwa7yi2+4J0puYiX+thyGhW5fT 1v0q0GSuDaJm1iYEU2aTkVfLL X-Received: by 2002:a17:906:4fc5:: with SMTP id i5mr7086706ejw.729.1644511240545; Thu, 10 Feb 2022 08:40:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJzV+kkWAkDA+GVbVhDi40TKxNCd+Z8dy6ITJnQdUuE1VbOyNuQ9Fpdu14fPSu5orbUKXw9xqA== X-Received: by 2002:a17:906:4fc5:: with SMTP id i5mr7086689ejw.729.1644511240351; Thu, 10 Feb 2022 08:40:40 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.googlemail.com with ESMTPSA id s8sm7105459ejb.59.2022.02.10.08.40.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Feb 2022 08:40:39 -0800 (PST) Message-ID: Date: Thu, 10 Feb 2022 17:40:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH MANUALSEL 5.10 2/6] KVM: nVMX: eVMCS: Filter out VM_EXIT_SAVE_VMX_PREEMPTION_TIMER Content-Language: en-US To: Sasha Levin , linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Vitaly Kuznetsov , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, kvm@vger.kernel.org References: <20220209185714.48936-1-sashal@kernel.org> <20220209185714.48936-2-sashal@kernel.org> From: Paolo Bonzini In-Reply-To: <20220209185714.48936-2-sashal@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/9/22 19:57, Sasha Levin wrote: > From: Vitaly Kuznetsov > > [ Upstream commit 7a601e2cf61558dfd534a9ecaad09f5853ad8204 ] Acked-by: Paolo Bonzini Paolo > Enlightened VMCS v1 doesn't have VMX_PREEMPTION_TIMER_VALUE field, > PIN_BASED_VMX_PREEMPTION_TIMER is also filtered out already so it makes > sense to filter out VM_EXIT_SAVE_VMX_PREEMPTION_TIMER too. > > Note, none of the currently existing Windows/Hyper-V versions are known > to enable 'save VMX-preemption timer value' when eVMCS is in use, the > change is aimed at making the filtering future proof. > > Signed-off-by: Vitaly Kuznetsov > Message-Id: <20220112170134.1904308-3-vkuznets@redhat.com> > Signed-off-by: Paolo Bonzini > Signed-off-by: Sasha Levin > --- > arch/x86/kvm/vmx/evmcs.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx/evmcs.h b/arch/x86/kvm/vmx/evmcs.h > index bd41d9462355f..011929a638230 100644 > --- a/arch/x86/kvm/vmx/evmcs.h > +++ b/arch/x86/kvm/vmx/evmcs.h > @@ -59,7 +59,9 @@ DECLARE_STATIC_KEY_FALSE(enable_evmcs); > SECONDARY_EXEC_SHADOW_VMCS | \ > SECONDARY_EXEC_TSC_SCALING | \ > SECONDARY_EXEC_PAUSE_LOOP_EXITING) > -#define EVMCS1_UNSUPPORTED_VMEXIT_CTRL (VM_EXIT_LOAD_IA32_PERF_GLOBAL_CTRL) > +#define EVMCS1_UNSUPPORTED_VMEXIT_CTRL \ > + (VM_EXIT_LOAD_IA32_PERF_GLOBAL_CTRL | \ > + VM_EXIT_SAVE_VMX_PREEMPTION_TIMER) > #define EVMCS1_UNSUPPORTED_VMENTRY_CTRL (VM_ENTRY_LOAD_IA32_PERF_GLOBAL_CTRL) > #define EVMCS1_UNSUPPORTED_VMFUNC (VMX_VMFUNC_EPTP_SWITCHING) >