From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 48B353101BF for ; Sat, 25 Jul 2026 06:42:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784961737; cv=none; b=F14jOUiX+vnhFcRsRDvT1vYLg4+pvEW/jWSLlPkcCGYyEsp3mWBmY3zI7xcv7BE62pm/gPNMRw7oBOlOPqEIdVFb7rebpUq2VRiTAXnUb5iK3Io0UHKBRK74r/3Ll0zMkJ1ElozGFp04b8Pp1k7RzRBRpNA7jhgZas0yiyf3dj4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784961737; c=relaxed/simple; bh=zoKbMi978nDgj2HDslbMe1w2uEVfSZWEuUvbMtbMgfk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eJJmf9T1s2snSsxZXe8Tz1hSkrVJc4Dx7e1+ekmtWax5S4MO3popAQK8OlVxZx+CJ3+XwCP4NZ42dUi9P1zxKWo2cga8hJmH2J5GpY8Si1homuJri+ELpwGrGzDNJvHod0Q9j9FwNlhbXmwkZPb4SrL6/mLnmrGNsvLZ1FIZSjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wer8gqfe; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wer8gqfe" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5aeafa51b5cso143548e87.1 for ; Fri, 24 Jul 2026 23:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1784961734; x=1785566534; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=3rcLlOj89gK3OxZv2MR+AlxF2Au5na5W1MCm2dKXaFM=; b=wer8gqfeqtJpHsTiQCQd8MJFHAlF+kQRpAa7vylCBDbyBFFwlSmIo2m0kWyrJ4OIcG envWaXZ9cR56DLUwmVRqcuc6Yen7Q5U4hxjeSAxRMcgyNmzeIHGYFuMQIECGDZfluCSZ tHOkmgOVA6pgJ416X1imJOCQIsR28O8O3P32v4fMZeZJckDjWfmRXjN55QejjLtvIS+D au/qGVZzd+VJgMf9++PdOh4i2sdat+EEzpI37POhrPkiMl3yv9MJ0NblpQEmL5DKSuyB afZd760FjPy4LubYRyKLyxVQ/lTDoyhfcA77Rm3VyIrLuoxw2AdAIlpA7JUT/nDzWr8l 27yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784961734; x=1785566534; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3rcLlOj89gK3OxZv2MR+AlxF2Au5na5W1MCm2dKXaFM=; b=ly/MLfd1GeuWyRLPfugPJ0FdG5BfJ76P78yA4/5cD/NZjUHvPPSUMVxyCI9l92mkaS wshRipwvVhygu2D1t0WJwDDRxsKeHkrkpOWLv9pUlEIMWrhwECdvp2MnFexfDBeyG13u aS6NkD10tzxFTmnlKkJP01ihq0AUahcJYPHlfz8UNYXEYzAceUfA6Vo2DEMmHuBfXVt6 alHJ8luX8bJjwbuvcuWLfFgncBqrwiu9SteN1rBAQYMySFF8706EB75SNfvON2D0/fPJ FtYflQn63ZV9Ti3kf5cApEjnaIm4ci6k8d1PJKdjWd7yh/DoUfHGXKf0d6qlf8VX7SYL Ja2A== X-Forwarded-Encrypted: i=1; AHgh+RqDV4ETYJnuwtJOM/xq9+QMbK8s54Gg3RF7nucX7DAq6ANxAjnHV1hOc9OBEljCjPIG5QE4xW5M66j6UCA=@vger.kernel.org X-Gm-Message-State: AOJu0YzdAHm+0lTam7FpHxmo9pfn1yDRVR1ojO7frrU9HbSyqGNThoEu r0kxZTOptPtufOrxpAZovyRK18gMhq5fuwyalaxtKsmxCifkubQcsmqKElH/OmpsFmk= X-Gm-Gg: AR+sD10s0epyXVTdZaGHizJXHh/Kp73sKgPMXGL5c0+6n/M2EMfU0szUOTkZiOG7Ys+ kDnqGXmmRErTr+bhtUzowhEwJ9vW2rF2eY5kMYEysmMwCnv5FdFbeTChLyQ8Kxy6MRWCfG8yjec HpTjYZhP20F2w2I9nahbDTw7W4qrp0+isrZBubTgR80qwCiNFGjdn7pEi2Tf/f/JawCzVn5WMOA sfB7Nb04TdkzJ94HBkeaNLwrVisX0Tfs9GhDrBKyNXmZJwpmI/AjKbao+pOVGXd9KN8awSezwNZ csCEFLswtR2CULHx9zlPzV719jXjl7caXtXE1YgOlK2PsN1BNq8ua5xBydM3gtaBBaJvmX5030D gUf2pSpq0cvOkNyYBXCgNmoCa6JHmJp3ypNYWEVuizMY9xprEsLqBDdDNZn+OLTDUr3n8TKC1ee 7qnUUWLLLnowo39s46fj+sZWfsRFSYcgS6NBAVogWuHxRJSG5CvoK7bkB0 X-Received: by 2002:a05:6512:2520:b0:5b0:6aea:cdb5 with SMTP id 2adb3069b0e04-5b2c1af7abemr136512e87.1.1784961734099; Fri, 24 Jul 2026 23:42:14 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b2be1d863bsm291890e87.53.2026.07.24.23.42.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jul 2026 23:42:12 -0700 (PDT) Message-ID: Date: Sat, 25 Jul 2026 09:42:11 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] i2c: qcom-cci: Add missing cci_clk_rate for msm8953 To: Loic Poulain , Robert Foss , Andi Shyti , Wolfram Sang , Dmitry Baryshkov , Luca Weiss Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260721-cci-clk-fix-v1-0-5eae78700da8@oss.qualcomm.com> <20260721-cci-clk-fix-v1-2-5eae78700da8@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: <20260721-cci-clk-fix-v1-2-5eae78700da8@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/21/26 17:58, Loic Poulain wrote: > The msm8953 CCI data was added after cci_clk_rate was removed from the > driver, so it never got a clock rate entry. The DT assigns 19.2 MHz to > GCC_CAMSS_CCI_CLK and the hw_params values match those of v1/v1.5 which > were also calibrated for 19.2 MHz. > > Fixes: d202341d9b0c ("i2c: qcom-cci: Add msm8953 compatible") By the way this commit also does not fix anything, moreover its backport won't solve any bugs, but may break the build, if 1/3 is not applied. I'd ask to consider to remove the Fixes tag here. > Signed-off-by: Loic Poulain > --- > drivers/i2c/busses/i2c-qcom-cci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-qcom-cci.c > index 19e4719f13b29b2cf60e113565b1b63f19d0e669..5f74edde8558382e63e2c3d0fbe19489f325e8ce 100644 > --- a/drivers/i2c/busses/i2c-qcom-cci.c > +++ b/drivers/i2c/busses/i2c-qcom-cci.c > @@ -783,6 +783,7 @@ static const struct cci_data cci_msm8953_data = { > .max_write_len = 11, > .max_read_len = 12, > }, > + .cci_clk_rate = 19200000, > .params[I2C_MODE_STANDARD] = { > .thigh = 78, > .tlow = 114, > -- Best wishes, Vladimir