mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-media@vger.kernel.org, Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [media] tm6000: Addition of an asterisk to the data type for “urb_dma”?
Date: Sat, 24 Dec 2016 12:02:11 +0100	[thread overview]
Message-ID: <b0c2e4b7-5c04-afd8-dc0f-a66c1bd47308@users.sourceforge.net> (raw)

Hello,

I have looked at the implementation of the function “tm6000_alloc_urb_buffers”
once more.
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/media/usb/tm6000/tm6000-video.c?id=84ede50b623fb45c4c026c80d0abf8cc5193f041#n469

A pointer for an array is also assigned to the member “urb_dma” of the data
structure “tm6000_core” there. I would interpret the corresponding data type
specification in the way that only a single element should be managed by
this field so far.
http://lxr.free-electrons.com/source/drivers/media/usb/tm6000/tm6000.h?v=4.9#L271

How do you think about to add another asterisk to this data type specification
so that the desired array management would become bit clearer for such a field
(similar to the member “urb_buffer”)?

Regards,
Markus

                 reply	other threads:[~2016-12-24 11:02 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0c2e4b7-5c04-afd8-dc0f-a66c1bd47308@users.sourceforge.net \
    --to=elfring@users.sourceforge.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome