From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Rae Moar <rmoar@google.com>
Cc: <brendan.higgins@linux.dev>, <davidgow@google.com>,
<linux-kselftest@vger.kernel.org>, <kunit-dev@googlegroups.com>,
<linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>
Subject: Re: [PATCH v5 02/10] kunit: string-stream: Improve testing of string_stream
Date: Fri, 25 Aug 2023 15:58:53 +0100 [thread overview]
Message-ID: <b0c2e85f-fcc1-55fb-cef2-2e2d0fe56747@opensource.cirrus.com> (raw)
In-Reply-To: <CA+GJov7nzgmGmMooAj9BpQ267W6atcsZJ=tULQQJYjbuQL4E0w@mail.gmail.com>
On 24/08/2023 23:42, Rae Moar wrote:
> On Thu, Aug 24, 2023 at 10:31 AM Richard Fitzgerald
> <rf@opensource.cirrus.com> wrote:
>>
>> Replace the minimal tests with more-thorough testing.
>>
<SNIP>
>> + KUNIT_EXPECT_EQ(test, stream->gfp, GFP_KERNEL);
>
> As mentioned in the last version, if this causes a warning we will
> look into it on the KUnit side.
>
It does. I left it because you said you'd do a fix.
But maybe it's better to change it to
KUNIT_EXPECT_TRUE(test, stream_gfp == GFP_KERNEL);
to avoid the warning for now.
next prev parent reply other threads:[~2023-08-25 15:00 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 14:31 [PATCH v5 00/10] kunit: Add dynamically-extending log Richard Fitzgerald
2023-08-24 14:31 ` [PATCH v5 01/10] kunit: string-stream: Don't create a fragment for empty strings Richard Fitzgerald
2023-08-24 22:42 ` Rae Moar
2023-08-25 6:49 ` David Gow
2023-08-24 14:31 ` [PATCH v5 02/10] kunit: string-stream: Improve testing of string_stream Richard Fitzgerald
2023-08-24 22:42 ` Rae Moar
2023-08-25 14:58 ` Richard Fitzgerald [this message]
2023-08-25 6:49 ` David Gow
2023-08-25 9:32 ` Richard Fitzgerald
2023-08-24 14:31 ` [PATCH v5 03/10] kunit: string-stream: Add option to make all lines end with newline Richard Fitzgerald
2023-08-24 23:13 ` Rae Moar
2023-08-25 6:49 ` David Gow
2023-08-24 14:31 ` [PATCH v5 04/10] kunit: string-stream: Add cases for string_stream newline appending Richard Fitzgerald
2023-08-24 23:22 ` Rae Moar
2023-08-25 6:49 ` David Gow
2023-08-24 14:31 ` [PATCH v5 05/10] kunit: Don't use a managed alloc in is_literal() Richard Fitzgerald
2023-08-25 6:49 ` David Gow
2023-08-24 14:31 ` [PATCH v5 06/10] kunit: string-stream: Add kunit_alloc_string_stream() Richard Fitzgerald
2023-08-25 6:49 ` David Gow
2023-08-24 14:31 ` [PATCH v5 07/10] kunit: string-stream: Decouple string_stream from kunit Richard Fitzgerald
2023-08-25 6:17 ` kernel test robot
2023-08-25 6:49 ` David Gow
2023-08-24 14:31 ` [PATCH v5 08/10] kunit: string-stream: Add tests for freeing resource-managed string_stream Richard Fitzgerald
2023-08-25 6:49 ` David Gow
2023-08-25 9:41 ` Richard Fitzgerald
2023-08-24 14:31 ` [PATCH v5 09/10] kunit: Use string_stream for test log Richard Fitzgerald
2023-08-25 6:17 ` kernel test robot
2023-08-25 6:53 ` David Gow
2023-08-25 7:30 ` kernel test robot
2023-08-24 14:31 ` [PATCH v5 10/10] kunit: string-stream: Test performance of string_stream Richard Fitzgerald
2023-08-25 6:50 ` David Gow
2023-08-25 6:58 ` [PATCH v5 00/10] kunit: Add dynamically-extending log David Gow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0c2e85f-fcc1-55fb-cef2-2e2d0fe56747@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=brendan.higgins@linux.dev \
--cc=davidgow@google.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rmoar@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®