From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43B74C433FE for ; Fri, 3 Sep 2021 04:15:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B4E9604AC for ; Fri, 3 Sep 2021 04:15:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231871AbhICEP5 (ORCPT ); Fri, 3 Sep 2021 00:15:57 -0400 Received: from foss.arm.com ([217.140.110.172]:34740 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229573AbhICEPz (ORCPT ); Fri, 3 Sep 2021 00:15:55 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2BB37D6E; Thu, 2 Sep 2021 21:14:56 -0700 (PDT) Received: from [10.163.72.65] (unknown [10.163.72.65]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 05B463F5A1; Thu, 2 Sep 2021 21:14:52 -0700 (PDT) Subject: Re: [FIX PATCH 1/2] mm/page_alloc: Print node fallback order To: Bharata B Rao , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: akpm@linux-foundation.org, kamezawa.hiroyu@jp.fujitsu.com, lee.schermerhorn@hp.com, mgorman@suse.de, Krupa.Ramakrishnan@amd.com, Sadagopan.Srinivasan@amd.com References: <20210830121603.1081-1-bharata@amd.com> <20210830121603.1081-2-bharata@amd.com> From: Anshuman Khandual Message-ID: Date: Fri, 3 Sep 2021 09:45:53 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210830121603.1081-2-bharata@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/30/21 5:46 PM, Bharata B Rao wrote: > Print information message about the allocation fallback order > for each NUMA node during boot. > > No functional changes here. This makes it easier to illustrate > the problem in the node fallback list generation, which the > next patch fixes. > > Signed-off-by: Bharata B Rao > --- > mm/page_alloc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index eeb3a9cb36bb..22f7ad6ec11c 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6277,6 +6277,10 @@ static void build_zonelists(pg_data_t *pgdat) > > build_zonelists_in_node_order(pgdat, node_order, nr_nodes); > build_thisnode_zonelists(pgdat); > + pr_info("Fallback order for Node %d: ", local_node); > + for (node = 0; node < nr_nodes; node++) > + pr_cont("%d ", node_order[node]); > + pr_cont("\n"); > } > > #ifdef CONFIG_HAVE_MEMORYLESS_NODES > A small nit, checkpatch.pl throws up an warning. Should this use pr_info() instead ? WARNING: Avoid logging continuation uses where feasible #29: FILE: mm/page_alloc.c:6282: + pr_cont("%d ", node_order[node]); WARNING: Avoid logging continuation uses where feasible #30: FILE: mm/page_alloc.c:6283: + pr_cont("\n"); total: 0 errors, 2 warnings, 10 lines checked