From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EE942DA74D for ; Tue, 9 Dec 2025 09:28:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765272484; cv=none; b=j58hKMSUZ0zUngCxpJYOtKR0BZ3DhNobJzVdQWD2/5Z418P9e5+l0f31H/9rdDUXwWitFSm6iuvlikDwIQiQdSc7L878oJnFH1UfLLfSZniTkab1gZRbcYjRGW2LB/RfHbaEMbGc9/Cc8owpBuXuvymokgPyllaL6dLPnFvJSLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765272484; c=relaxed/simple; bh=kwgclz4dXdz8QcECqcwfxGyt5SPgFbmgqeaP3PoEC1k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nBEZSJq5CbFzP8bZCd0jv3sLifwMjPB8mc+n2e2w7fIGSJde/mg4eIIxNMEW3yHPbLpdpblE2Wd1XWqiuBtmXC4hpRBQkzucC+YodTiAmkOYZvGkCt4JngqjU59URGdgnh4hrGmQNGu5A/B0XFKQq+vYwR7LUWtGYyzRf3ITcv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=lGQ/58zi; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="lGQ/58zi" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-477bf34f5f5so42201455e9.0 for ; Tue, 09 Dec 2025 01:28:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1765272479; x=1765877279; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=R3CUO+zBXmtdsEkHsBoN0U2nlcRNrt25WJX7v9vW9fw=; b=lGQ/58zitcHXho4KaD6m2KgHOU7HviS59q7DUsNHHsa+pCjvAAzjN1yNiBu2cJv42z DtLXAHp+cIpU5IeCYDE9mfArtBfb3bvsqGavVYHGYJiExJQfv6bJYM0meyAeuQ/yYOkO D/JeUBmZa13Uo6jOH5Fw0WCJl6+CKTkkxasp9BLBzF6DIZC8JNse7pswbRNB9PFUjbJA 8DdvorVioPvphjeL6qhvdn6N1rzjWcxeeR7WJOSln5j5bemk8JOzgu5SvozVMefEHAqh 6oBmWQHOT5avnGOfQ78Ob9OMGkBzTNPmM3d6nTXaM/JALJHKRrbxm9vNnbNyP0SkHVyX iAog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765272479; x=1765877279; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R3CUO+zBXmtdsEkHsBoN0U2nlcRNrt25WJX7v9vW9fw=; b=u5afk2c0aqROf8IBv73m5lLaeIgu60fufIgf/rnl8KfvOgRMPsmjtcpcXfJAjdQw7X mrDrkbVZgeOQgr9CN3aOQ7jMTVEzt3QoXOZVqLq8/p+SuM22KNDZZGonAF6fWqj/l7Sf jkzw+e7Q0bZGHPA/QcCKG0LRgUi8IRfGqPgBvFZGpXohZgZ1lU7DioZWwidVRtu9TP/Q +ijOqP4e+I6nxxyBSxTctsTR3ento4P+8s0H3AhbEXlioZuUNyr2zAug9a+WxsbDJiOu 0Ct5zAKT1RS6yGhtm9KLpgXpPtHgjXOap47t4EoRMfIkc+Fg5Uj3pWCCD61d243WPY+z vrAQ== X-Forwarded-Encrypted: i=1; AJvYcCWPies+b3ZhQweWMXzImoncU3Zv127Wh//JBZqn7RNts9Zc9ifF2zeaC8S+8B7KJ9mVFyff72utGXiGP/w=@vger.kernel.org X-Gm-Message-State: AOJu0YyO//QbjpDz4AZyV1LVaSwx9kGDVnVk3fGcvs/oRREeiIdSRais K83b3Id3zUn5tOeuvdBpYMsC5RGBJdNVdBu4P4+ozLAYVx1bwomJ8NjA+BxVzi5VOTE= X-Gm-Gg: ASbGncu/jphWGpFUZeff5AyuZSLAnXtlsqXsIc7HUeiBcBibUPI2nuJdKGFX//snD+F 1mkE+nvDOHv8e1ICf3uHcnK7QLMt0T8QlXd1KFiyQxAELZ1RUooH2mKYqG0auiQP/zOihhs/dAl 0RHb3geH/CASR1NwvO4GVru0O4r0e7uWKKZ+xA6qsdRV1Av2Owsy0XI2WlptPXpdPp2NXalXYb/ mYMTqrRRXiM88Bpa2VoWBbWe+vnIXTOYapFwjXjYKTU2PoBNS2m20CH2kmflGpRfZA+N0pZYr4a wuNq/kIYqO5yKi10XJM6lSqB/4KDZNScrNwS8+9TaXA8j9TEx1Mv9xIGj8b6jZPaOTXJpZehyYe dLF/LZPkioeiwcWDXbMUgBO/ZEwMIsho6qfoeNODeRqJPQNuUVQ6I7ye6Z6YEti2R+K2Rxh0uSM fHlua1Vhx/Io02d0Xmgr8= X-Google-Smtp-Source: AGHT+IGU65rxEAITpH754auEUsEUpkQYQjZXXF4Pby3Lcu0cneSAD5FbIv9NJfGhM0XDP2w3AdsviA== X-Received: by 2002:a05:600c:3593:b0:46e:6d5f:f68 with SMTP id 5b1f17b1804b1-47939df83e0mr107183285e9.12.1765272479234; Tue, 09 Dec 2025 01:27:59 -0800 (PST) Received: from [192.168.50.4] ([82.78.167.134]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a7da084fasm12009025e9.8.2025.12.09.01.27.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 09 Dec 2025 01:27:58 -0800 (PST) Message-ID: Date: Tue, 9 Dec 2025 11:27:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] irqchip/mchp-eic: Fix error code in mchp_eic_domain_alloc() To: Dan Carpenter Cc: Thomas Gleixner , Marc Zyngier , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: Claudiu Beznea Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/9/25 08:54, Dan Carpenter wrote: > If the irq_domain_translate_twocell() function sets "hwirq" to >= > MCHP_EIC_NIRQ (2) then it would result in an out of bounds access. > The code here checks for invalid values, but doesn't set the error > code. Return -EINVAL in that case, instead of returning success. > > Fixes: 00fa3461c86d ("irqchip/mchp-eic: Add support for the Microchip EIC") > Signed-off-by: Dan Carpenter Reviewed-by: Claudiu Beznea