From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D932FC4332F for ; Fri, 14 Oct 2022 06:31:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229790AbiJNGbu (ORCPT ); Fri, 14 Oct 2022 02:31:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229751AbiJNGbr (ORCPT ); Fri, 14 Oct 2022 02:31:47 -0400 Received: from out30-45.freemail.mail.aliyun.com (out30-45.freemail.mail.aliyun.com [115.124.30.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B780532B9D; Thu, 13 Oct 2022 23:31:46 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VS6XyKN_1665729101; Received: from 30.221.130.30(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0VS6XyKN_1665729101) by smtp.aliyun-inc.com; Fri, 14 Oct 2022 14:31:43 +0800 Message-ID: Date: Fri, 14 Oct 2022 14:31:41 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH V2 1/5] cachefiles: introduce object ondemand state Content-Language: en-US To: Jia Zhu , dhowells@redhat.com, xiang@kernel.org Cc: linux-cachefs@redhat.com, linux-erofs@lists.ozlabs.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, yinxin.x@bytedance.com References: <20221014030745.25748-1-zhujia.zj@bytedance.com> <20221014030745.25748-2-zhujia.zj@bytedance.com> From: JeffleXu In-Reply-To: <20221014030745.25748-2-zhujia.zj@bytedance.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/14/22 11:07 AM, Jia Zhu wrote: > Previously, @ondemand_id field was used not only to identify ondemand > state of the object, but also to represent the index of the xarray. > This commit introduces @state field to decouple the role of @ondemand_id > and adds helpers to access it. > > Signed-off-by: Jia Zhu > Reviewed-by: Xin Yin > --- > fs/cachefiles/internal.h | 22 ++++++++++++++++++++++ > fs/cachefiles/ondemand.c | 21 +++++++++------------ > 2 files changed, 31 insertions(+), 12 deletions(-) > > diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h > index 2ad58c465208..39895bbd149a 100644 > --- a/fs/cachefiles/internal.h > +++ b/fs/cachefiles/internal.h > @@ -17,6 +17,7 @@ > #include > #include > #include > +#include ^ This is not needed any more. Otherwise LGTM. Reviewed-by: Jingbo Xu -- Thanks, Jingbo