From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Muhammad Bilal <meatuni001@gmail.com>
Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
marcel@holtmann.org, luiz.dentz@gmail.com,
johan.hedberg@gmail.com, stable@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: SMP: add missing skb len check in smp_cmd_keypress_notify
Date: Mon, 18 May 2026 22:29:59 +0200 [thread overview]
Message-ID: <b0ca0897-6fcf-4bad-87da-9a1b0df1f083@molgen.mpg.de> (raw)
In-Reply-To: <20260517190312.56076-1-meatuni001@gmail.com>
Dear Muhammad,
Am 17.05.26 um 21:03 schrieb Muhammad Bilal:
> There is no safe way to access kp->value in the truncated case, since
> the payload is not guaranteed to be present when skb->len < sizeof(*kp).
Indeed, you are right.
> If diagnostic information is still useful, only metadata can be logged:
>
> if (skb->len < sizeof(*kp)) {
> bt_dev_dbg(conn->hcon->hdev,
> "truncated keypress notify, len=%u",
> skb->len);
> return SMP_INVALID_PARAMS;
> }
>
> This keeps visibility into malformed packets without touching unvalidated
> memory. Happy to send a v2 if that looks good to you.
It looks good to me. Hopefully the maintainers agree.
Kind regards,
Paul
next prev parent reply other threads:[~2026-05-18 20:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 14:54 Muhammad Bilal
2026-05-17 17:47 ` Paul Menzel
2026-05-17 18:08 ` Muhammad Bilal
2026-05-17 18:41 ` Paul Menzel
2026-05-17 19:03 ` Muhammad Bilal
2026-05-18 20:29 ` Paul Menzel [this message]
2026-05-18 20:37 ` Luiz Augusto von Dentz
2026-05-19 0:14 ` [PATCH v2] " Muhammad Bilal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0ca0897-6fcf-4bad-87da-9a1b0df1f083@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=meatuni001@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®