From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A47839098D for ; Tue, 24 Mar 2026 09:48:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774345707; cv=none; b=S5wNwfneS6e3rqyWIgofx5HBYuIaFEakp0vRIt2xT2f2BdqrZCxm40cvkjQPjcPY6Xe9sXEXhkwF5JavneN7mGttzx6YVvtovL+2rbfhs690UgX8ztzaiTpjKpyBhK2HZI+CqCpgA7BViMqSGlk7uFi33/1fbI9mNfsrgZVimpU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774345707; c=relaxed/simple; bh=iI/S+AUROO2ET41n/oQ7AYFci8kQ/u6iCfmO81T+k3M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=elpQxcaVIW9b46zLJfbpeUw4pRH2Kxiqdqp9e6qKt1YQEx8Zb55plX4sTCz5dgJ2NtOb56rMMEdeA5O1px5jG7o6nKdmSUViK0wyR1UJBfo0UOciU5rDNKt3YeIVKrppA+vKVxeJIAfHaCai+tWrxbgPq85uzKYMTr8u54S7leU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IEvWCCKY; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Gka8S0a9; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IEvWCCKY"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Gka8S0a9" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62O9BfZ93934736 for ; Tue, 24 Mar 2026 09:48:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= hoKEgoUvUUln+NtcEflV6fUXI9ZyYyiSqPOsjxxTzBs=; b=IEvWCCKY9vy/yuDb 04ReAzzSAoeErOTGrwCRQpWfp/vUOIUPaz5yuM3yRRUY9j/yGVVCXuc8nZOFQJ26 T3yyuLo8/QhXeLMpJG+voaM7V0pRsq+7Cg9Hx9G1zJ+gqwxEwEIBXLiIQ3v9hPHH U4Iwq0GElfsS9GcQpSgBXTDbg34c0RAuWymODNWqtVVI1F0l8Bo8Wbxue9tFcgBb OrO+S7G8mWkXVEZDoP49XlSns707Pp0/E7JoXd1dYO/kSgtTqG+O1sx5nGsu49S4 Yz9+fPVxVfxUcFDyBOzx/w6zzpxbD8j125hhOYyZE2iCxEmTjfU5FI03/fBxZ95B eLyGXw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d37a0kt8m-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Mar 2026 09:48:24 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-5093245c2d4so22468871cf.0 for ; Tue, 24 Mar 2026 02:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774345703; x=1774950503; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hoKEgoUvUUln+NtcEflV6fUXI9ZyYyiSqPOsjxxTzBs=; b=Gka8S0a9Kne7ce2MgRccJByyvvT5qq/HB+AMj8ONJuQRa5fdixWTw5FCgVj3dBsqkY xdKdO1O83h2Kr3X3KIjowe2ioPEs+3PZd3wqCh2pxgdOFikytDuXHEiGj5fePUWsDCmf vBmRj2S/VFX7IRudw1eW2Vp0wPZeglUROzOBbqE51c8lcm0Scqipr88DHCm2z0+VZRhk RAWyyIoYXZFiRT/NGN+Jbjd19N5+nKRQwQ/ZE7n0LuxiDHVGRNXS/ZuqNH4LS6Ba0AwF V0igyNU4wj4BoxkpmPXTq/eG1fSPf0iOxyxbeGA5m2hKOlRiVhfatKp9NhWMGjko6FDz PoTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774345703; x=1774950503; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hoKEgoUvUUln+NtcEflV6fUXI9ZyYyiSqPOsjxxTzBs=; b=ny9mrxtlgYqwkDoKTZtVv6a35ZQPjS5DxUaZeL/Dc9n7yO1BL6Xj7my03ab4rv6qZU wLYkLvPTsJWzC7vMzF7eOTBCpFktGP7gRzIqj+Cuv0EjxQ9LQonEvGEwi6Q0eW3T4eL3 zQVACia7JAld3RACILC/XtQullyFicQBW50eYDDkCwCG+cgjOr0p7aYC95WnxyCZcsVw T9TXoPqYHnd613OQ4NHPDHDHG+E4XE47U15kznkY23AJNGh64carslA/ZmPixiNZmWxN 6jiG/lD1R5UBOpEfVYf4XLl32v7r80lfsDxh8f5KS9OIpNPCNMTtQiDNqMsRM4BnsN9j iTMw== X-Forwarded-Encrypted: i=1; AJvYcCXerJ0rjw3mH8RXrZrw69a+wGPTqGox2BZJoav34A3cDxcNjZQXmX6z9qZS04mjQ87lZs04Ns+oULbRDTg=@vger.kernel.org X-Gm-Message-State: AOJu0YxtLU4EsiHfeUiZLgstDcgHe1KXTCwelu0cPaQwFh1ftpCsBTmG svVn0oGaabZSkU34D9pov40jaJpNn9KybvSsIhqf2uivXJ7ZsBcg7X149cdqSb1nUvtn3gHc/3i 2YODJcY3p4X99dVEP6+sdSh1I37KlXudJ0e+CYgjgTIfSC5JVi+ZqLreSViam/n7bJ/A= X-Gm-Gg: ATEYQzwbOWnCQ5MOBCQWB0PLgniXTMB1WAyVpqQfRopEiXBAEo7hbvO72nh4oHDwMzp jT7MF3RJKXRKig9eECClwV8LfpIOHq1IYoExXst3otmprNJN3Y0NXrM71uTx+InDs78sCJ8clpU GN2qdea85WR9SWAxCJH5jP0XVzT1meHrEIRfbQhYL9RX5MDy8/C09sFoe6ygJmp7563LBWJgJ1a cs+EcrpSuZ7SuZ3vJw7dix9c03+zW+QGddrbEwAr///B6tCAXAnE+IrU0h3hpQZyc6Q/HenyXyK MYJRc78OXTFWZ1YhwB/lSTHBGx/0yKTCJUrSi3nMrvJewm6lG2ift9QP1i/60N2pxbhV4Fpza5c 6zSaCtwpcQQFE5uvj4sTBYBxERHXVdinxVQtAXoLrfKl95y8Y1bAOtCszJRJb9Jrco0oXNuGB0L ZFqpw= X-Received: by 2002:a05:622a:1992:b0:509:d76:fe73 with SMTP id d75a77b69052e-50b373d748amr181292231cf.3.1774345703520; Tue, 24 Mar 2026 02:48:23 -0700 (PDT) X-Received: by 2002:a05:622a:1992:b0:509:d76:fe73 with SMTP id d75a77b69052e-50b373d748amr181292131cf.3.1774345703079; Tue, 24 Mar 2026 02:48:23 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a285192e88sm3096534e87.12.2026.03.24.02.48.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Mar 2026 02:48:18 -0700 (PDT) Message-ID: Date: Tue, 24 Mar 2026 10:48:14 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/16] drm/msm/a8xx: Fix the ticks used in submit traces To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Antonino Maniscalco , Connor Abbott , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260324-a8xx-gpu-batch2-v1-0-fc95b8d9c017@oss.qualcomm.com> <20260324-a8xx-gpu-batch2-v1-1-fc95b8d9c017@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260324-a8xx-gpu-batch2-v1-1-fc95b8d9c017@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=GIIF0+NK c=1 sm=1 tr=0 ts=69c25de8 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=SuZvJZu2A8V8SJCN6oQA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzI0MDA3OCBTYWx0ZWRfX/6sTa4b8eTMz 448TwwWWICvIGMS5TGwNeKQZQL+wcDGAXxjK+AR2I/DoFXyLd14apjX1zMP5rirwT0hgXSDCec7 f+s6tUuWCxIi3dtviY3ZBGdUi6KWoBpK9h8Wa+fFNenmWLBFQeiitTeu5/080qseGc06+RbbfVJ kWhLEFMn9HOxrGZ7ga5puEmgKjUyVExZ033dmLcoriPGZ0vlDIbPu4BG9/vWDGZVitMBdaCiVgZ XV53Dyg5eY+oqGseTc7gX6KrbQcgqt8Wfs7+Nk/Yl5YktaEhpnNsJiQ+rEBHO/xkGk1iZvuNNr7 cpXhlGb1gucfJV/vePfS/lOtK3de1iQ3eV1uiszL7DGzSSAEqnkgqcEW4jT7mIg3sXyD6cyoV+x 5MR+V+qxgINVuRv7Yd+gUf8UgEyHVFp3/oNAA1gCZ03Dy4o/lwvP+bcS8+CapZJwrBy7iaiTgiT b7W0muHIF2BeGNStx3A== X-Proofpoint-GUID: R6kTXsh1i0aVJarE4wfkFWuzMadRF7BJ X-Proofpoint-ORIG-GUID: R6kTXsh1i0aVJarE4wfkFWuzMadRF7BJ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-24_02,2026-03-23_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 suspectscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603240078 On 3/23/26 9:12 PM, Akhil P Oommen wrote: > GMU_ALWAYS_ON_COUNTER_* registers got moved in A8x, but currently, A6x > register offsets are used in the submit traces instead of A8x offsets. > To fix this, refactor a bit and use adreno_gpu->funcs->get_timestamp() > everywhere. > > While we are at it, update a8xx_gmu_get_timestamp() to use the GMU AO > counter. > > Fixes: 288a93200892 ("drm/msm/adreno: Introduce A8x GPU Support") > Signed-off-by: Akhil P Oommen > --- [...] > -static int a6xx_gmu_get_timestamp(struct msm_gpu *gpu, uint64_t *value) > +static u64 a6xx_gmu_get_timestamp(struct msm_gpu *gpu) > { > struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu); > struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu); > > - *value = read_gmu_ao_counter(a6xx_gpu); > - > - return 0; > + return read_gmu_ao_counter(a6xx_gpu); Can we instead make read_gmu_ao_counter() take a struct msm_gpu * and drop this wrapper? Other callers also already have a ptr of that type [...] > -int a8xx_gmu_get_timestamp(struct msm_gpu *gpu, uint64_t *value) > +static u64 read_gmu_ao_counter(struct a6xx_gpu *a6xx_gpu) Similarly here (also I know this is a static symbol, but keeping an a8xx_ prefix would be nice [...] > case MSM_PARAM_TIMESTAMP: > if (adreno_gpu->funcs->get_timestamp) { > - int ret; > - > pm_runtime_get_sync(&gpu->pdev->dev); > - ret = adreno_gpu->funcs->get_timestamp(gpu, value); > + *value = (uint64_t) adreno_gpu->funcs->get_timestamp(gpu); "u64", I think checkpathch will also warn about whitespace after a typecast Konrad