From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 867BD1A0BFE for ; Wed, 5 Mar 2025 16:40:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741192811; cv=none; b=uxWZifGAuEa1jvNATOdd+vbp7crRhpmj3GzkGbtQavR7Ni0xquLxAdZgaqqz5J/tUdbDi/yGwB9mHbgvjqV7ZNPOgFHV/67fi+kWiBaceD8f6+UJ0n9RciBhEck5zJ1HkPsQK58A048ZdRYE4ioL4I4zAPB2MFGR8gqE0er3ky4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741192811; c=relaxed/simple; bh=yMxwl6XD0hI3JMpxLKJHQ3pWBmSpmW3p8zjN38EOoiU=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=M8V4+G33Q6RCaZNYIVnC1vZOcvSAQe+QK4fjt+EkX8pZwDTQbahcOcNG3jwYFmqNgSAyQZNMKIEwUVUgKEpKj4DC7qIdNdAcrG0Zz44ba6084dWmOR3mXn/+yTi7wZyEMZeFVMKK6y5dos7yS447puN/2+/wzYl4VhJzFtOueFk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=UJ//hv/L; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="UJ//hv/L" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1741192810; x=1772728810; h=message-id:date:mime-version:from:subject:to:cc: references:in-reply-to:content-transfer-encoding; bh=yMxwl6XD0hI3JMpxLKJHQ3pWBmSpmW3p8zjN38EOoiU=; b=UJ//hv/LdRtSFWpqf+om7mZuuvXa4dJx2+qFK1kAWgcbLN7UNYMahfKh kHZEvTZcWbcE4bz3V75QNTdDPshYeXvrbINYXiFLqI7lhnK2xb9tenNMW HcZzEhmhUUXZU6K/M9g7bixKqrmbFOl/i/Dc2tkObNlnqJd1H9HrWLhKh j03Ah9RgwyC/NHQsppdbabc//0VgfhqMsmfMvHxql1oS6S0/5iMHr/pKB uqXzhjWgw9+Dd7RbDQNA89FGsYwQMdZiMHagWJNJoKmiv+q4y4eyP6ehx EdvHboo6mfAvA9V/M/8uG5W86cmbDperqe6pG7BnDNhQQlDMPs7mP0ck4 g==; X-CSE-ConnectionGUID: +TlFcLleTl69da6TgIvDhA== X-CSE-MsgGUID: iFZhwl//RmuuLxhwHbTT7g== X-IronPort-AV: E=McAfee;i="6700,10204,11363"; a="42363018" X-IronPort-AV: E=Sophos;i="6.14,223,1736841600"; d="scan'208";a="42363018" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 08:40:10 -0800 X-CSE-ConnectionGUID: nDtYZWiwTGutUURCD0mkxg== X-CSE-MsgGUID: KE/YVy7ERyaIXXMqHdne7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.14,223,1736841600"; d="scan'208";a="118458907" Received: from kcaccard-desk.amr.corp.intel.com (HELO [10.125.109.196]) ([10.125.109.196]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2025 08:40:09 -0800 Message-ID: Date: Wed, 5 Mar 2025 08:40:29 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Dave Hansen Subject: Re: [PATCH] x86/sev: Make SEV_STATUS available via SYSFS To: Borislav Petkov , Joerg Roedel , "Kirill A. Shutemov" Cc: Ingo Molnar , Joerg Roedel , x86@kernel.org, hpa@zytor.com, Tom Lendacky , Nikunj A Dadhania , linux-kernel@vger.kernel.org, Larry.Dewey@amd.com References: <20250305105234.235553-1-joro@8bytes.org> <20250305111251.GBZ8gxs_6O7g3gLVEh@fat_crate.local> <20250305113155.GCZ8g2K1XEdgynTA9D@fat_crate.local> <20250305115035.GEZ8g6i7NTiSfkxk7J@fat_crate.local> <20250305153705.GKZ8hvoaz2GPt2rGtu@fat_crate.local> Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250305153705.GKZ8hvoaz2GPt2rGtu@fat_crate.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/5/25 07:37, Borislav Petkov wrote: >> So this question boils down to whether the parsing of the bits happens >> in kernel- or user-space. Actually there is already parsing in >> kernel-space to print the status bits into the kernel log: >> >> SEV: Status: SEV SEV-ES SEV-SNP >> >> ... which is great for a quick glance without needing any tools. The >> user-space tools which already exist have their own parsing of the bits >> and for them it is much easier to consume the raw value of the >> SEV_STATUS MSR. See my changes to snpguest: >> >> https://github.com/virtee/snpguest/pull/88/files > Well, I guess we can do both: > > cat /sys/... > > SEV_STATUS(0xdeadbeef): SEV SEV-ES SEV-SNP > > So that people don't have to pick apart the MSR hex value. > >> Btw, what is the equivalent on the Intel TDX side for these feature >> bits? > There is none, AFAICT. That's why the whole discussion. TDX's history isn't as exciting as SEV. TDX guests have CPUID to tell them that they're running that way. TDX hosts are much more arcane. You can't _actually_ know that it's a TDX host until you actually start making successful SEAMCALLs and the TDX module answers them. But we fudge it by just looking at MSR_IA32_MKTME_KEYID_PARTITIONING at boot and assuming that anything with that MSR will be able to be a TDX host. We've just got X86_FEATUREs for hosts and guests: #define X86_FEATURE_TDX_HOST_PLATFORM ( 7*32+ 7) #define X86_FEATURE_TDX_GUEST ( 8*32+22) and that's it. Folks certainly _want_ something in sysfs to dump the TDX module version and so forth, but we've resisted the urge so far.