From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 521DC401491 for ; Mon, 29 Jun 2026 11:21:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782732084; cv=none; b=sC5DBbxw/NX3AUUfUZ8JFgkdx/HSPmG8hr2B2lycd1nQls0qy9000lFN2RjgGaF1Ef0mIrL4xQfRN2ug24Yu2GAxvHVDlx/V9iQjDWOI+B/YDClUVprg3liS3QC9wJNmqM80UYs57/+Keq5P5a2KgrKBfaZNillq2xc4IpEsSZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782732084; c=relaxed/simple; bh=DwKXwX6baoOIzTXJrJpGh5Ew485gFGr7gK/rfEbqA+o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=raPbSep9xDA6sE74FHvtBgg7PPf0dHz5SpRbtyV+A4/J8PDXzEYGGlLED0H3KFe2fo3hK+h8ZA/Y+Vr1kwDHobsk3Im9UwnB6mT2P4wIn46GVTJ381KWtqT5WKnmVYAxFmYn1DjRDbhHuqMWNY9zUG9dcDewJzRHWJRkhLKJ3Jw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Cu3waHvS; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OTYlkVOo; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Cu3waHvS"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OTYlkVOo" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65TASubN2601194 for ; Mon, 29 Jun 2026 11:21:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LXOilQQrt51TOYTeVjRcNsmOe1jgvaX2sVFJQ9kcEWA=; b=Cu3waHvSC9aa5XHC Lf0BecL03csE7Lr2SUHnjqCsvBYGdtRBM9GIdAujBV5WHi/tjoivVFX2L1l05dEK 4xZRnizC1CwRau9dMrcgGX7TrC2G4L+sIrDydw50xxz1xA7Gpcat8vxehVYbb1sj rk44nE5ogiqnuzr8Z8yUGGa2o/aalpiyWf2xNb2jLF3VfCQvJnovgmX0Xb6kTZVx fZohAecFw0wd/aj5NtB2rgl+4SoIrpdAIs3ZCHxUN8BLqHR4GUyoD4MrJxuN6ha9 p7A7Tqohyo6cKLHkoMJHeovVsS2YgotIAO6tndQl2hB3kkib2bfGudFpq7p+4l8n zYbp0w== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3nnw8hw2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 11:21:22 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-738f59cca12so15463137.2 for ; Mon, 29 Jun 2026 04:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782732082; x=1783336882; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LXOilQQrt51TOYTeVjRcNsmOe1jgvaX2sVFJQ9kcEWA=; b=OTYlkVOoZcfrSdGsyjOhENpUkKalrq4SLz9Q1XdnZdYnG3Yhvf8LtJHwwOVSB8nOq8 pkbcgQJZycSfEQPaK2BFO0s5tRlO2lw4Mw5bRcehLVSYcKkznw/KR5qByMRDWgjPkm0w fLRW1XwBKsE87mTlyPv2/LYQa5NGxm2yA4UXsNA8gWRRt8EjBx3R31lScMCV3eXUz1mM z0yHe2Rw29ONId7F3FrlgH9AOrOpZ1KUjusqhNII4p805ErkT8LOY9Qi6FrLdKUgza1o KncVTZIU3EY8TxUjD+QwWle0lQ5kvnT5nFtsdOIWE1cPAkWSPR8pIu0zHkLnyzAbP9UC N/1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782732082; x=1783336882; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LXOilQQrt51TOYTeVjRcNsmOe1jgvaX2sVFJQ9kcEWA=; b=MgkNk0lCAyP/ji6pLXQWa7DtlUohqjB9k6fl60ttX2cefKxLZvzEQFzDXDUNqzKREH wWK0rR29VTe75GkSfN+eV/qQNF9pdf5hVRkWNsK8YtQSd2AaC7oGNngvJU9fnqav7oWo 0nDUmo3czom9ubPvTyKWWixhxuEDv41FMsWT1JpI1CFcC0qpurRBVU518sm8KvILXbvV zgs9IrD40pDTZXMgsmMaBYLA4sAmoMpYfKS3cBc49aFJk0PtlQw2BRRxBtrU/+73D7n3 5OnSZ5rZrmS2Hzxy/Yb5fhEs2RWOZ/KUvCRMdYtCCSRvV37yxKZUuvKcTi/w3JjEVWzp aN9g== X-Forwarded-Encrypted: i=1; AHgh+Rq7d53/GuVVemq8j/QHioj5u8k6w7zHWhQjKMroIP/ZSQN8i/4DD1UlU7OrOX8TTcBYCh/r2LwUhhDpTx0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0ipfMT5IVNyUspu+6Ap2/9Ix5xUMJR6zg928sZIyQ/2aISt5t fHuG0zLhmABZrLDQYcar3rKyxoeB9K4SHgXQN1leIk9My35HiSfQx/hMXu9vE8Nm3Q95Vp/1KdW 4p1oNvNDyHx6vsCkErVxqJDn94C5bUgUv8rxxJuQc24K0rPu4iVmT7PQggqvIvy1gAUTZTxW8Zu k= X-Gm-Gg: AfdE7ckyLhy0AD6wJrsuX8K2VMIlLhgx78GuLD2Fya4qxP6aH008JGmauhC00AQFy8V +OnMIMMbhLJFDUhcsnowUpR+7KE4MAJzu0w5acPSaPlbehg2QuS8FvgyZ3ok0R/juEXFL8nWCF5 4oFRuRZbE1WlJr6nRO2xQ6dZ1IySDL0OLUx7gjxReaQ6bVy7PUMhRSCGSbcwku0rDUlvda416W/ NHpZCH6+fZopNiymKMlw0soXhC3EIHYl4+bzYl30KX1sb7e7l60fhcnc0hBcLOR14R9/O0e/pDw tU/04X+f0BqNh6veYfUsmtgYzRgv0Z+gPUhNzki3D+vsGc7avl/qiUSK+8rc9TFKyzDJZYdfXvF m0SS2bTtV+ZlftT6KWuo7g5MYCyoPtT73dSg= X-Received: by 2002:a05:6102:5121:b0:739:5c3d:605b with SMTP id ada2fe7eead31-7395c3d68d4mr228113137.1.1782732081645; Mon, 29 Jun 2026 04:21:21 -0700 (PDT) X-Received: by 2002:a05:6102:5121:b0:739:5c3d:605b with SMTP id ada2fe7eead31-7395c3d68d4mr228109137.1.1782732081236; Mon, 29 Jun 2026 04:21:21 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-698481d0359sm3239926a12.30.2026.06.29.04.21.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 04:21:20 -0700 (PDT) Message-ID: Date: Mon, 29 Jun 2026 13:21:17 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] platform: arm64: qcom-hamoa-ec: Register cooling devices with their name To: Anvesh Jain P , Sibi Sankar , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Dmitry Baryshkov , Maya Matuszczyk Cc: linux-arm-msm@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260629-fix_cooling_device_register-v1-1-c6e518b0bbd4@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260629-fix_cooling_device_register-v1-1-c6e518b0bbd4@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDA5MiBTYWx0ZWRfXynfkH1i1yHdH mc/M6TgKLh4eLIb/ZCuNocr3WDivCOpzzBbH8F0yfQaTLYfnW5fabTmnYuKeTGHB8Yvk3bEaQYp E4nXGPHawAj3tD18BZAENN+3i06KdP4= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDA5MiBTYWx0ZWRfXybqXgvOeHKoT 32sJdPXa0E0VPU9ELZLrIjN8fLgAaDVnroYnhSRK4GNrsTKvEmAqcC1pDu8rAtjdcAbyFF+BJbS ZDLwQ1BlGlZJtGdpP5HQWnTn30x1prMZmhGj470IU7aih038wv7jhv1b/PVETe1s6c7NoplXYt3 mDnXtUa0Ji4KY8z9haUL4z36KRMNgLb8rdaWxPR6VUAwlJzBlgM24+BHbtJ03CdIH2hAo13JPZP 5S1yvhVlsMTaeH7DQovvz91McoZbgNOXcNQX6r/2QrhaYx6R7bdpPFClHN3DeE8Ga6IyKS1+ARm yYi+w29SZWs0XHLLYD+z8JcH7LIaqdi554FTfXgZquk+w9zo3Fpq5/PXUngkz1Pni8XO5D+f7QB S+aVa9xoBVJfQELy7ZAgKdOmotdboajU2h0IM+NpwfjKkjaXxwHo9ksqXFNFylRJUEYLIjC3Hr/ 7SC2V59XT8Wc4uNgjpw== X-Proofpoint-GUID: ltfGXE6shzJzvE8cF9Aof2et0_V3PZ_1 X-Authority-Analysis: v=2.4 cv=cefiaHDM c=1 sm=1 tr=0 ts=6a425532 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=zNzZX6S8Ja6Y3dQqPR0A:9 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-ORIG-GUID: ltfGXE6shzJzvE8cF9Aof2et0_V3PZ_1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290092 On 6/29/26 11:16 AM, Anvesh Jain P wrote: > Each fan is registered as a thermal cooling device using > devm_thermal_of_cooling_device_register(). When the thermal core gained > cooling device ID support, the helper's prototype changed: its second > argument became a 'u32 cdev_id' and its third a 'const char *type', > replacing the previous 'struct device_node *np'. > > The resulting semantic conflict between the EC driver and the reworked > thermal helper was resolved while merging the drivers-x86 tree into > linux-next by passing NULL as the 'type' argument, dropping the per-fan > 'name' string. As a result every fan is registered as a cooling device > with an empty name. > > Pass 'name' as the 'type' argument so the cooling devices are registered > with their intended "qcom_ec_fan_" names. > > Fixes: 5c44f48e91de ("platform: arm64: Add driver for EC found on Qualcomm reference devices") > Signed-off-by: Anvesh Jain P > --- > drivers/platform/arm64/qcom-hamoa-ec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/arm64/qcom-hamoa-ec.c b/drivers/platform/arm64/qcom-hamoa-ec.c > index 45829f2786b7..12196d56b60e 100644 > --- a/drivers/platform/arm64/qcom-hamoa-ec.c > +++ b/drivers/platform/arm64/qcom-hamoa-ec.c > @@ -391,7 +391,7 @@ static int qcom_ec_probe(struct i2c_client *client) > ec_cdev->fan_id = i + 1; > ec_cdev->parent_dev = dev; > > - ec_cdev->cdev = devm_thermal_of_cooling_device_register(dev, 0, NULL, ec_cdev, This seems to have been altered to use: devm_thermal_of_child_cooling_device_register() apparently as part of: f31c00c377cc ("Merge tag 'platform-drivers-x86-v7.2-1' of git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86") Konrad