From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2843AC46467 for ; Thu, 5 Jan 2023 01:42:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229614AbjAEBmc (ORCPT ); Wed, 4 Jan 2023 20:42:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229682AbjAEBmN (ORCPT ); Wed, 4 Jan 2023 20:42:13 -0500 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25B4E2F7AF for ; Wed, 4 Jan 2023 17:42:12 -0800 (PST) Received: by mail-pf1-x42f.google.com with SMTP id c9so19403287pfj.5 for ; Wed, 04 Jan 2023 17:42:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=hUrfx5rymV6PAvjGCkeIctTq/mmMCexOy9WfgvwN1Yg=; b=gtIa7MIVyvGMax/CEKEhY/D/ZiZmkvm0uNj297J+blrWhmKvjxfJHG5Z9jXEgIskts vz5mkXbYrV0lJmBZyLTFXFwiy2ejJ/J5kDvGMOUWFX1/5Qe7AlBMf1APcdunfrDmOEg4 qHXsClzZuMiG0/tLMAdJ/P9truPq8u9PHcMNNfZlj2VfUmP031eOYYftEy66RZs1Kgy3 Jhmobu5DaESqXDtE0MBS35YlBisuDInr8UYg4CQVnPppDXtRcoDoDwYs95jkyROk/ck1 DhixM7ZZmxeNrr81wZCxSjmH0mkBiZMFmQBa8EEObfKklE5YByuPDr6Hh1f9luh8a4d1 3KsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hUrfx5rymV6PAvjGCkeIctTq/mmMCexOy9WfgvwN1Yg=; b=mgMSQRVmfPJmEjvt5u9X2vhiSJCvCaj3r1U8rGNiRjRQLF8K5GQMd/7IcaACFAGCW+ 09FsRTawxqhuH1d5G8i/VJFMk+4rGTp9JrTrbc0Xbjf4xjC57Eku8FEUdtpWic9OC51H xsBcDFLy/bGuY95fQBm9SLX0S5u9x0yNnDnYffwX6Dla4ySAR041Keje+p8qiLvDtacQ WwK4UdQqiSdQP5tdCNriAHt1l1NxjRF6q8YNsooHXjDbvR4DHW65KrPHFNiAzcH8Qd+3 /sm2eZQTWWS1KFlk7OAUjSsDPJgyM16BdQJRNsgEV4+6+psdETYl2ssc7nA1WeUfzCK9 BRMA== X-Gm-Message-State: AFqh2kpD4inSAqmpcV1QseCDqZW9GHe8aAgtJ2ECA9KNTeycxtUBo01c 8lDNEZFyskFrn1+7CjHfILLhkQ== X-Google-Smtp-Source: AMrXdXuvgTarXCqrA23rBkL31VEvzXqUxRYkMRYM1V7m9460cS0WvKQF9e6nBxAyfny75qm+ijKFKg== X-Received: by 2002:a62:e413:0:b0:582:13b5:d735 with SMTP id r19-20020a62e413000000b0058213b5d735mr62623pfh.0.1672882931539; Wed, 04 Jan 2023 17:42:11 -0800 (PST) Received: from [2620:15c:29:203:fc97:724c:15bb:25c7] ([2620:15c:29:203:fc97:724c:15bb:25c7]) by smtp.gmail.com with ESMTPSA id p5-20020a622905000000b005749f5d9d07sm23726355pfp.99.2023.01.04.17.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Jan 2023 17:42:10 -0800 (PST) Date: Wed, 4 Jan 2023 17:42:10 -0800 (PST) From: David Rientjes To: Feng Tang cc: Andrew Morton , Vlastimil Babka , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Konovalov , Dmitry Vyukov , Andrey Ryabinin , Alexander Potapenko , Vincenzo Frascino , linux-mm@kvack.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [Patch v3 -mm 2/2] mm/kasan: simplify and refine kasan_cache code In-Reply-To: <20230104060605.930910-2-feng.tang@intel.com> Message-ID: References: <20230104060605.930910-1-feng.tang@intel.com> <20230104060605.930910-2-feng.tang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Jan 2023, Feng Tang wrote: > struct 'kasan_cache' has a member 'is_kmalloc' indicating whether > its host kmem_cache is a kmalloc cache. With newly introduced > is_kmalloc_cache() helper, 'is_kmalloc' and its related function can > be replaced and removed. > > Also 'kasan_cache' is only needed by KASAN generic mode, and not by > SW/HW tag modes, so refine its protection macro accordingly, suggested > by Andrey Konoval. > > Signed-off-by: Feng Tang > Reviewed-by: Andrey Konovalov Acked-by: David Rientjes