From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D4602063D9 for ; Fri, 10 Jan 2025 08:14:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736496895; cv=none; b=VnwnD8e7ChV2CNsJFHkPa/+MO0ooyrCv3KH5d5TNiD48X6mPLMtwY7yAas/QI1Md9ZiNL9HGgJARbZloBvYMTNvVczlNntZD63TviLUg+gedQyEjiLkyoNmxCYdaTbqlrcdNKRMl5p/ru1LI3HUXq1S639edZ0YQxqWvqEtcigM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736496895; c=relaxed/simple; bh=ENA1ym649Hr7Px2CFz5nsfUFC3EVcre6p4PtM4Xu0cM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nZJOmmDJHi6rVVRps98mVgLT/+ZuFgUF0vuNupcXjuk+XiwFwPIY2sddwx3aBYqx3vlF9zEcWkCX/eXpvdNg9yKdVY647C0B+pZ2rtk7+IeDtnxPIt4GzlbNxOlW6tJOBR2WDrUWUgzW3BvIlAvKLTBKPXgBKh4kZ8aCZv1n6mY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=MLjfVgb0; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MLjfVgb0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736496892; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=byJiHXajGWib5D6AAppEFYrozYieWdJ98xjWWQFd7Vg=; b=MLjfVgb0ee4KMFsDQtifF+SSz8ZWGFioQ5ZLleR4UFClwysvp0eKZiJLvuZuEgTv2BH1N3 an73D5D9BiZ7ZjwYh4HoewC2jArjBRDUptjvN8rxXhkAisHUC6Kqko6Nt4eJ7r/PenoBD1 bBzPif83V2vrndCUuVJJnHERUhGNTXs= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-171-Ll7J1z_aNNe7gHl6968ymg-1; Fri, 10 Jan 2025 03:14:50 -0500 X-MC-Unique: Ll7J1z_aNNe7gHl6968ymg-1 X-Mimecast-MFC-AGG-ID: Ll7J1z_aNNe7gHl6968ymg Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43635895374so12573385e9.0 for ; Fri, 10 Jan 2025 00:14:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736496890; x=1737101690; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=byJiHXajGWib5D6AAppEFYrozYieWdJ98xjWWQFd7Vg=; b=drXOgtqoS0vOBptfMoNRyDRjJgU0KI3k1j8QS2pYXobjFnNs8eth2yOTTGfL2+cSt2 oLjRUerE6IIYE0rDzBJVqMWhfxY2yCvCZMNvZni0cfjSbbuGDSZGkjhS3aI+Cx1D80O0 aYWMCZqH7IE2s9BdXt0M7FIc/aytDbYb0I052mT53kg2Jpu10SA98Q+O9yi7mIr/AD7I iG7Hoko43g4sh5QFdUo1PL8nzhonaXoJHOAbZNzZ4c4ZWD9wVr+Ia8TsZ4JHayYT5CwG 6IJqGXM54FiIxAyXQP46oH6dSLz5SGPjNZv6I0HqDhz0x5Q38NZtRf52t0dZbmIM8/47 hO1A== X-Forwarded-Encrypted: i=1; AJvYcCXBx642HaAhiTqZMH213QSaWH2oLsebYpTLkBlx52HPWBInswjyZpOixP0cVIF0a98dOnWOmp4d+MFsKg4=@vger.kernel.org X-Gm-Message-State: AOJu0YyvlBQWZ+CNpTthXxQjOK/eeZgF7i+jXKsCcK7CT/v3z5hgKM/V EkROH2XxPEqMn9CklEFEd9fhhQyHb/I4LQjZQnd/xoiEmKn+JkdCzIE8mPhXaj9wHTVVRHV86DP W4GnOGKXkO1dSWQMp/Vla92eAdHyJ2PwGU471VlQLpiKRFrpMdrktjd4naegOEg== X-Gm-Gg: ASbGncuEwH9P5Gi6J5qq1yq/q1sM3fxXp0axvNanMqf4Z0tlvCkVJUccIFt2u6RDPrw 6oSc6dbeugE5Rj7ajgdNlyq+A13ykYJKaaNT0/dgRwF0QzekOT1VSTVe+SZ8wJ5lRmQxB2uHmO4 ELYbqXw+uCfAriUKkeitFSn9V3jc5lMDNJxutpnDmNVosZpYkhOIiIrv5Iu5uZzq0Bw4xamcVbc nqjg6Q6eLoWv07Zjl14b8CHhXu/PPyjGigQVCNt0ogITmke6k3s6Yz/Qh8LSQHmxnlSP5FeL579 EB7NV2siV4PTYKnXWBjEMduA9xf4CbSUnF2VXzwAzedJcZu5Gwva/ztj0ftvalYTKOp0YgoTphU a9XPp7ZWj X-Received: by 2002:a05:600c:492f:b0:434:ea1a:e30c with SMTP id 5b1f17b1804b1-436e8849debmr55169985e9.13.1736496889697; Fri, 10 Jan 2025 00:14:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IHu2/KWZJXePrGJBskpcIH5RpS86fIWOpZfXtRTHQL6uqKyKXRl8gbefOgzFv2pGsK+AJr+FA== X-Received: by 2002:a05:600c:492f:b0:434:ea1a:e30c with SMTP id 5b1f17b1804b1-436e8849debmr55169755e9.13.1736496889279; Fri, 10 Jan 2025 00:14:49 -0800 (PST) Received: from ?IPV6:2003:cb:c708:e100:4f41:ff29:a59f:8c7a? (p200300cbc708e1004f41ff29a59f8c7a.dip0.t-ipconnect.de. [2003:cb:c708:e100:4f41:ff29:a59f:8c7a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9df958dsm44247475e9.17.2025.01.10.00.14.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jan 2025 00:14:48 -0800 (PST) Message-ID: Date: Fri, 10 Jan 2025 09:14:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hugetlb: prevent reuse of isolated free hugepages To: yangge1116@126.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, liuzixing@hygon.cn References: <1736477766-23525-1-git-send-email-yangge1116@126.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <1736477766-23525-1-git-send-email-yangge1116@126.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10.01.25 03:56, yangge1116@126.com wrote: > From: yangge > > When there are free hugetlb folios in the hugetlb pool, during the > migration of in-use hugetlb folios, new folios is allocated from > the free hugetlb pool. After the migration is completed, the old > folios are released back to the free hugetlb pool. However, after > the old folios are released to the free hugetlb pool, they may be > reallocated. When replace_free_hugepage_folios() is executed later, > it cannot release these old folios back to the buddy system. > > As discussed with David in [1], when alloc_contig_range() is used > to migrate multiple in-use hugetlb pages, it can lead to the issue > described above. For example: > > [huge 0] [huge 1] > > To migrate huge 0, we obtain huge x from the pool. After the migration > is completed, we return the now-freed huge 0 back to the pool. When > it's time to migrate huge 1, we can simply reuse the now-freed huge 0 > from the pool. As a result, when replace_free_hugepage_folios() is > executed, it cannot release huge 0 back to the buddy system. > > To slove the proble above, we should prevent reuse of isolated free > hugepages. s/slove/solve/ s/proble/problem/ > > Link: https://lore.kernel.org/lkml/1734503588-16254-1-git-send-email-yangge1116@126.com/ > Fixes: 08d312ee4c0a ("mm: replace free hugepage folios after migration") The commit id is not stable yet. $ git tag --contains 08d312ee4c0a mm-everything-2025-01-09-06-44 next-20250110 We should squash this into the original fix. Can you resend the whole thing and merge the patch descriptions? > Signed-off-by: yangge > --- > mm/hugetlb.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 9a55960..e5f9999 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -48,6 +48,7 @@ > #include > #include "internal.h" > #include "hugetlb_vmemmap.h" > +#include > > int hugetlb_max_hstate __read_mostly; > unsigned int default_hstate_idx; > @@ -1273,6 +1274,9 @@ static struct folio *dequeue_hugetlb_folio_node_exact(struct hstate *h, > if (folio_test_hwpoison(folio)) > continue; > > + if (is_migrate_isolate_page(&folio->page)) > + continue; > + > list_move(&folio->lru, &h->hugepage_activelist); > folio_ref_unfreeze(folio, 1); > folio_clear_hugetlb_freed(folio); Sorry for not getting back to your previous mail, this week was a bit crazy. This will work reliably if the huge page does not span more than a single page block. Assuming it would span multiple ones, we might have only isolated the last etc. pageblock. For the common cases it might do, but not for all cases unfortunately (especially not gigantic pages, but I recall we skip them during alloc_contig_pages(); I recall some oddities on ppc even without gigantic pages involved). One option would be to stare at all involved pageblocks, although a bit nasty ... let me think about this. -- Cheers, David / dhildenb