From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1108836F418 for ; Tue, 23 Jun 2026 10:09:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782209370; cv=none; b=pEXBqfIYesopZC+kloKPfh1tZXHXbPBjpqzfSZUtW89BD2jHImeF6Oj2QXN606rn+huyHrbrp5iTvvSOIe2D2HVElUY8Utg9+8zbZ1Ia/O9fCuvt1WL9Ma1WJzk+HbixZFllBMQ3kAETWCEnNKCF29/3gbFYdlg0JLFaD2t9Eto= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782209370; c=relaxed/simple; bh=X9DXsCXcUguRFcOH02yhbRkuiA4xQ2ZmmuhftcgWaI0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dRh8bl4ugv+8TwXJ5FcL5uMYkmi5cA63hhLb03lkCFriaiT8RBTS0f1N34mch7QMSkB8YTvtvY2Y7H1C7q4uVCFO1RYa5gJBwbXHRb96BhU4LN1k46LyJMXPC8VBJHPHMIBYd7c66Q2vYUHABTFhB0Jg23u3lU3Q65RVZ5ih30g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kzN5Bekh; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=c2Ek287N; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kzN5Bekh"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="c2Ek287N" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65N9KRYq3918942 for ; Tue, 23 Jun 2026 10:09:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= X9DXsCXcUguRFcOH02yhbRkuiA4xQ2ZmmuhftcgWaI0=; b=kzN5BekhgGjAn8ET WsiycQsJwo6YyEJJR8hoMHYYu2W+mFQQq7+gJ94yQrMCIHDn/zIqSALJu2hodo4F rCFpFc4mb8xSMijRZxAjW8JcyXSg3PriOLr6K8owObFrcCck37bRZPoM6HrjT6vi 0SRM2Pg1bvdehbEDI96XtAgPtPw+QV2MktYNz8jnp9YDrXLrOGjMkBX9rZ54Fn2H lPd6IPYAqsW/4W77flM7RiSTleVVjagLPYweX9B7PnTBZGFNuI4ltcjzhBxEcBUo ZSArF+j6U2fKB3kjR8P/MgK7KIgyqFn3rP1HR0LRHil1clkPB+8P/Rhc4g8FOVTE lWDzww== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyqe688em-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 10:09:27 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8423ef9d3d0so1460719b3a.0 for ; Tue, 23 Jun 2026 03:09:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782209367; x=1782814167; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=X9DXsCXcUguRFcOH02yhbRkuiA4xQ2ZmmuhftcgWaI0=; b=c2Ek287ND/30CrXF2hJuY9rQL5vKihZLDrW0S2O08quLqOk/bQfOx1isPkuQgyfZLh K/7z6+9aoO4nSpD5EwJjAtAe6fHPiR/yAtNf1DckAKjuDB8DDtYFXjswfzJ3mPWHinMg +Vqvtqa8/VEfLxuehN/ZrnKERgVlnxVxbzDDDMR4Mm++BRJLnxQB+VPxiAAJeqYrS9WG TWkQl/PR/T3fP89KrqTVSPVcjXiHlaMbX6KgxP8exOS4XuIiRkglcURJxRNSd1odmC0i hllzCQZDy04m7yb+aUAgURSYelaAiNJ46YwMbHYZ2mDTwk7xPmZ7kPv3dd3UKG9+452L sOVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782209367; x=1782814167; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=X9DXsCXcUguRFcOH02yhbRkuiA4xQ2ZmmuhftcgWaI0=; b=i/2ex5rNZzO+Wz/FGohh8B5dmIaD+TwGxZaX0yrcgIRoCtyBAP0LfqOasJqd4nS2vT RVz2ymI/Ki0WDD1tjTvOXZXLZd7VhmAav1zJOa+XuFpoS/PGn9GgttNw10y3jSokW2Fd 88rAIcXashYluAhluVlF1vHAJmSb4KlamMp+eodkH3iEBOrtfHSRVgNwe7cQSrkCtI66 OHVKQOic18tDKi+GhVBdJRPcWwJ/nYov79Z18kTyuNrklOmjhUxvml+70YysGebNfYSW qe5ypVlC2zNraGhNXuRQmbvs7ki05eZGdEPROl9wkR1cPC20y/7oR3Kz9fcQpuu4uwSu Yq9Q== X-Forwarded-Encrypted: i=1; AFNElJ+VcFVl47QHDQqVOEE02iHVsfYZ8tr+6MW5m84eZDvNkLGQbyDZAVLRfY7acChSSMUcW4g6swtUHV5xIhU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8F8jlMTO9cpqRgDCiLbjt2rQTj1LiexykKHv1ADKeaVe3xp7N uaNjR5qgG4/G0SFiPyqn++RE0PLjQ/aK5hEcxkk7PGcBpSdwLOOXSYQROE1lrLl48Dh2u7htTrd vCIcqP/4E4MvYlf4kcpsZD1+tW8qe/SOfpfRd+LIseUN4HWEJCgCPCUeZTC9fovr7ufM= X-Gm-Gg: AfdE7cnn5CthuDHTMeQo74eDl6bDyYHXtAkOx6Fz+3TtnqX2TZn2yAagWO6haIgLqj3 apgn0AF4MB/3z8NQWkOuElh8pfY1+THJea+Dylxr2IirOCJV3OiHPWj+i2AxspRGCSC8T9r1xjT SuZfMabfNIr92KjLLfhA1WWUWxLSr2q5UiLu3T/PZZehL1b08SEded4qq+penUOsrZFbUN3qBd6 GvRi/d2jlnPB/CyiOX2PT8In1YbV5s9rUUor+rkIdp6BUzd1JelNQbyWmCilqEUBEgg4LaI307K xeg71vS7hxasSss/6Y/TGIL1a8w9xO86AW+/Z2nm4jzmLC5lp/TKKwl0hE4vgVZp4qT571VorIv 6FDILYbela/mHIZ4wQXSdAtx1D+aE5ws+Peeq7qjVKjBpLlclaJ5lANNFnlul58tt9vsDkEZdtD xjqg== X-Received: by 2002:a05:6a00:2349:b0:842:3be7:4d56 with SMTP id d2e1a72fcca58-8458f1da7ddmr2344675b3a.2.1782209366854; Tue, 23 Jun 2026 03:09:26 -0700 (PDT) X-Received: by 2002:a05:6a00:2349:b0:842:3be7:4d56 with SMTP id d2e1a72fcca58-8458f1da7ddmr2344647b3a.2.1782209366278; Tue, 23 Jun 2026 03:09:26 -0700 (PDT) Received: from [10.133.33.161] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564d68edasm9701039b3a.1.2026.06.23.03.09.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 03:09:25 -0700 (PDT) Message-ID: Date: Tue, 23 Jun 2026 18:09:21 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/13] Bluetooth: btusb: Move struct btusb_data and macros into btusb.h To: Bartosz Golaszewski Cc: Zijun Hu , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Luiz Augusto von Dentz , linux-arm-msm@vger.kernel.org, Marcel Holtmann , Luiz Augusto von Dentz , Rocky Liao , Ben Young Tae Kim , Balakrishna Godavarthi , Matthias Kaehlcke References: <20260622-bt_bugfix-v1-0-11f936d84e72@oss.qualcomm.com> <20260622-bt_bugfix-v1-11-11f936d84e72@oss.qualcomm.com> Content-Language: en-US From: Zijun Hu In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: kx9Pq2XQomSfDyzs6ywUdrQsNFacaDr0 X-Proofpoint-ORIG-GUID: kx9Pq2XQomSfDyzs6ywUdrQsNFacaDr0 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA4MiBTYWx0ZWRfXzfO/Lk5O09fa AgzWiVAwuVs2mXxxFQjC5E3yAoEqJDHhK022Ev5kU0rv/v5qDYPUeS+elFf5boZsb7lbStUoIbL 2MdUyPhBbVLpjGH5Y3qqt3K8KRyXMec= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA4MiBTYWx0ZWRfXxPmt3bnGVyuG 61FkWkadWMgPkTfAWx4KwqCz+1mTrsob70lCz2KFhjgvf6ZCjsUATTiDsYmIanBdKQ8BwWN/80g 8I6QUFghq0sEC6Y/Ln6eUYWY97HQOKULg7xmn/pjjvtV6jGS2MHeZn/3JKq6/ICsy9js9pwIwBO YQJZPGkIBOMbhSWbTlyAfe6pEfFhXv24HgHYwECCracbCkmWI7Rmk2MlKbJDnfWf7ucVs/ZGEDl jMR6OJ1SdBFcjoWuJmJT41Y84fI10fXKTOptaAKIv3v54Y1g8U+V6Wxt2DrNGwOwmb2vimdm62p dgVjlpKEv7BPCo08C0D7K3GhKRy5XgCMwisOq07+ySzFtHM9C/6tZpCpRJngfBhVNSDZjQKo63E A8X8RpxLwB/gvAfLnIvIy0NSMN4XuRjuhEvEt6csUN32wbm1WPAst5KN3WvOOQbZLfrIvda+nPd 3VPmgk1P0tA/tr7iKKQ== X-Authority-Analysis: v=2.4 cv=OeKoyBTY c=1 sm=1 tr=0 ts=6a3a5b57 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=EUspDBNiAAAA:8 a=7d7NGZtOMGS5_dLLPmkA:9 a=QEXdDO2ut3YA:10 a=ZXulRonScM0A:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_02,2026-06-22_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230082 On 6/23/2026 5:02 PM, Bartosz Golaszewski wrote: > On Mon, 22 Jun 2026 16:52:24 +0200, Zijun Hu said: >> btusb.c is growing large as vendor-specific code accumulates. Ideally, >> btusb.c contains only the default implementation while vendor-specific >> code lives in separate files for easier maintenance. >> >> The newly added btusb.h also reduces unnecessary data copies in hooks >> like btusb_mtk_setup(). >> >> Signed-off-by: Zijun Hu >> --- > I would be ok with this if you added a user of this new header in the subsequent > patches but I don't see these so I'll hold off my R-b until you can show the > need for one. Right. Will drop this patch in v2 and bring it back together with its user when necessary.