mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Christian <servidorjarvis1@gmail.com>
Cc: dave.hansen@linux.intel.com, luto@kernel.org,
	peterz@infradead.org, tglx@kernel.org, mingo@redhat.com,
	bp@alien8.de, x86@kernel.org, hpa@zytor.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] x86/mm/pat: HIGHMEM pages in set_pages_array_*()
Date: Fri, 20 Nov 2026 07:13:59 -0800	[thread overview]
Message-ID: <b0db3d3a-4715-4a07-9532-d07ffbf3bada@intel.com> (raw)
In-Reply-To: <CAMas6S2OpEag7VQAtHaFrho8VF883+EpL9XpO_sTV=ZLpmDJsA@mail.gmail.com>

On 11/19/26 23:50, Christian wrote:
> On 11/19/26 11:45, Dave Hansen wrote:
>> Reproduce upstream and we'll talk.
> vgem does it. It keeps its buffers in shmem pages (GFP_HIGHUSER) and sets
> map_wc, so on x86 mmap() reaches set_pages_array_wc() through
> drm_gem_shmem_get_pages_locked(). On i386 without PAE, once RAM is above
> lowmem, those pages are HIGHMEM.

I congratulate your LLM and mourn the tokens that were sacrificed for this.

I'll say, though, for something this obscure, I really need to be
convinced that it's not going to regress anything. I also want to know
that you'll be around to help us fix this if you break something.

Please spend some time on the changelogs and please do double-check that
there wasn't a better way to have done this. Human, please. No LLMs.

  reply	other threads:[~2026-11-20 15:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  9:49 Christian
2026-11-17  9:49 ` [PATCH 1/2] x86/mm/pat: skip HIGHMEM pages in a page array Christian
2026-11-17  9:49 ` [PATCH 2/2] x86/mm/pat: track the memory type of " Christian
2026-11-19 19:45 ` [PATCH 0/2] x86/mm/pat: HIGHMEM pages in set_pages_array_*() Dave Hansen
2026-11-20  7:50   ` Christian
2026-11-20 15:13     ` Dave Hansen [this message]
2026-11-20 16:45       ` Christian
2026-11-20 17:04         ` Dave Hansen
2026-11-20 17:07           ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0db3d3a-4715-4a07-9532-d07ffbf3bada@intel.com \
    --to=dave.hansen@intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=servidorjarvis1@gmail.com \
    --cc=tglx@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®