From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 482241F76C7 for ; Wed, 8 Jan 2025 11:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736334777; cv=none; b=HLDo6byPquvnW5JwPW2MqbpTYZwf5mdoUTctiLEaD1eLo81dSfKdebGufhybFWVdt6tlx7oFoDVtAo7eWYq7M28/ZvS38pk7e88e1+Nygz2h41C9YD3CuzJZOheBIeRjyE0+m/pkhN5dSz4cyRPDeCn3neMh0JpFzt0sGskYqn0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736334777; c=relaxed/simple; bh=HZCEetwRael+dNFw4oLqL99vRLgbXiFXWkjfYlHHQBI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Kk5Oozlq4fmp/+RUog3ewsZ3HsWrH9sD+KLXlcB550ZKaZ5BtkJmGRXpXd9sxglbl7X2TBRRHlEsvaZAhp+wUoV4ksJFbZx0KiJmIGj6A2SPMH7DyRJHecXf5maTbdpRyqaLmGOqBoJgFh9m3GUoQawcVUWMezeUf15fK22W6nQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YwUMXpXy; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YwUMXpXy" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43616c12d72so25961235e9.2 for ; Wed, 08 Jan 2025 03:12:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736334773; x=1736939573; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=E8p18qN2yYH0mtoCqB/wWFUlUmYpYcguuGr2FBn7gA0=; b=YwUMXpXyMvzRZtUaTIGmbuuWDF5maSDs/iuvFJvWRgTihmoOA5zUhQM3wj5QasxNRx 361iTuh7piJZksNc+nVQHJi6Gr5sP0TOQrtYh2+YgfYqdXli3M1aQC54JM10Q5kYZahs HSq27GebHa++gdH2oHf74ELY7ik2IX+nUu/f6gvVYOXggToMsQef8kI2x/OVADeqi58a 4ZL3aZfIkm+p9h7alUH1CFyemwZWAJVcu1xdMbO/wIDpeeGQXdpIDGGS+2r4VeiCcd8Y HiGnEb7pU6ogINRhkU9aiptMBq3FjU1BNiFvt4WBPCxl4ZmCF5Gx6gE13sv7YkSxj4bd RyhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736334773; x=1736939573; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E8p18qN2yYH0mtoCqB/wWFUlUmYpYcguuGr2FBn7gA0=; b=Pakm6aenu5sX/Fnho4IFgaYz2/bQpoCTQog7VWQCY3Bulz1TC8DT279Xf9hA5OlJuc +YJjPi+Rg7/0larmFqK4rpDIy/B11mlRMQM8I6EAqmVIjUdGp92Z7UDX9uFlurjNn+CL T4thG0T2DS/sVtBDBfn9MeGWWz627tynSRfMrPhXS3WHBkEBuhFg7icJ7qJQJ20jXDqy y4ahEPHb6ttd57XYr9wqBVxC0fO62ydS5LwVxjG9bhOrmLueVtHirQra8CcoXdl5dLhq w06hpdST42FdzYrEksMtvQ4Udr3W2TtkbRNBg07eOaxXvh+4iyr71FKxIpN+uE0sOVVp Z5cw== X-Forwarded-Encrypted: i=1; AJvYcCWF1BieOmHkciJIhuTy18UdqVVcD8g2dm9GLZDt6CjrQJVZf+5zhdc9Orcvow9R8StOfOWpAfMVNHDVDi8=@vger.kernel.org X-Gm-Message-State: AOJu0YxGpjVBKWUtXo1rea4vaMcWHLUwopV0FTrF3VicKQFwb65RY0sb WKugaz7sBIk+PrEmdM3mxrZMPQaSqPnRt2PpZC1EgObxi2EF/OBkFrY3O4JgtK0= X-Gm-Gg: ASbGnctzhrdLZsrJLU9RYnP9WZUh7qGMQuPFY1GS+w1KPyfEKvMBcjxljTzgqdVN4VB cVTn2gsZg47/0GjpswIcA3MJWZwmYxpcq4RViiHM2eUATZS8/NoJYPR4r4nxuFL2CfKSxLw3QC6 KiLzIkE67Q+c341PiUhzCwyxAIuiISSE3FYGcR1fVwbbE4FoLN6iMO0iQfEqodZW2uiEO3vKshY xZ/zmbGxq7IvEjVUxOwZPN3uDs/XJ/slfWeyXidU1B/cxKk8NU9wAcHD0E35/bCrzEB2PoheOB1 X-Google-Smtp-Source: AGHT+IEM8rCW3UPYD3EciO4Pw5JPCX65SyzCXXRo5TKTJ3xOV+GtrweZsjR4+WVhxiNLpjsRHOd46A== X-Received: by 2002:a05:6000:2ad:b0:385:e374:bd4 with SMTP id ffacd0b85a97d-38a872c7de7mr811485f8f.3.1736334773568; Wed, 08 Jan 2025 03:12:53 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.165]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e2e96365sm17090145e9.43.2025.01.08.03.12.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2025 03:12:52 -0800 (PST) Message-ID: Date: Wed, 8 Jan 2025 12:12:51 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] firmware: qcom: scm: Handle various probe ordering for qcom_scm_assign_mem() To: Bjorn Andersson Cc: Konrad Dybcio , Mukesh Ojha , Dmitry Baryshkov , Stephan Gerhold , Bartosz Golaszewski , Kuldeep Singh , Elliot Berman , Andrew Halaney , Avaneesh Kumar Dwivedi , Andy Gross , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241209-qcom-scm-missing-barriers-and-all-sort-of-srap-v2-0-9061013c8d92@linaro.org> <20241209-qcom-scm-missing-barriers-and-all-sort-of-srap-v2-3-9061013c8d92@linaro.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/01/2025 01:42, Bjorn Andersson wrote: >> >> diff --git a/drivers/firmware/qcom/qcom_scm.c b/drivers/firmware/qcom/qcom_scm.c >> index 5d91b8e22844608f35432f1ba9c08d477d4ff762..93212c8f20ad65ecc44804b00f4b93e3eaaf8d95 100644 >> --- a/drivers/firmware/qcom/qcom_scm.c >> +++ b/drivers/firmware/qcom/qcom_scm.c >> @@ -1075,6 +1075,9 @@ int qcom_scm_assign_mem(phys_addr_t mem_addr, size_t mem_sz, >> int ret, i, b; >> u64 srcvm_bits = *srcvm; >> >> + if (!qcom_scm_is_available()) >> + return -EPROBE_DEFER; > > This API is generally called from places other than probe, making the > return of EPROBE_DEFER undesirable. While not pretty, a client depending > on the scm driver to be probed is expected to call > qcom_scm_is_available(). > > qcom_rmtfs_mem_probe() does this right before calling > qcom_scm_assign_mem(), am I misunderstanding the case you're describing? I tried to reproduce my NULL ptr but now I cannot and indeed if every path is protected with qcom_scm_is_available() everything should be fine. Let's skip this patch then. Best regards, Krzysztof