From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A7F819E7DF for ; Tue, 27 Aug 2024 14:02:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724767327; cv=none; b=JcXx/pSTqo9R+9H7Lld/lOrQOnu2VIBYBJZ+l9T0Myq/ZGydZGqrzuXWJQJTb0W3FcnynDSJMZCQGORf2TWtVCIeWuwdmYMS4fCXD+FWPKF3aTKMGgkpND8du5HSLWiu94LaviuhYQmsRUh40ZqbICQFUH+hN3jb0gw+lwRXImc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724767327; c=relaxed/simple; bh=C6iFX0aXcj78TirlN31vh53+J8GSUBwWtLTvLK5iQPM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dol9vubn1Mv0MpBDIfn4SMnlnC1DbR/2sPiJJv+8MjNGoI5X0vI8g9Jrc7Cnt4/uTbJJJP7oHLkyH3/cvRTwHNhqDWF6QbSE5A1dFWgC/I0Z9rSPf21ht1/bsstxmiYRSB9silfWUBMiVtd2EZK6jz8DEmdtYdNpUurmOLPg2EQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RWQKhuOX; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RWQKhuOX" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-201cd78c6a3so38198285ad.1 for ; Tue, 27 Aug 2024 07:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724767325; x=1725372125; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=3p4NnYVeOnluGmhbtLMDsGXW1KzaGw5CvuSgIqbvMIk=; b=RWQKhuOXmAHfBBEmzAtv743oG+mEbyMgNVw7dqW/eWIMX8gwOkTK9hNPVzzH2lxYGq 800vl5GAbD2TeSX6+aqPKc86R52FCCgRb9Jr5pl5AMLZQPar9nEmNft6iPwnHRW4bCwG lM8YQg/E+QTkIsovQJgckfh/kAZ6N36TFIJPaOmpYAtzWSw18EMvC/CZXRIXRkvYqXvq DiSOLxa34b05uwjFlFkPHerW3RDQMmcnxCcJ2dpPh+uqMbiDGpMPW7c+D7uoHx7vILu9 xMoJy7hQSIcQ97s1RRN5ObwKQgQMsA1dqOcf+YrImiHolvo/sclYRz5NgMMS8dX53oG5 ogMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724767325; x=1725372125; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3p4NnYVeOnluGmhbtLMDsGXW1KzaGw5CvuSgIqbvMIk=; b=pQi4txRlZILa//aFBwIyVckefjsup+/tJJfnSIJiXLP1SgBft/Ik/AXrcDT+f5KSnG cpNJn67Ci0DkgmTdrJzo7Jgfu3WQGeOarQRj/aN2/pQHCO90/vDsE1KONh51lJTcE+Ik 5xZhS2BMt/KYfwUQZH60YIy4556mNUpvUceXJdxikM8EydAoW9dejyD+uGw3OR/ZRu3S n9kCWUQgpeE4uuKKQk/PGuJ+YP/x/nghhCoMNJmMYedOPtWJ1ncmWBbyRwCr7QEgWqJs 9hZaZw5gXkjprJInuL943k+u9O518A+yGvqU/jZA/0sStvvMXBou6uYjYCK3Oivkfm7h n7bg== X-Forwarded-Encrypted: i=1; AJvYcCUEwOGOHvBxIKu9Q9Lz5ki02MAVXg/pQghIddFAZVQ7wTx8KR3zq5mgMt845cKChXAbYlcom5tWTv3LtxA=@vger.kernel.org X-Gm-Message-State: AOJu0YysUC5xg3vsPNAVg+Bbij9w53Tl3Lvxj8kk5dX2gQ1ejZGVj1kS lwVarGGfRGqDfgBoJNxhXESDmvZ0WbocvP/8h7/oOxAC2btInMdBy+oDm77TojA= X-Google-Smtp-Source: AGHT+IHxBcNP3sycZLQSl4M7lfzM2auX3WSH/WPoXb/Bu79vIi6oWuhOfm86eVlf/AW7jNKvCbMKCA== X-Received: by 2002:a17:902:ceca:b0:201:f83e:c25c with SMTP id d9443c01a7336-204def2d595mr30481415ad.9.1724767324843; Tue, 27 Aug 2024 07:02:04 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c3:4c2c:7d73:fa05:8bad:32cb? ([2804:1b3:a7c3:4c2c:7d73:fa05:8bad:32cb]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-203855dc28bsm83764105ad.133.2024.08.27.07.02.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Aug 2024 07:02:03 -0700 (PDT) Message-ID: Date: Tue, 27 Aug 2024 11:01:59 -0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] aarch64: vdso: Wire up getrandom() vDSO implementation To: Christophe Leroy , "Jason A. Donenfeld" Cc: Theodore Ts'o , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, Catalin Marinas , Will Deacon , Thomas Gleixner , Eric Biggers References: <20240826181059.111536-1-adhemerval.zanella@linaro.org> <907e86f6-c9e8-41b1-9538-b1bb13d481ae@linaro.org> <4d966dc6-655e-4700-bc59-e03693d874cb@csgroup.eu> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <4d966dc6-655e-4700-bc59-e03693d874cb@csgroup.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 27/08/24 11:00, Christophe Leroy wrote: > > > Le 27/08/2024 à 15:39, Adhemerval Zanella Netto a écrit : >> [Vous ne recevez pas souvent de courriers de adhemerval.zanella@linaro.org. Découvrez pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification ] >> >> On 27/08/24 10:34, Jason A. Donenfeld wrote: >>> On Tue, Aug 27, 2024 at 10:17:18AM -0300, Adhemerval Zanella Netto wrote: >>>> >>>> >>>> On 26/08/24 17:27, Jason A. Donenfeld wrote: >>>>> Hi Adhemerval, >>>>> >>>>> Thanks for posting this! Exciting to have it here. >>>>> >>>>> Just some small nits for now: >>>>> >>>>> On Mon, Aug 26, 2024 at 06:10:40PM +0000, Adhemerval Zanella wrote: >>>>>> +static __always_inline ssize_t getrandom_syscall(void *buffer, size_t len, unsigned int flags) >>>>>> +{ >>>>>> +  register long int x8 asm ("x8") = __NR_getrandom; >>>>>> +  register long int x0 asm ("x0") = (long int) buffer; >>>>>> +  register long int x1 asm ("x1") = (long int) len; >>>>>> +  register long int x2 asm ("x2") = (long int) flags; >>>>> >>>>> Usually it's written just as `long` or `unsigned long`, and likewise >>>>> with the cast. Also, no space after the cast. >>>> >>>> Ack. >>>> >>>>> >>>>>> +#define __VDSO_RND_DATA_OFFSET  480 >>>>> >>>>> This is the size of the data currently there? >>>> >>>> Yes, I used the same strategy x86 did. >>>> >>>>> >>>>>>   #include >>>>>>   #include >>>>>>   #include >>>>>> +#include >>>>>> +#include >>>>> >>>>> Possible to keep the asm/ together? >>>> >>>> Ack. >>>> >>>>> >>>>>> + * ARM64 ChaCha20 implementation meant for vDSO.  Produces a given positive >>>>>> + * number of blocks of output with nonnce 0, taking an input key and 8-bytes >>>>> >>>>> nonnce -> nonce >>>> >>>> Ack. >>>> >>>>> >>>>>> -ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) >>>>>> +ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/ -e s/aarch64.*/arm64/) >>>>>>   SODIUM := $(shell pkg-config --libs libsodium 2>/dev/null) >>>>>> >>>>>>   TEST_GEN_PROGS := vdso_test_gettimeofday >>>>>> @@ -11,7 +11,7 @@ ifeq ($(ARCH),$(filter $(ARCH),x86 x86_64)) >>>>>>   TEST_GEN_PROGS += vdso_standalone_test_x86 >>>>>>   endif >>>>>>   TEST_GEN_PROGS += vdso_test_correctness >>>>>> -ifeq ($(uname_M),x86_64) >>>>>> +ifeq ($(uname_M), $(filter x86_64 aarch64, $(uname_M))) >>>>>>   TEST_GEN_PROGS += vdso_test_getrandom >>>>>>   ifneq ($(SODIUM),) >>>>>>   TEST_GEN_PROGS += vdso_test_chacha >>>>> >>>>> You'll need to add the symlink to get the chacha selftest running: >>>>> >>>>>    $ ln -s ../../../arch/arm64/kernel/vdso tools/arch/arm64/vdso >>>>>    $ git add tools/arch/arm64/vdso >>>>> >>>>> Also, can you confirm that the chacha selftest runs and works? >>>> >>>> Yes, last time I has to built it manually since the Makefile machinery seem >>>> to be broken even on x86_64.  In a Ubuntu vm I have: >>>> >>>> tools/testing/selftests/vDSO$ make >>>>    CC       vdso_test_gettimeofday >>>>    CC       vdso_test_getcpu >>>>    CC       vdso_test_abi >>>>    CC       vdso_test_clock_getres >>>>    CC       vdso_standalone_test_x86 >>>>    CC       vdso_test_correctness >>>>    CC       vdso_test_getrandom >>>>    CC       vdso_test_chacha >>>> In file included from /home/azanella/Projects/linux/linux-git/include/linux/limits.h:7, >>>>                   from /usr/include/x86_64-linux-gnu/bits/local_lim.h:38, >>>>                   from /usr/include/x86_64-linux-gnu/bits/posix1_lim.h:161, >>>>                   from /usr/include/limits.h:195, >>>>                   from /usr/lib/gcc/x86_64-linux-gnu/13/include/limits.h:205, >>>>                   from /usr/lib/gcc/x86_64-linux-gnu/13/include/syslimits.h:7, >>>>                   from /usr/lib/gcc/x86_64-linux-gnu/13/include/limits.h:34, >>>>                   from /usr/include/sodium/export.h:7, >>>>                   from /usr/include/sodium/crypto_stream_chacha20.h:14, >>>>                   from vdso_test_chacha.c:6: >>>> /usr/include/x86_64-linux-gnu/bits/xopen_lim.h:99:6: error: missing binary operator before token "(" >>>>     99 | # if INT_MAX == 32767 >>>>        |      ^~~~~~~ >>>> /usr/include/x86_64-linux-gnu/bits/xopen_lim.h:102:7: error: missing binary operator before token "(" >>>>    102 | #  if INT_MAX == 2147483647 >>>>        |       ^~~~~~~ >>>> /usr/include/x86_64-linux-gnu/bits/xopen_lim.h:126:6: error: missing binary operator before token "(" >>>>    126 | # if LONG_MAX == 2147483647 >>>>        |      ^~~~~~~~ >>>> make: *** [../lib.mk:222: /home/azanella/Projects/linux/linux-git/tools/testing/selftests/vDSO/vdso_test_chacha] Error 1 >>> >>> You get that even with the latest random.git? I thought Christophe's >>> patch fixed that, but maybe not and I should just remove the dependency >>> on the sodium header instead. >> >> On x86_64 I tested with Linux master.  With random.git it is a different issue: >> >> linux-git/tools/testing/selftests/vDSO$ make >>    CC       vdso_test_gettimeofday >>    CC       vdso_test_getcpu >>    CC       vdso_test_abi >>    CC       vdso_test_clock_getres >>    CC       vdso_standalone_test_x86 >>    CC       vdso_test_correctness >>    CC       vdso_test_getrandom >>    CC       vdso_test_chacha >> /usr/bin/ld: /tmp/ccKpjnSM.o: in function `main': >> vdso_test_chacha.c:(.text+0x276): undefined reference to `crypto_stream_chacha20' >> collect2: error: ld returned 1 exit status >> >> If I move -lsodium to the end of the compiler command it works. >> >> > > Try a "make clean" maybe ? > > I have Fedora 38 and no build problem with latest random tree: > > $ make V=1 > gcc -std=gnu99 -D_GNU_SOURCE=    vdso_test_gettimeofday.c parse_vdso.c -o /home/chleroy/linux-powerpc/tools/testing/selftests/vDSO/vdso_test_gettimeofday > gcc -std=gnu99 -D_GNU_SOURCE=    vdso_test_getcpu.c parse_vdso.c  -o /home/chleroy/linux-powerpc/tools/testing/selftests/vDSO/vdso_test_getcpu > gcc -std=gnu99 -D_GNU_SOURCE=    vdso_test_abi.c parse_vdso.c  -o /home/chleroy/linux-powerpc/tools/testing/selftests/vDSO/vdso_test_abi > gcc -std=gnu99 -D_GNU_SOURCE=    vdso_test_clock_getres.c  -o /home/chleroy/linux-powerpc/tools/testing/selftests/vDSO/vdso_test_clock_getres > gcc -std=gnu99 -D_GNU_SOURCE= -nostdlib -fno-asynchronous-unwind-tables -fno-stack-protector    vdso_standalone_test_x86.c parse_vdso.c  -o /home/chleroy/linux-powerpc/tools/testing/selftests/vDSO/vdso_standalone_test_x86 > gcc -std=gnu99 -D_GNU_SOURCE=  -ldl  vdso_test_correctness.c  -o /home/chleroy/linux-powerpc/tools/testing/selftests/vDSO/vdso_test_correctness > gcc -std=gnu99 -D_GNU_SOURCE= -isystem /home/chleroy/linux-powerpc/tools/testing/selftests/../../../tools/include -isystem /home/chleroy/linux-powerpc/tools/testing/selftests/../../../include/uapi    vdso_test_getrandom.c parse_vdso.c  -o /home/chleroy/linux-powerpc/tools/testing/selftests/vDSO/vdso_test_getrandom > gcc -std=gnu99 -D_GNU_SOURCE= -idirafter /home/chleroy/linux-powerpc/tools/testing/selftests/../../../tools/include -idirafter /home/chleroy/linux-powerpc/tools/testing/selftests/../../../arch/x86/include -idirafter /home/chleroy/linux-powerpc/tools/testing/selftests/../../../include -D__ASSEMBLY__ -DBULID_VDSO -DCONFIG_FUNCTION_ALIGNMENT=0 -Wa,--noexecstack -lsodium     vdso_test_chacha.c /home/chleroy/linux-powerpc/tools/testing/selftests/../../../tools/arch/x86/vdso/vgetrandom-chacha.S  -o /home/chleroy/linux-powerpc/tools/testing/selftests/vDSO/vdso_test_chacha > $ It is a clean tree (git clean -dfx), and I take there is no need to build a kernel prior hand.