From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17647C7EE25 for ; Fri, 9 Jun 2023 03:13:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236906AbjFIDN2 (ORCPT ); Thu, 8 Jun 2023 23:13:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237663AbjFIDNY (ORCPT ); Thu, 8 Jun 2023 23:13:24 -0400 Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D976F30E7; Thu, 8 Jun 2023 20:13:22 -0700 (PDT) Received: from loongson.cn (unknown [10.20.42.35]) by gateway (Coremail) with SMTP id _____8DxRunRmIJkr90AAA--.866S3; Fri, 09 Jun 2023 11:13:21 +0800 (CST) Received: from [10.20.42.35] (unknown [10.20.42.35]) by localhost.localdomain (Coremail) with SMTP id AQAAf8DxGOXQmIJkzJsJAA--.29907S3; Fri, 09 Jun 2023 11:13:20 +0800 (CST) Subject: Re: [PATCH v12 1/2] spi: add loongson spi bindings To: Krzysztof Kozlowski , Mark Brown , Rob Herring , Krzysztof Kozlowski , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jianmin Lv , wanghongliang@loongson.cn, Liu Peibao , loongson-kernel@lists.loongnix.cn, zhuyinbo@loongson.cn References: <20230608072819.25930-1-zhuyinbo@loongson.cn> <20230608072819.25930-2-zhuyinbo@loongson.cn> <6ebed84c-2b42-c981-7b3f-e71cc88e4c2c@linaro.org> <4bf747c4-b767-b20c-e00f-724b50f44edb@loongson.cn> <6bfc2a22-6901-0858-7b90-bc4c52c66810@linaro.org> <11ca2b90-544d-18c2-fb15-7909ca60507f@linaro.org> <9c94397d-1e31-02fa-bdbe-af888c72eac4@loongson.cn> <657f8d19-de83-8be6-4a9d-5f13b1df7383@linaro.org> From: zhuyinbo Message-ID: Date: Fri, 9 Jun 2023 11:13:20 +0800 User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <657f8d19-de83-8be6-4a9d-5f13b1df7383@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf8DxGOXQmIJkzJsJAA--.29907S3 X-CM-SenderInfo: 52kx5xhqerqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7KY7 ZEXasCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnUUvcSsGvfC2Kfnx nUUI43ZEXa7xR_UUUUUUUUU== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/6/8 下午9:26, Krzysztof Kozlowski 写道: > On 08/06/2023 14:10, zhuyinbo wrote: >> >> >> 在 2023/6/8 下午7:45, Krzysztof Kozlowski 写道: >>> On 08/06/2023 13:42, zhuyinbo wrote: >>>> --- a/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml >>>> +++ b/Documentation/devicetree/bindings/spi/loongson,ls2k-spi.yaml >>>> @@ -16,6 +16,7 @@ properties: >>>> compatible: >>>> enum: >>>> - loongson,ls2k1000-spi >>>> + - loongson,ls2k0500-spi >>> >>> Aren't they compatible? >>> >> >> >> Are you saying that the spi driver is compatible with 2k0500 ? > > Didn't you say this through 11 previous revisions? Yes, did I understand your meaning incorrectly ? Thanks, Yinbo > >> Yes. and the 2k1000 spi hardware was same with 2k0500 common type spi >> hardware. >> >> but afterwards, it may be necessary to implement a clock drvier for >> 2k0500, because the spi driver was use "devm_clk_get_optional()" to >> get clock and not use "of_property_read_u32(np, "clock-frequency", >> &clk)", But this seems to have nothing to do with bindings.