From: Chanwoo Choi <cw00.choi@samsung.com>
To: vadivel.muruganx.ramuthevar@linux.intel.com,
linux-kernel@vger.kernel.org
Cc: vijaikumar.kanagarajan@gmail.com, krzk@kernel.org,
myungjoo.ham@samsung.com, heikki.krogerus@linux.intel.com,
cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
yin1.li@intel.com
Subject: Re: [PATCH v3 1/1] extcon: ptn5150: Set the VBUS and POLARITY property capability
Date: Thu, 27 Aug 2020 17:11:32 +0900 [thread overview]
Message-ID: <b0e5e2e7-0ac6-4b0b-6d56-2766db28359d@samsung.com> (raw)
In-Reply-To: <47fef2ec-012c-03c7-13ef-0882b4f7146b@linux.intel.com>
Hi,
On 8/27/20 4:53 PM, Ramuthevar, Vadivel MuruganX wrote:
> Hi,
>
> On 27/8/2020 3:56 pm, Chanwoo Choi wrote:
>> On 8/27/20 3:51 PM, Ramuthevar,Vadivel MuruganX wrote:
>>> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>>>
>>> Set the capability value of property for VBUS and POLARITY.
>>>
>>> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>>> ---
>>> drivers/extcon/extcon-ptn5150.c | 7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/extcon/extcon-ptn5150.c b/drivers/extcon/extcon-ptn5150.c
>>> index 841c9fe211f1..20d49a54c36e 100644
>>> --- a/drivers/extcon/extcon-ptn5150.c
>>> +++ b/drivers/extcon/extcon-ptn5150.c
>>> @@ -275,6 +275,13 @@ static int ptn5150_i2c_probe(struct i2c_client *i2c)
>>> return ret;
>>> }
>>> + extcon_set_property_capability(info->edev, EXTCON_USB,
>>> + EXTCON_PROP_USB_VBUS);
>>> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
>>> + EXTCON_PROP_USB_VBUS);
>>> + extcon_set_property_capability(info->edev, EXTCON_USB_HOST,
>>> + EXTCON_PROP_USB_TYPEC_POLARITY);
>>
>> Above codes used the space for the indentation to keep the vertical line.
>> I think that we better to use tab for the indentation.
>>
>> If there are no objection, I'll fix and then apply it.
> Thank you!, no objection , please fix it.
Applied it. Thanks.
>
> Regards
> Vadivel
>>
>>> +
>>> /* Initialize PTN5150 device and print vendor id and version id */
>>> ret = ptn5150_init_dev_type(info);
>>> if (ret)
>>>
>>
>>
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2020-08-27 7:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 6:51 [PATCH v3 0/1]extcon: ptn5150: Add usb-typec support for Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-08-27 6:51 ` [PATCH v3 1/1] extcon: ptn5150: Set the VBUS and POLARITY property capability Ramuthevar,Vadivel MuruganX
2020-08-27 7:56 ` Chanwoo Choi
2020-08-27 7:53 ` Ramuthevar, Vadivel MuruganX
2020-08-27 8:11 ` Chanwoo Choi [this message]
2020-08-27 8:00 ` Ramuthevar, Vadivel MuruganX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0e5e2e7-0ac6-4b0b-6d56-2766db28359d@samsung.com \
--to=cw00.choi@samsung.com \
--cc=cheol.yong.kim@intel.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=qi-ming.wu@intel.com \
--cc=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=vijaikumar.kanagarajan@gmail.com \
--cc=yin1.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®