From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1E6EE34A788 for ; Mon, 13 Apr 2026 17:12:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776100343; cv=none; b=CKP5N3Nx1xNc2GyUmma8o3WnFm3Vsa7R5j0dtn/gNjeQSqhOW5C6FEXjRiA/8HVAqmKzfzf0Vk9MBUwhFy+rjXocWAaSgttLW/IQl5z6ui+NB3Jc+rE3pnxC9UU2Voer1umbfNp7qJom0wLW5dbyFHC1Nz70xBAzxxyAD7b5RdE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776100343; c=relaxed/simple; bh=l0ibTDd9T5SAnR5tj5XYYPzpx9gVL3HEGDENGJMZRhw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=otvajIYpnXn4C0v/OpJXM85+aMciBcFB9BB+4ldj8stHlSETKHVYlwFHdu6384LXo5W0Mdw8mN9vFcEKx1ERUJ9J3uIxs5kw2/vYMm7OhQFKmAxRDU1971cpDeu8KzWf5sxkQ21Eh7QYWrWwGSkVnlkRLFS4hem8Wy91vG0knGs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XB0rB7+J; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=S3u/fl6c; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XB0rB7+J"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="S3u/fl6c" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776100338; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c1oOyb1XKWKz2gZI0SCSYBVOAwAVmOuvCceYMH1PDC4=; b=XB0rB7+J6VKzmaTobrzRyEKRsx/bNYJM/cS38fMTSpNeIY1WmjOK63Oggu/LJgFOWBnt8F Qia2jh6X6AIellUg0Q/wzR510HSZ3IHElB+vurSTW3Q4Ug7ts8cHXJqwhzdoVGdNIFO/EK HAGjXJmiDDnu0RYLD4x+OzbRBGcFkUs= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-397-GE5jLyJkOFeBOeUEuuDvug-1; Mon, 13 Apr 2026 13:12:16 -0400 X-MC-Unique: GE5jLyJkOFeBOeUEuuDvug-1 X-Mimecast-MFC-AGG-ID: GE5jLyJkOFeBOeUEuuDvug_1776100336 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-7900fc7033bso118160587b3.1 for ; Mon, 13 Apr 2026 10:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776100336; x=1776705136; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=c1oOyb1XKWKz2gZI0SCSYBVOAwAVmOuvCceYMH1PDC4=; b=S3u/fl6cCHqMKoY+ImAKb6IhUmwFf1oBLV3Ke0/j/HQ2A0NzJZ46qOW4gB1v1peT4z njxupyJw+zFpZurkMhZT9q3mPa9eT2f3M8ndfhodUQA/17p6pryg6FAq8M4BkpEch3Dq 3PjuhnsewGArp6jaUl4elW822pqBERNgOYMoC0Ih0v+JXRwFmCHpn32A6bQ/MdMlq7VV 0RLtacQbVz1SIB2AxhjZc1sxdlP4PLPtdBjGTRCOiTsNJGwN73gtA2Nb/5lyoz+l1PSz cFrBsED5Tkca2k8KusyxaVUFrIHk6Zg+RAjIKGuyUVlai3Nji8yD24byUXNQSDJVZOJB 7v2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776100336; x=1776705136; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c1oOyb1XKWKz2gZI0SCSYBVOAwAVmOuvCceYMH1PDC4=; b=p1pTJL+4RwMNNnGgeXNkgKqhkjrqqKjFGcog7bm1TIKPAqZwPRl1GdwBOY2kWvNpbj TJ7XIhhTpC9a9ucfiLrArlKpVKE/UOtqL/9A+ekacIkZJCRhIFKqzIvlEjxsDpY6RiFz Y4eA7usTesZQnjlx3BPc/I5qp7GJrjmhY0Dk8LSByz0gq7/aUBHN+4WCjfPd5xF4drt0 fEPx+Jp9ql0PiYv26pQS9rD2kW0xe6VrMYVXHw0fWhJym6qp8qHXEA0ztQRql0yBrJOO HVUC0p6FfWKSEc/T8wDBwIHL1jPVbC05MNrhu+Wciskm62oeqFYmBdVz+gkx8X6fEq7t sYZQ== X-Forwarded-Encrypted: i=1; AFNElJ83PXTSUglYZFwF6fq8Sy5HlLALPfinZtYPSZFrFAjoDIHT8t/oAmnWPXU5CfZpCrGauuHT/QtyhU89lM8=@vger.kernel.org X-Gm-Message-State: AOJu0YyfzHmdb1Hi2P1ENGadSxiiDqeWXwLNQJi8chwNMXkDciJPPXU+ 27q71bZImpokSTkCiiwiO3nRnGTV889iXnc1o8HKowyxpUnzRJ3NGywFugjSybUfZ/1PDm92mKF LC4zitzAItQUuNqyRcrt52jtHZdLJMz8hufPeeHhxWWce8H20MJ5trtfVXZBfh6vPIg== X-Gm-Gg: AeBDieu40BKlAFVTUdBF7zL2YUwNiVen05qToqdWD0YmQyMj6TPPOFzVTbw2+S7h1Rq HfC2SmL0nRfjYrCRET/GSb8KH9Np0Ef7AzlbkKJem0ulYewstESQa+BLIerxDxyBic2Wsb+9LK3 ywd2h2H2eKCfj4d+wuHYcCucF/VMnX0aadeXH3qkeX2Tntit88SuUH9ATMrgqAyw1ZdopUTSTch gsPrOoT45b/1BM5hSmuyh8qDSPH7JOf8ksx5DbD9SCJAhxqetXvElwDmMyTTgikU7Ln6t9pOWF0 vkxME7mQjLKTpRKWJ0dyzIj/OKPoTLn6+Tl5Cq2Y1krO4qXNTNQSbUP0JBjDa57TNaDf626zb1W zJ1TB3SSbyOmz8W4WtITkB2XLLodfGdfJPpFYWVYK/OKli6V46mm9 X-Received: by 2002:a05:690c:39b:b0:7a3:68eb:11ae with SMTP id 00721157ae682-7adef5fffe9mr164760557b3.33.1776100336085; Mon, 13 Apr 2026 10:12:16 -0700 (PDT) X-Received: by 2002:a05:690c:39b:b0:7a3:68eb:11ae with SMTP id 00721157ae682-7adef5fffe9mr164760077b3.33.1776100335517; Mon, 13 Apr 2026 10:12:15 -0700 (PDT) Received: from li-4c4c4544-0032-4210-804c-c3c04f423534.ibm.com ([2600:1700:6476:1430::29]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7b3b0d656a0sm11650187b3.4.2026.04.13.10.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Apr 2026 10:12:14 -0700 (PDT) Message-ID: Subject: Re: [PATCH] hfsplus: remove xattr error message From: Viacheslav Dubeyko To: Colin Ian King , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , linux-fsdevel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 13 Apr 2026 10:12:13 -0700 In-Reply-To: <20260411125338.165758-1-colin.i.king@gmail.com> References: <20260411125338.165758-1-colin.i.king@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43app2) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Sat, 2026-04-11 at 13:53 +0100, Colin Ian King wrote: > When exercising hfsplus with the stress-ng xattr stressor a large > quantity of somewhat unhelpful error messages "hfsplus: xattr exists > yet" spam the kernel log. Remove these. We can convert it into hfs_dbg() and to add showing inode ID + name. What d= o you think? Also, there are other pr_err() in xattr code that can be converted into hfs_dbg(). Could you please take a look into other ones too? Thanks, Slava. >=20 > Signed-off-by: Colin Ian King > --- > fs/hfsplus/xattr.c | 2 -- > 1 file changed, 2 deletions(-) >=20 > diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c > index c70bb6f494b2..e10e1d8a5862 100644 > --- a/fs/hfsplus/xattr.c > +++ b/fs/hfsplus/xattr.c > @@ -301,7 +301,6 @@ int __hfsplus_setxattr(struct inode *inode, const cha= r *name, > =20 > if (!strcmp_xattr_finder_info(name)) { > if (flags & XATTR_CREATE) { > - pr_err("xattr exists yet\n"); > err =3D -EOPNOTSUPP; > goto end_setxattr; > } > @@ -348,7 +347,6 @@ int __hfsplus_setxattr(struct inode *inode, const cha= r *name, > =20 > if (hfsplus_attr_exists(inode, name)) { > if (flags & XATTR_CREATE) { > - pr_err("xattr exists yet\n"); > err =3D -EOPNOTSUPP; > goto end_setxattr; > }