From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 236C1C34022 for ; Wed, 19 Feb 2020 05:35:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07301208E4 for ; Wed, 19 Feb 2020 05:35:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726385AbgBSFfU (ORCPT ); Wed, 19 Feb 2020 00:35:20 -0500 Received: from mx2.suse.de ([195.135.220.15]:56398 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725842AbgBSFfT (ORCPT ); Wed, 19 Feb 2020 00:35:19 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4DC33AE24; Wed, 19 Feb 2020 05:35:17 +0000 (UTC) Subject: Re: [PATCH] x86/ioperm: add new paravirt function update_io_bitmap To: Thomas Gleixner , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Cc: Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Thomas Hellstrom , "VMware, Inc." , Boris Ostrovsky , Stefano Stabellini , stable@vger.kernel.org References: <20200218154712.25490-1-jgross@suse.com> <87mu9fr4ky.fsf@nanos.tec.linutronix.de> From: =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= Message-ID: Date: Wed, 19 Feb 2020 06:35:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <87mu9fr4ky.fsf@nanos.tec.linutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.02.20 22:03, Thomas Gleixner wrote: > Juergen Gross writes: >> Commit 111e7b15cf10f6 ("x86/ioperm: Extend IOPL config to control >> ioperm() as well") reworked the iopl syscall to use I/O bitmaps. >> >> Unfortunately this broke Xen PV domains using that syscall as there >> is currently no I/O bitmap support in PV domains. >> >> Add I/O bitmap support via a new paravirt function update_io_bitmap >> which Xen PV domains can use to update their I/O bitmaps via a >> hypercall. >> >> Fixes: 111e7b15cf10f6 ("x86/ioperm: Extend IOPL config to control ioperm() as well") >> Reported-by: Jan Beulich >> Cc: # 5.5 >> Signed-off-by: Juergen Gross >> Reviewed-by: Jan Beulich >> Tested-by: Jan Beulich > > Duh, sorry about that and thanks for fixing it. > > BTW, why isn't stuff like this not catched during next or at least > before the final release? Is nothing running CI on upstream with all > that XEN muck active? This problem showed up by not being able to start the X server (probably not the freshest one) in dom0 on a moderate aged AMD system. Our CI tests tend do be more text console based for dom0. Juergen