From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Andrey Smirnov <andrew.smirnov@gmail.com>, linux-pm@vger.kernel.org
Cc: Chris Healy <cphealy@gmail.com>,
Lucas Stach <l.stach@pengutronix.de>,
Eduardo Valentin <edubezval@gmail.com>,
Angus Ainslie <angus@akkea.ca>,
linux-imx@nxp.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 12/12] thermal: qoriq: Add hwmon support
Date: Tue, 16 Apr 2019 19:17:37 +0200 [thread overview]
Message-ID: <b0fb8610-25c5-255d-8d4e-7722d37c70d7@linaro.org> (raw)
In-Reply-To: <20190413082748.29990-13-andrew.smirnov@gmail.com>
On 13/04/2019 10:27, Andrey Smirnov wrote:
> Expose thermal readings as a HWMON device, so that it could be
> accessed using lm-sensors.
>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> Cc: Chris Healy <cphealy@gmail.com>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Eduardo Valentin <edubezval@gmail.com>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Angus Ainslie (Purism) <angus@akkea.ca>
> Cc: linux-imx@nxp.com
> Cc: linux-pm@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> drivers/thermal/qoriq_thermal.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c
> index 5c459a9d0db3..897b3424b43b 100644
> --- a/drivers/thermal/qoriq_thermal.c
> +++ b/drivers/thermal/qoriq_thermal.c
> @@ -12,6 +12,7 @@
> #include <linux/thermal.h>
>
> #include "thermal_core.h"
> +#include "thermal_hwmon.h"
>
> #define SITES_MAX 16
>
> @@ -93,6 +94,10 @@ static int qoriq_tmu_register_tmu_zone(struct device *dev,
> case -ENODEV:
> continue;
> case 0:
> + ret = devm_thermal_add_hwmon_sysfs(tzd);
> + if (ret)
> + dev_warn(dev,
> + "Failed to add hwmon sysfs attributes\n");
> break;
> default:
> regmap_write(qdata->regmap, REGS_TMR, TMR_DISABLE);
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2019-04-16 17:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-13 8:27 [PATCH v4 00/12] QorIQ TMU multi-sensor and HWMON support Andrey Smirnov
2019-04-13 8:27 ` [PATCH v4 01/12] thermal: qoriq: Remove unnecessary DT node is NULL check Andrey Smirnov
2019-04-13 8:27 ` [PATCH v4 02/12] thermal: qoriq: Add local struct device pointer Andrey Smirnov
2019-04-13 8:27 ` [PATCH v4 03/12] thermal: qoriq: Don't store struct thermal_zone_device reference Andrey Smirnov
2019-04-13 8:27 ` [PATCH v4 04/12] thermal: qoriq: Drop per-sensor data Andrey Smirnov
2019-04-16 17:23 ` Daniel Lezcano
2019-04-13 8:27 ` [PATCH v4 05/12] thermal: qoriq: Pass data to qoriq_tmu_register_tmu_zone() directly Andrey Smirnov
2019-04-13 8:27 ` [PATCH v4 06/12] thermal: qoriq: Pass data to qoriq_tmu_calibration() directly Andrey Smirnov
2019-04-16 16:51 ` Daniel Lezcano
2019-04-13 8:27 ` [PATCH v4 07/12] thermal: qoriq: Convert driver to use devm_ioremap() Andrey Smirnov
2019-04-16 16:52 ` Daniel Lezcano
2019-04-13 8:27 ` [PATCH v4 08/12] thermal: qoriq: Convert driver to use regmap API Andrey Smirnov
2019-04-16 16:58 ` Daniel Lezcano
2019-04-13 8:27 ` [PATCH v4 09/12] thermal: qoriq: Enable all sensors before registering them Andrey Smirnov
2019-04-16 17:09 ` Daniel Lezcano
2019-04-18 20:02 ` Andrey Smirnov
2019-04-13 8:27 ` [PATCH v4 10/12] thermal: qoriq: Do not report invalid temperature reading Andrey Smirnov
2019-04-16 17:11 ` Daniel Lezcano
2019-04-13 8:27 ` [PATCH v4 11/12] thermal_hwmon: Add devres wrapper for thermal_add_hwmon_sysfs() Andrey Smirnov
2019-04-16 17:16 ` Daniel Lezcano
2019-04-13 8:27 ` [PATCH v4 12/12] thermal: qoriq: Add hwmon support Andrey Smirnov
2019-04-16 17:17 ` Daniel Lezcano [this message]
2019-04-16 17:24 ` [PATCH v4 00/12] QorIQ TMU multi-sensor and HWMON support Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0fb8610-25c5-255d-8d4e-7722d37c70d7@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=andrew.smirnov@gmail.com \
--cc=angus@akkea.ca \
--cc=cphealy@gmail.com \
--cc=edubezval@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®