From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51F7D18AE2 for ; Mon, 1 Jun 2026 16:29:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780331368; cv=none; b=WlzVNkbtA1JYwuuGgfRPA1QjnM0cNBD6bE1q7BOZ6KLgi/Q58TlgfJghrlbIyV3Bduqo5sfjdol0/hfZx27nUwm+ri/CpKGZpwb9u7pnnobBwf6m9kughE3bMUYp8gFoATq3v8i28c0OJnpt7tAWOkfod6tAIHJP07oKnorTAII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780331368; c=relaxed/simple; bh=PZdBZiNLVlObz9gIrGHHxQf6Y+iC4DcySdXN9+n6CRY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QO+mhuVvHeoT+cQG7GpEqif6oJOQM1XzTSGMuhcUlnNa02Td1BpOGmebWszcAJdcIGrjp258EeId60chWoXd26qoWvvjBUTFKJ02RQ0jGymIL0/tMHWwLkoUxHdFvB96MkWOsCWvYRNNfMVsxnyhMSh5y40x1G7rI9WPzaJ/THI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=pr5OgAn/; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="pr5OgAn/" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1780331365; bh=PZdBZiNLVlObz9gIrGHHxQf6Y+iC4DcySdXN9+n6CRY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=pr5OgAn/UEt4PWmI+wiOEBwRWMriWCL5/bihJWujDGLVriMS6CRzxjKXj1mPcqvfC r6kznu2r94sxfHvK5P1s0vyaqKbCLtrMv1mkPAsfY4y9MzX/5S77dljyhQ9Eo/g+Ai yBy3TgxWm0zkFhXgWmvrFvnb/0e2M6jhYVzARpEoHO5hB9JbT72mFx6wmy1dpReWXI 6igJBLRgPj0Scx2BRxGMQx0QOnFA1KmSkW0ZCHnLCtuU/YeQJZbQQv99hiyQdsrB4g 1zBhW1L8CCKyThvLEJrVTQ5ZZQfzUCAcsTGsK/7aCLwl9lgtvxySDGoNcDSoFEeq4y ga3CnwA0Dut3A== Received: from [100.64.0.241] (unknown [100.64.0.241]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: cristicc) by bali.collaboradmins.com (Postfix) with ESMTPSA id C139317E03A6; Mon, 1 Jun 2026 18:29:24 +0200 (CEST) Message-ID: Date: Mon, 1 Jun 2026 19:29:24 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 05/10] drm/bridge: dw-hdmi-qp: Add HDMI 2.0 SCDC scrambling and high TMDS clock ratio support To: Andy Yan , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sandy Huang , =?UTF-8?Q?Heiko_St=C3=BCbner?= Cc: kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Diederik de Haas , Maud Spierings References: <20260426-dw-hdmi-qp-scramb-v5-0-d778e70c317b@collabora.com> <20260426-dw-hdmi-qp-scramb-v5-5-d778e70c317b@collabora.com> <9a7855a7-6b0c-4aa2-8516-13d94beabac6@rock-chips.com> Content-Language: en-US From: Cristian Ciocaltea In-Reply-To: <9a7855a7-6b0c-4aa2-8516-13d94beabac6@rock-chips.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Andy, On 6/1/26 7:06 AM, Andy Yan wrote: > Hello, > > On 4/26/26 08:20, Cristian Ciocaltea wrote: >> Enable HDMI 2.0 display modes (e.g. 4K@60Hz) by adding SCDC management >> for the high TMDS clock ratio and scrambling, required when the TMDS >> character rate exceeds the 340 MHz HDMI 1.4b limit. >> >> A periodic work item monitors the sink's scrambling status to recover >> from sink-side resets. On hotplug detect, if SCDC scrambling state is >> out of sync with the driver, trigger a CRTC reset to re-establish the >> link. >> >> Reject modes requiring TMDS rates above 600 MHz, as those fall in the >> HDMI 2.1 FRL domain which is not supported. In no_hpd configurations, >> further restrict to 340 MHz since SCDC requires a connected sink. >> >> Tested-by: Diederik de Haas >> Tested-by: Maud Spierings >> Signed-off-by: Cristian Ciocaltea >> --- >> drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 188 ++++++++++++++++++++++++--- >> 1 file changed, 172 insertions(+), 16 deletions(-) [...] >> } >> static const struct drm_edid * >> @@ -832,12 +986,12 @@ dw_hdmi_qp_bridge_tmds_char_rate_valid(const struct drm_bridge *bridge, >> { >> struct dw_hdmi_qp *hdmi = bridge->driver_private; >> - /* >> - * TODO: when hdmi->no_hpd is 1 we must not support modes that >> - * require scrambling, including every mode with a clock above >> - * HDMI14_MAX_TMDSCLK. >> - */ >> - if (rate > HDMI14_MAX_TMDSCLK) { > > The locally defined HDMI14_MAX_TMDSCLK has been removed, we should now use > HDMI_1_3_CHAR_RATE_MAX, and I think we should apply the same change to > HDMI20_MAX_TMDSRATE Yep, already addressed in my local dev branch. Please note this revision is obsolete, there's already v6 available and I'm going to submit v7 a bit later today. Thanks, Cristian