mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: "Pankaj Raghav (Samsung)" <kernel@pankajraghav.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Christian Brauner <brauner@kernel.org>,
	Luis Chamberlain <mcgrof@kernel.org>,
	Pankaj Raghav <p.raghav@samsung.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	djwong@kernel.org, ritesh.list@gmail.com,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: linux-next: boot warning after merge of the vfs-brauner tree
Date: Mon, 26 Aug 2024 19:43:20 +0200	[thread overview]
Message-ID: <b0fe75b4-c1bb-47f7-a7c3-2534b31c1780@csgroup.eu> (raw)
In-Reply-To: <20240826154818.hzqnvofdmaxvuwrh@quentin>



Le 26/08/2024 à 17:48, Pankaj Raghav (Samsung) a écrit :
> On Mon, Aug 26, 2024 at 05:59:31PM +1000, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the vfs-brauner tree, today's linux-next boot test (powerpc
>> pseries_le_defconfig) produced this warning:
> 
> iomap dio calls set_memory_ro() on the page that is used for sub block
> zeroing.
> 
> But looking at powerpc code, they don't support set_memory_ro() for
> memory region that belongs to the kernel(LINEAR_MAP_REGION_ID).
> 
> /*
>   * On hash, the linear mapping is not in the Linux page table so
>   * apply_to_existing_page_range() will have no effect. If in the future
>   * the set_memory_* functions are used on the linear map this will need
>   * to be updated.
>   */
> if (!radix_enabled()) {
>          int region = get_region_id(addr);
> 
>          if (WARN_ON_ONCE(region != VMALLOC_REGION_ID && region != IO_REGION_ID))
>                  return -EINVAL;
> }
> 
> We call set_memory_ro() on the zero page as a extra security measure.
> I don't know much about powerpc, but looking at the comment, is it just
> adding the following to support it in powerpc:
> 
> diff --git a/arch/powerpc/mm/pageattr.c b/arch/powerpc/mm/pageattr.c
> index ac22bf28086fa..e6e0b40ba6db4 100644
> --- a/arch/powerpc/mm/pageattr.c
> +++ b/arch/powerpc/mm/pageattr.c
> @@ -94,7 +94,9 @@ int change_memory_attr(unsigned long addr, int numpages, long action)
>          if (!radix_enabled()) {
>                  int region = get_region_id(addr);
>   
> -               if (WARN_ON_ONCE(region != VMALLOC_REGION_ID && region != IO_REGION_ID))
> +               if (WARN_ON_ONCE(region != VMALLOC_REGION_ID &&
> +                                region != IO_REGION_ID &&
> +                                region != LINEAR_MAP_REGION_ID))
>                          return -EINVAL;
>          }
>   #endif

By doing this you will just hide the fact that it didn't work.

See commit 1f9ad21c3b38 ("powerpc/mm: Implement set_memory() routines") 
for details. The linear memory region is not mapped using page tables so 
set_memory_ro() will have no effect on it.

You can either use vmalloc'ed pages, or do a const static allocation at 
buildtime so that it will be allocated in the kernel static rodata area.

By the way, your code should check the value returned by 
set_memory_ro(), there is some work in progress to make it mandatory, 
see https://github.com/KSPP/linux/issues/7

Christophe

> 
>   If it involves changing more things and this feature will be added to
>   powerpc in the future, we could drop the set_memory_ro() call from
>   iomap.
> 
>   CC: Darrick(as he suggested set_memory_ro() on zero page), Leroy,
>   Ritesh, ppc list
> 

  reply	other threads:[~2024-08-26 17:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-26  7:59 Stephen Rothwell
2024-08-26 15:48 ` Pankaj Raghav (Samsung)
2024-08-26 17:43   ` Christophe Leroy [this message]
2024-08-26 20:52     ` Luis Chamberlain
2024-08-26 21:10       ` Darrick J. Wong
2024-08-26 21:41         ` Luis Chamberlain
2024-08-27  5:26           ` Ritesh Harjani
2024-08-27 15:38       ` Mike Rapoport
2024-08-27  6:28   ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b0fe75b4-c1bb-47f7-a7c3-2534b31c1780@csgroup.eu \
    --to=christophe.leroy@csgroup.eu \
    --cc=brauner@kernel.org \
    --cc=djwong@kernel.org \
    --cc=kernel@pankajraghav.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mcgrof@kernel.org \
    --cc=p.raghav@samsung.com \
    --cc=ritesh.list@gmail.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®