From: Paulo Alcantara <pc@manguebit.org>
To: "Iván Ezequiel Rodriguez" <ivanrwcm25@gmail.com>,
"David Howells" <dhowells@redhat.com>,
netfs@lists.linux.dev
Cc: Shyam Prasad N <sprasad@microsoft.com>,
Steve French <stfrench@microsoft.com>,
linux-fsdevel@vger.kernel.org, linux-cifs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH netfs v2 1/2] netfs: preserve prepare_write errno on reissue
Date: Mon, 09 Nov 2026 16:12:15 -0300 [thread overview]
Message-ID: <b0fecf98c80a78b4b40488e44dd73ebe@manguebit.org> (raw)
In-Reply-To: <20261102150656.207612-2-ivanrwcm25@gmail.com>
Iván Ezequiel Rodriguez <ivanrwcm25@gmail.com> writes:
> prepare_write() may call netfs_prepare_write_failed() (FAILED + errno)
> before write_retry calls netfs_reissue_write(). Clearing subreq->error
> to 0 for a clean I/O reissue (82e8885bd763) then makes
> netfs_do_issue_write() terminate with 0. The collector copies
> front->error into stream->error and mapping_set_error(), which ignores
> 0, so writeback failure is silent.
>
> Skip clearing error when NETFS_SREQ_FAILED is already set;
> do_issue_write() already terminates FAILED subrequests.
>
> Fixes: 82e8885bd763 ("netfs: when subreq is marked for retry, do not check if it faced an error")
> Cc: Shyam Prasad N <sprasad@microsoft.com>
> Cc: Steve French <stfrench@microsoft.com>
> Signed-off-by: Iván Ezequiel Rodriguez <ivanrwcm25@gmail.com>
Applied with R-b from Dave.
next prev parent reply other threads:[~2026-11-09 19:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-28 18:12 [PATCH netfs v1 0/2] preserve prepare_write errno across write reissue Iván Ezequiel Rodriguez
2026-10-28 18:12 ` [PATCH netfs v1 1/2] netfs: preserve prepare_write errno on reissue Iván Ezequiel Rodriguez
2026-10-28 18:12 ` [PATCH netfs v1 2/2] netfs: add KUnit coverage for reissue prepare_write errno Iván Ezequiel Rodriguez
2026-10-29 10:19 ` kernel test robot
2026-11-02 15:06 ` [PATCH netfs v2 0/2] preserve prepare_write errno across write reissue Iván Ezequiel Rodriguez
2026-11-02 15:06 ` [PATCH netfs v2 1/2] netfs: preserve prepare_write errno on reissue Iván Ezequiel Rodriguez
2026-11-09 19:12 ` Paulo Alcantara [this message]
2026-11-02 15:06 ` [PATCH netfs v2 2/2] netfs: add KUnit coverage for reissue prepare_write errno Iván Ezequiel Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b0fecf98c80a78b4b40488e44dd73ebe@manguebit.org \
--to=pc@manguebit.org \
--cc=dhowells@redhat.com \
--cc=ivanrwcm25@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=sprasad@microsoft.com \
--cc=stfrench@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®