From: John Garry <john.g.garry@oracle.com>
To: Xingui Yang <yangxingui@huawei.com>,
yanaijie@huawei.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, damien.lemoal@opensource.wdc.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxarm@huawei.com, prime.zeng@hisilicon.com,
chenxiang66@hisilicon.com, kangfenglong@huawei.com
Subject: Re: [PATCH v3 3/3] scsi: libsas: Fix disk not being scanned in after being removed
Date: Thu, 7 Mar 2024 10:08:14 +0000 [thread overview]
Message-ID: <b105b26c-9c0b-4315-beeb-7879de85d240@oracle.com> (raw)
In-Reply-To: <20240307093733.41222-4-yangxingui@huawei.com>
On 07/03/2024 09:37, Xingui Yang wrote:
> As of commit d8649fc1c5e4 ("scsi: libsas: Do discovery on empty PHY to
> update PHY info"), do discovery will send a new SMP_DISCOVER and update
> phy->phy_change_count. We found that if the disk is reconnected and phy
> change_count changes at this time, the disk scanning process will not be
> triggered.
>
> Therefore, call sas_set_ex_phy() to update the PHY info with the results of
> the last query. And because the previous phy info will be used when calling
> sas_unregister_devs_sas_addr(), sas_unregister_devs_sas_addr() should be
> called before sas_set_ex_phy().
>
> Fixes: d8649fc1c5e4 ("scsi: libsas: Do discovery on empty PHY to update PHY info")
> Signed-off-by: Xingui Yang<yangxingui@huawei.com>
I am also ok with a change to revert to allocating the resp memory with
alloc_smp_resp(), but make the changes neat please:
Reviewed-by: John Garry <john.g.garry@oracle.com>
next prev parent reply other threads:[~2024-03-07 10:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 9:37 [PATCH v3 0/3] " Xingui Yang
2024-03-07 9:37 ` [PATCH v3 1/3] scsi: libsas: Allow smp_execute_task() arguments to be on the stack Xingui Yang
2024-03-11 5:42 ` Dan Carpenter
2024-03-11 7:35 ` yangxingui
2024-03-07 9:37 ` [PATCH v3 2/3] scsi: libsas: Add a helper sas_get_sas_addr_and_dev_type() Xingui Yang
2024-03-07 10:04 ` John Garry
2024-03-07 9:37 ` [PATCH v3 3/3] scsi: libsas: Fix disk not being scanned in after being removed Xingui Yang
2024-03-07 10:08 ` John Garry [this message]
2024-03-07 14:17 ` yangxingui
2024-03-07 10:01 ` [PATCH v3 0/3] " John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b105b26c-9c0b-4315-beeb-7879de85d240@oracle.com \
--to=john.g.garry@oracle.com \
--cc=chenxiang66@hisilicon.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=jejb@linux.ibm.com \
--cc=kangfenglong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=martin.petersen@oracle.com \
--cc=prime.zeng@hisilicon.com \
--cc=yanaijie@huawei.com \
--cc=yangxingui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®