From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757956AbcIHNhO (ORCPT ); Thu, 8 Sep 2016 09:37:14 -0400 Received: from mail-pf0-f171.google.com ([209.85.192.171]:35279 "EHLO mail-pf0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757152AbcIHNhM (ORCPT ); Thu, 8 Sep 2016 09:37:12 -0400 Subject: Re: [PATCH v10 3/4] ARM64: ACPI: enable ACPI_SPCR_TABLE To: Will Deacon , Aleksey Makarov References: <20160905123617.18775-1-aleksey.makarov@linaro.org> <20160905123617.18775-4-aleksey.makarov@linaro.org> <7e5486cc-4080-2d1e-8f6d-98874379887d@gmail.com> <20160908111654.GH1493@arm.com> Cc: Catalin Marinas , Aleksey Makarov , "Rafael J . Wysocki" , "Zheng, Lv" , Kefeng Wang , Russell King , Peter Hurley , Graeme Gregory , Greg Kroah-Hartman , Andy Shevchenko , linux-kernel@vger.kernel.org, Leif Lindholm , linux-acpi@vger.kernel.org, Yury Norov , Christopher Covington , linux-serial@vger.kernel.org, Mark Salter , Al Stone , linux-arm-kernel@lists.infradead.org, Len Brown From: Hanjun Guo Message-ID: Date: Thu, 8 Sep 2016 21:35:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160908111654.GH1493@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/9/8 19:16, Will Deacon wrote: > On Wed, Sep 07, 2016 at 12:30:19PM +0300, Aleksey Makarov wrote: >> >> On 09/05/2016 03:36 PM, Aleksey Makarov wrote: >>> SBBR mentions SPCR as a mandatory ACPI table. So enable it for ARM64 >>> >>> Earlycon should be set up as early as possible. ACPI boot tables are >>> mapped in arch/arm64/kernel/acpi.c:acpi_boot_table_init() that >>> is called from setup_arch() and that's where we parse SPCR. >>> So it has to be opted-in per-arch. >>> >>> When ACPI_SPCR_TABLE is defined initialization of DT earlycon is >>> deferred until the DT/ACPI decision is done. Initialize DT earlycon >>> if ACPI is disabled. >> >> Hi Will, Catalin, >> >> Can you review this patch and consider ACKing it please? > > Hanjun, Al, Mark, Graeme -- any comments on this? We tested this patch on D02, although d02 is 8250 based uart, but this patch is the core part, which makes sense to me, Acked-by: Hanjun Guo Thanks Hanjun