From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C600837474A for ; Fri, 12 Jun 2026 08:10:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781251811; cv=none; b=DR1bg+0JuHnPC9Sl4mjevrc+fUzJ8CMA72yKWaBLZ5RapfZDhnsVaWzLP+w72rQ4MqZwI4YbITf+87AoyzGCThkjbttP34zzfZgM2BbxkF4lCdkSGILplc1s591SZ2EV5cpr2D1nWx2WyYdy4dGHMw124kigSw9lDfQCySpByFo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781251811; c=relaxed/simple; bh=tlIFSDGimFC4A3TsOlVc1dm/d2ZHPIEkda2SqO3cXYw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=e8r5C8tMf8SPDdjmFvTpJag7elB0vNuKpcPGeD+k+cGKVoBUaqfavpHYqRQPskV6gk4QGqmBNAAmbvtZHT+LySJx61VbYbCSTgd7LkYeSOzxi6dvNbFxy0yqsEqe2p8wccAh0FG6+IJyj8bowCW3ylmtN0PyrwbVFv419kwg6r4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=s4J6cpCW; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="s4J6cpCW" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-5aa64cbb08fso84651e87.3 for ; Fri, 12 Jun 2026 01:10:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1781251808; x=1781856608; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=Qzqd0JGS+LvqWWHcM0Pu7KnmR8I/e+6J9UGxu+nu8iA=; b=s4J6cpCWL9+J/ts+XsGbAdn3vO8YyU7Ov9Ni7LPEWXJEEbA2ojahSYgc3CfsrfqPId EN/wHJ4v0guU3FrdS0wdj2NZYOi+noTMPZbbCio1Bnv5b6Cx2yME/UThwixIecqgaifj OO22hzzY2t9xHWXt1Egs82Rp44+WD6MHIQJbJintei5or8ZooYZ/lRJ1N8TrBdfuQpNU JX13NFxlQO8+MK6Ku5W6wv4EQfnl10OrQ/d1idwfiH20pdNlQx4Nwrlu861vBSI89z4F X++HBGFstY4A3BCrag8SFqFZiRCr0WvO1uapOlc0Rpi1GPuIHN0+CasPzc4g+mmD9i5/ Jstg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781251808; x=1781856608; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Qzqd0JGS+LvqWWHcM0Pu7KnmR8I/e+6J9UGxu+nu8iA=; b=Wo96NbxOG8wKj5qirTphHf23zr0nxa0R6FoBxd3i43z9pLGvWIF/BT2C58pTGV6rB4 pJ/l3dHW3z3onDnjsSUohj81OByPPsrdp31V8q2HmGVKfnN2mx1EbNlDZCBMa2GnLBwU zRog13yXmyHnIKsNsnlvQojCOj76SvxxOO5vKTpspDIJpXn75hZE35+HHYKv+4Eb/jYV VjMHv33ExM33UHVJyiul3KPVDaL7LvQ76/0jMybwwjUsfU4ixDeEfsaxsi8jiF8w9+7H UpqlDL9nOJCbJRA0PYf/wJK9OMBIV3vnugkiWDDPr0VyDKzs++UMFP/y21MGZb3APYFi HhsA== X-Forwarded-Encrypted: i=1; AFNElJ+PUSfELtOIl27cuHudb0PwbQo7e76eNEYxzHmPm1aH9Z6EhGRcSliOhIHbaFvt1kB8A0T2XqN8VM46QCk=@vger.kernel.org X-Gm-Message-State: AOJu0YyhwEGXSBob7j9CX2c+IdvaGCkLYIY3EBY9iUvkC9+tW883TIeK OkdVTFuGjooUerZ5hpE+aPJ+gi4ieDIjoZ39NwQimP6rFYiODqn05CkpEeCuYb88rztq3SDULWA P6RYyv1Y= X-Gm-Gg: Acq92OE9P59k0SstKfl2DBrjASIegfqD9gOuZyQ9OZEKcx7OWzi4A3KpBcCr7Mhqces pHmSYHTyoQAOkdyPVdbtYoUJ6cXXTyejtHpuwpmTVBQlecsrpbTBnuvDi3kXPiW38iRg55yuWmr /JAzyxhG1HkpAk65oWCNtOG17G1E4sYTocEd7w9OugyJK9uEcWY5wlaumHwd7lZRWKBzMkwHbW6 xlG0ppqp5GspIpW6kA6yjKCpEar+8YbNBR2RafPO2qX7sCG7nP2wO2Lr1VpEzm667xSgs8/46dG sf7Sr+sSXX9UH+iioDFzzDqkBC51GGp8SH9XuMngh73DSeC0LH6umnZLFbOC6/Rut/jsYgbOcsk /FYdy5oPyEN+YAYUnFH+YQIiUCKPLjGfotnk6atEnJ20syhqMxl0bxMBuvMby9ldP46DdfhLb6l r8sJkhrVyFY0a7aAElhFH3Nfv6XcTOxY2SvyeCYyiVDxN6ND7fOZlgdA2vUZcfF9wfR9cJ4QBAb 2Mwww== X-Received: by 2002:a05:6512:3b0a:b0:5aa:6ba4:46f2 with SMTP id 2adb3069b0e04-5ad2db189d7mr289426e87.1.1781251807831; Fri, 12 Jun 2026 01:10:07 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5ad2e1a6fc0sm332575e87.51.2026.06.12.01.10.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Jun 2026 01:10:07 -0700 (PDT) Message-ID: Date: Fri, 12 Jun 2026 11:10:06 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 6/7] arm64: dts: qcom: shikra-cqm-cqs-evk-imx577-camera: Add DT overlay To: Nihal Kumar Gupta , Bryan O'Donoghue , Loic Poulain , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Andi Shyti , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Suresh Vankadara , Vikram Sharma References: <20260608-shikra-camss-review-v2-0-ca1936bf1219@oss.qualcomm.com> <20260608-shikra-camss-review-v2-6-ca1936bf1219@oss.qualcomm.com> From: Vladimir Zapolskiy In-Reply-To: <20260608-shikra-camss-review-v2-6-ca1936bf1219@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/8/26 17:06, Nihal Kumar Gupta wrote: > Shikra CQM and CQS are retail variants sharing the same PM4125 PMIC > and identical camera supply rails. The only difference between them > is the integrated modem on CQM, which does not affect camera hardware. > > Add a shared overlay for optional IMX577 integration via CSIPHY1, > used by both CQM and CQS EVK boards. > > Signed-off-by: Nihal Kumar Gupta > --- > arch/arm64/boot/dts/qcom/Makefile | 6 ++ > .../dts/qcom/shikra-cqm-cqs-evk-imx577-camera.dtso | 70 ++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 9 +++ > arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 9 +++ > 4 files changed, 94 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index a9e9d829fb962386b3975f345ec006504607130a..76b8f144983827f4905a72935e8d5291a227dc97 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -337,6 +337,12 @@ dtb-$(CONFIG_ARCH_QCOM) += sdx75-idp.dtb > dtb-$(CONFIG_ARCH_QCOM) += shikra-cqm-evk.dtb > dtb-$(CONFIG_ARCH_QCOM) += shikra-cqs-evk.dtb > dtb-$(CONFIG_ARCH_QCOM) += shikra-iqs-evk.dtb > + > +shikra-cqm-evk-imx577-camera-dtbs := shikra-cqm-evk.dtb shikra-cqm-cqs-evk-imx577-camera.dtbo > +shikra-cqs-evk-imx577-camera-dtbs := shikra-cqs-evk.dtb shikra-cqm-cqs-evk-imx577-camera.dtbo > + > +dtb-$(CONFIG_ARCH_QCOM) += shikra-cqm-evk-imx577-camera.dtb > +dtb-$(CONFIG_ARCH_QCOM) += shikra-cqs-evk-imx577-camera.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm4250-oneplus-billie2.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm4450-qrd.dtb > dtb-$(CONFIG_ARCH_QCOM) += sm6115-fxtec-pro1x.dtb > diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-cqs-evk-imx577-camera.dtso b/arch/arm64/boot/dts/qcom/shikra-cqm-cqs-evk-imx577-camera.dtso > new file mode 100644 > index 0000000000000000000000000000000000000000..e3dad7c81e5e8aeb1061c784b5b893965f914a6f > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/shikra-cqm-cqs-evk-imx577-camera.dtso > @@ -0,0 +1,70 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > + */ > + > +/dts-v1/; > +/plugin/; > + > +#include > +#include > + > +&camss { > + vdd-csiphy-1p2-supply = <&pm4125_l5>; > + vdd-csiphy-1p8-supply = <&pm4125_l13>; > + > + status = "okay"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@1 { > + reg = <1>; > + > + csiphy1_ep: endpoint { > + data-lanes = <0 1 2 3>; > + remote-endpoint = <&imx577_ep1>; > + }; > + }; > + }; > +}; > + > +&cci { > + status = "okay"; > +}; > + > +&cci_i2c1 { > + #address-cells = <1>; > + #size-cells = <0>; > + > + camera@1a { > + compatible = "sony,imx577"; > + reg = <0x1a>; > + > + reset-gpios = <&tlmm 33 GPIO_ACTIVE_LOW>; > + pinctrl-0 = <&cam_mclk1_default &cam1_reset_default>; > + pinctrl-names = "default"; > + > + clocks = <&gcc GCC_CAMSS_MCLK1_CLK>; > + assigned-clocks = <&gcc GCC_CAMSS_MCLK1_CLK>; > + assigned-clock-rates = <24000000>; > + > + /* > + * avdd and dvdd are supplied by on-board regulators on the > + * IMX577 module from the connector's 3.3 V rail; they are > + * not SoC-controlled. dovdd (1.8 V) powers the carrier board > + * level-shifter that translates CCI I2C and reset lines > + * between the SoC and the connector. > + */ > + dovdd-supply = <&pm4125_l15>; > + > + port { > + imx577_ep1: endpoint { > + link-frequencies = /bits/ 64 <600000000>; > + data-lanes = <0 1 2 3>; The numeration of data-lanes shall be started from 1, this has to be fixed. > + remote-endpoint = <&csiphy1_ep>; > + }; > + }; > + }; > +}; > diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts > index 0a52ab9b7a4c34d371f5ac23efe59d1c9d2723f4..0d5c3e31b1f613157d4d2ec6947c630f1031b73b 100644 > --- a/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts > +++ b/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts > @@ -38,3 +38,12 @@ &sdhc_1 { > > status = "okay"; > }; > + > +&tlmm { > + cam1_reset_default: cam1-reset-default-state { > + pins = "gpio33"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > +}; Since it's a mezzanine specific pinctl assignment, it shall go to the correspondent .dtso file. It's a concidence that one .dtso file is good enough for describing the mezzanine for two diffferent boards, but let's exploit it by keeping one dt overlay file as it is now. > diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts > index b3f19a64d7aed3121ef092df684b19a4de39b497..515af370ca014a668dc035ff944fb82b6e09ceeb 100644 > --- a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts > +++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts > @@ -38,3 +38,12 @@ &sdhc_1 { > > status = "okay"; > }; > + > +&tlmm { > + cam1_reset_default: cam1-reset-default-state { > + pins = "gpio33"; > + function = "gpio"; > + drive-strength = <2>; > + bias-disable; > + }; > +}; > Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir