From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756218AbdESRwT (ORCPT ); Fri, 19 May 2017 13:52:19 -0400 Received: from mout.web.de ([212.227.15.14]:55707 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752385AbdESRvR (ORCPT ); Fri, 19 May 2017 13:51:17 -0400 Subject: [PATCH 4/4] ueagle-atm: Adjust three checks for null pointers From: SF Markus Elfring To: linux-usb@vger.kernel.org, Greg Kroah-Hartman , Matthieu Castet , Stanislaw Gruszka Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: Date: Fri, 19 May 2017 19:51:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:/60funYUHWlE30jTjipfKJH1drTgotT88n93dnIoh/yWZ9Tanlx 6q6a9r7E7fsd7/kBDZ9mAt2nQxDPWAxb+QqYNXXm17VdK7E0ndvAe5TnvoaMkakjBf/94U6 iZd1ugY225P8def29vABPCMRxDHGvhYnhs0WgfHAO2EcN/Gbhll9mSKXWJx5VT9ESBfGyno M2kzushgYUkn0PUA1JMmA== X-UI-Out-Filterresults: notjunk:1;V01:K0:EurTPXGBtTA=:PLNkV30TYszzIceXxnEI1E xDltyvuM5lRGzfy+Bh+ndARkFMlzJ5xpoOoZHNZZZPdl0bJDzGYjSr3gKv6gtXK7VkgfWw11D MiUQYT4wPx0zCqGDcaJs6mOgoNxBcq1jUHRXui6ejpTcuT7OCz4VDrxG3zIO5uQrjMmLi59/W 9oKnSJQ6lCHqLBvlOQKenfJn4zE2VChGfuPj75/qAwwzD9c+nTILBz0bBXi9LnRph0lVU1Etj 8179pmOaVn7uwaGJcoS31KNSkrEUr/6fBd/wuk0VH6WYSWhV+40G6We26U/HrCeMvO9wmpQ9E mwGIMcMx/EJfrhdFIqkYk/JOfUapJBnNdZc/957teYqca8ffjvGJVLzYpMvB4LaOt3uQ4X68X +SQQc6pbnY68zzPjEY2LorVyOb7b7IyfWLqCHpFoOJ7cI3pFVOluNOOAO+RKRKqu4dp8462ff GWBVvVQayjixcaJ0GPhjlhEE02wu42u7S5xuYhcCztF8VsgMxdThzr6S4DuL2NUAqdda3zNja B0L9TlBEvO5MvbHTi6KVnRu7EOohDToMtUlMS9B/JTmLnTxbSHUM/WiobQU9EYDhM4nuKK2Ru UhUBO5PCb5gLXJCahMsD5BWwkS6UwIfRtpnkkP/2R0GaC8aE33rSFClLNb38qAvx6qFxh/np5 vNVg6VhLRYnrJ3dzGOaFyP0m+GNDK68zL7NSFvC6pwQSaAGd7cWb1YuW2k2OOpcUNTI5ywYdT qw+c39+u6tMk9tADzvWDqDaaIZ4zbEMjISfbfmMsXDhec4DGiA55L9kdgRKS8w3yhCiAbKGmw N2CswhK Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 19 May 2017 19:29:08 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- drivers/usb/atm/ueagle-atm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index 0ca4ff3e6683..5c9517bfb82c 100644 --- a/drivers/usb/atm/ueagle-atm.c +++ b/drivers/usb/atm/ueagle-atm.c @@ -955,7 +955,7 @@ static void uea_load_page_e1(struct work_struct *work) sc->dsp_firm = NULL; } - if (sc->dsp_firm == NULL && request_dsp(sc) < 0) + if (!sc->dsp_firm && request_dsp(sc) < 0) return; p = sc->dsp_firm->data; @@ -1076,7 +1076,7 @@ static void uea_load_page_e4(struct work_struct *work) sc->dsp_firm = NULL; } - if (sc->dsp_firm == NULL && request_dsp(sc) < 0) + if (!sc->dsp_firm && request_dsp(sc) < 0) return; p = (struct l1_code *) sc->dsp_firm->data; @@ -1596,7 +1596,7 @@ static void cmvs_file_name(struct uea_softc *sc, char *const cmv_name, int ver) kernel_param_lock(THIS_MODULE); /* set proper name corresponding modem version and line type */ - if (cmv_file[sc->modem_index] == NULL) { + if (!cmv_file[sc->modem_index]) { if (UEA_CHIP_VERSION(sc) == ADI930) file_arr[3] = '9'; else if (UEA_CHIP_VERSION(sc) == EAGLE_IV) -- 2.13.0