From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8F25C43334 for ; Mon, 25 Jul 2022 10:04:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234397AbiGYKEQ (ORCPT ); Mon, 25 Jul 2022 06:04:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234229AbiGYKEM (ORCPT ); Mon, 25 Jul 2022 06:04:12 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A51BB17592; Mon, 25 Jul 2022 03:04:11 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id A21D966015E7; Mon, 25 Jul 2022 11:04:09 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1658743450; bh=2lcWg722C+EKD6yIIuLQdkUd6bCzFnI+eE4dlAuYUvE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=aTKVeBbPxPQMF3hLlMWrsWuRihreLRQH9UCFrXPqBm4W9IFBHx3LIEckYUpH7Jznp jftBFM/FE5iw+c+wrZH/DsqscBopHD5RaAepTB87HfQ9KOX/X0VMX6eAzPQKPXQ4gf y0dG7Q4qzBpCkT/mn3XHYUAPxAhGP6m9p/lbXILkqiyDkPWIp8R5ei0688I1fRAIA4 oHzw5wNtNaiM6Ai5oKHVnzd03h1Tv655l5RJoFKyFgxXt4DkvwTJs3ChJx2zO9k2aG 2I+Q40k4192L9t5/X3lmTY5fSdhhgTW2O5DfotNaCc71tOxzZAuX+NWkfpAQmb7BRm eloD87cUq4+dw== Message-ID: Date: Mon, 25 Jul 2022 12:04:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 7/8] arm64: dts: mediatek: cherry: Enable keyboard PWM backlight Content-Language: en-US To: Chen-Yu Tsai Cc: matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220721145017.918102-1-angelogioacchino.delregno@collabora.com> <20220721145017.918102-8-angelogioacchino.delregno@collabora.com> From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 25/07/22 11:57, Chen-Yu Tsai ha scritto: > n Thu, Jul 21, 2022 at 10:53 PM AngeloGioacchino Del Regno > wrote: >> >> Add a pwm-leds node to enable the PWM controlled keyboard backlight. >> >> Signed-off-by: AngeloGioacchino Del Regno >> --- >> arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi >> index ca9955a97f8f..9086a440a995 100644 >> --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi >> +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi >> @@ -4,6 +4,7 @@ >> */ >> >> #include >> +#include >> #include "mt8195.dtsi" >> #include "mt6359.dtsi" >> >> @@ -31,6 +32,18 @@ dmic_codec: dmic-codec { >> wakeup-delay-ms = <50>; >> }; >> >> + led-controller { >> + compatible = "pwm-leds"; >> + >> + keyboard_backlight: keyboard-backlight { >> + default-state = "off"; >> + function = LED_FUNCTION_KBD_BACKLIGHT; >> + label = "cros_ec::kbd_backlight"; >> + max-brightness = <1023>; >> + pwms = <&cros_ec_pwm 3>; >> + }; >> + }; >> + > > This didn't work for me. However using "google,cros-kbd-led-backlight" > under the EC did. That might be a better option. Strange. But okay if there's a better option I'll check that out for v3. Cheers! Angelo > > ChenYu > >> memory@40000000 { >> device_type = "memory"; >> reg = <0 0x40000000 0 0x80000000>; >> -- >> 2.35.1 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel