From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB42AC43441 for ; Fri, 9 Nov 2018 06:58:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D4502086C for ; Fri, 9 Nov 2018 06:58:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="haO6jyPF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D4502086C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728035AbeKIQhN (ORCPT ); Fri, 9 Nov 2018 11:37:13 -0500 Received: from mail-pf1-f195.google.com ([209.85.210.195]:38111 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727819AbeKIQhN (ORCPT ); Fri, 9 Nov 2018 11:37:13 -0500 Received: by mail-pf1-f195.google.com with SMTP id b11-v6so505960pfi.5; Thu, 08 Nov 2018 22:58:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3TbiQjbBqhyV3CrR2oqAqSqqpJbmnaZTjUVEGGQj9j8=; b=haO6jyPFK/PPZueueZiXnXsZO+zSY7JFkAAqeKH/MJAC8WrpWsiFJJAYewwg199fU3 BOH6DNlgb11rUHJwgLhrONbSVDlC0G2qAGF4jeDHoL8Vd6q5bGK73GMDr72JYur4Wnde oTgsZ29qpkBkc2OgFVQ8MVQDwOjtMvVPjf6Odp371XrnnWbAs8FZgRrANnfryN5GuxSa 5A7QMtUdjj3Vrnps1Qn74+QT4Oam/2Ejh/JOzTqqlEE1dIZs2HmKX593oYAEx9TzFqnx 2YFP0pp2FZeUxVKFNqGb8N2YtmWpQ/1v8sOwImLG6WSFHF5tXzxkavsLGW6F+6aTCYl4 n8xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3TbiQjbBqhyV3CrR2oqAqSqqpJbmnaZTjUVEGGQj9j8=; b=bPQPBkwOBSSfSZLKpss6SpKiSDyRckU66SkP1tBs3F1Vd1pP16winWd3Et6VuFUfrA Z3/3rCoy4nXmqbONExncV9kzkNXcEjddltcmd/162Wc2OjTmoV4zJr2dg88SUK7vCtPg e+mkb5yXGkkLAIhJ+evWChv7/Sp0nWKN5f5G+blPnp3oYkH3bV+YX6AVeUFzX8/c97fO ONcAZghBkzSaJbHSsfhy/0fyQpNjxsEfvgXp1Lj1YIhEoQ35Vrw9TyuK33qDBzDttweH SBGT70/7FK/pJBfLeNdvsPi/B6by7/uwkOvz+CcT9TwdUJRsMY80pVHK3SXZAGs33Gli NC4w== X-Gm-Message-State: AGRZ1gJAzWrWmze67LfHtE8kTRe5qgj6Ehbz1rpPEjyCFQ5B+4yrl3v+ gZX+FvKm5MhBOrZDIn5o8MU= X-Google-Smtp-Source: AJdET5dOUy2P5GJHQhoJ2dQWnwYjJc4NWPZBWtrGVhMpoNAMtgui/fTEXdvUhkPlR/X/yjGbNP5K0g== X-Received: by 2002:a62:1d50:: with SMTP id d77-v6mr7583245pfd.87.1541746681317; Thu, 08 Nov 2018 22:58:01 -0800 (PST) Received: from [192.168.1.70] (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id g7-v6sm6064507pfo.139.2018.11.08.22.57.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Nov 2018 22:58:00 -0800 (PST) Subject: Re: [GIT PULL] of: overlay: validation checks, subsequent fixes for v20 -- correction: v4.20 From: Frank Rowand To: Rob Herring , Pantelis Antoniou , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Alan Tull , Moritz Fischer Cc: "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linuxppc-dev , linux-fpga@vger.kernel.org References: <262419e9-5c9f-1193-f119-33f373d81e43@gmail.com> Message-ID: Date: Thu, 8 Nov 2018 22:57:59 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <262419e9-5c9f-1193-f119-33f373d81e43@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/8/18 10:56 PM, Frank Rowand wrote: > Hi Rob, > > Please pull the changes to add the overlay validation checks. > > This is the v7 version of the patch series. > > -Frank > > > The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: > > Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/frowand/linux.git tags/kfree_validate_v7-for-4.20 > > for you to fetch changes up to eeb07c573ec307c53fe2f6ac6d8d11c261f64006: > > of: unittest: initialize args before calling of_*parse_*() (2018-11-08 22:12:37 -0800) > > ---------------------------------------------------------------- > Add checks to (1) overlay apply process and (2) memory freeing > triggered by overlay release. The checks are intended to detect > possible memory leaks and invalid overlays. > > The checks revealed bugs in existing code. Fixed the bugs. > > While fixing bugs, noted other issues, which are fixed in > separate patches. > > ---------------------------------------------------------------- > Frank Rowand (17): > of: overlay: add tests to validate kfrees from overlay removal > of: overlay: add missing of_node_put() after add new node to changeset > of: overlay: add missing of_node_get() in __of_attach_node_sysfs > powerpc/pseries: add of_node_put() in dlpar_detach_node() > of: overlay: use prop add changeset entry for property in new nodes > of: overlay: do not duplicate properties from overlay for new nodes > of: overlay: reorder fields in struct fragment > of: overlay: validate overlay properties #address-cells and #size-cells > of: overlay: make all pr_debug() and pr_err() messages unique > of: overlay: test case of two fragments adding same node > of: overlay: check prevents multiple fragments add or delete same node > of: overlay: check prevents multiple fragments touching same property > of: unittest: remove unused of_unittest_apply_overlay() argument > of: overlay: set node fields from properties when add new overlay node > of: unittest: allow base devicetree to have symbol metadata > of: unittest: find overlays[] entry by name instead of index > of: unittest: initialize args before calling of_*parse_*() > > arch/powerpc/platforms/pseries/dlpar.c | 2 + > drivers/of/dynamic.c | 59 ++++- > drivers/of/kobj.c | 4 +- > drivers/of/overlay.c | 292 ++++++++++++++++----- > drivers/of/unittest-data/Makefile | 2 + > .../of/unittest-data/overlay_bad_add_dup_node.dts | 28 ++ > .../of/unittest-data/overlay_bad_add_dup_prop.dts | 24 ++ > drivers/of/unittest-data/overlay_base.dts | 1 + > drivers/of/unittest.c | 96 +++++-- > include/linux/of.h | 21 +- > 10 files changed, 432 insertions(+), 97 deletions(-) > create mode 100644 drivers/of/unittest-data/overlay_bad_add_dup_node.dts > create mode 100644 drivers/of/unittest-data/overlay_bad_add_dup_prop.dts >